Ubuntu
firefox-3.0 package

click on bookmark crashes firefox with java content in clipboard

Bug #372103 reported by Wouter Gazendam
132
This bug affects 23 people
Affects Status Importance Assigned to Milestone
GTK+
Fix Released
Critical
XULRunner
Fix Released
Medium
firefox-3.0 (Ubuntu)
Invalid
Medium
Unassigned
Karmic
Invalid
Undecided
Unassigned
firefox-3.5 (Ubuntu)
Invalid
Medium
Unassigned
Karmic
Invalid
Undecided
Unassigned
gtk+2.0 (Ubuntu)
Fix Released
Medium
Unassigned
Karmic
Fix Released
Low
Unassigned

Bug Description

Users are crashing if their clipboard contains anything from a Java OpenJDK app if they try to use their bookmarks in Firefox.

This is due to a workaround that was implemented in GTK originally due to a bug in Java that was subsequently fixed. This workaround has been removed in GTK 2.19.1 which is now in Lucid.

The attached debdiff contains the simple removal of the workaround from the GTK upstream bug commit.

TEST CASE:
- install openjdk-6-jdk
- verify it is selected with 'java -version'
- install netbeans
- start firefox
- start netbeans
- in netbeans: using any input field or editor window (create any new project and any new file in it) copy with Ctrl-C any text to clipboard
- switch to Firefox, click on any bookmark in bookmark tab tree (Left Bookmarks Sidebar)
- Firefox crashes

In fact, instead of netbeans any java swing application can be used.

---------------------------------------------------------

Binary package hint: firefox-3.0

When I right click on a bookmark in the bar above the tabs, or in the Bookmarks menu, firefox crashes sporadically.

Description: Ubuntu 9.04
Release: 9.04

firefox:
  Installed: 3.0.10+nobinonly-0ubuntu0.9.04.1
  Candidate: 3.0.10+nobinonly-0ubuntu0.9.04.1
  Version table:
 *** 3.0.10+nobinonly-0ubuntu0.9.04.1 0
        500 http://nl.archive.ubuntu.com jaunty-updates/main Packages
        500 http://security.ubuntu.com jaunty-security/main Packages
        100 /var/lib/dpkg/status
     3.0.8+nobinonly-0ubuntu3 0
        500 http://nl.archive.ubuntu.com jaunty/main Packages

ProblemType: Bug
Architecture: amd64
DistroRelease: Ubuntu 9.04
Package: firefox-3.0 3.0.10+nobinonly-0ubuntu0.9.04.1
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: firefox-3.0
Uname: Linux 2.6.28-11-generic x86_64

See original description
Revision history for this message
Wouter Gazendam (launchpad-net-gazendam) wrote :
Revision history for this message
Thierry Lemaire (thierry-lemaire) wrote :

same problem for me with the same config. I've also a crash when i try to click on the folder of bookmarks in the left panel and in the bookmark menu.

summary: - right click on bookmark crashes firefox
+ click on bookmark crashes firefox
Revision history for this message
Kurt Wall (kwall) wrote : Re: click on bookmark crashes firefox

Thanks for taking the time to report this bug and helping to improve Ubuntu. Could you please add more information for it by following the suggestions at https://wiki.ubuntu.com/MozillaTeam/Bugs. In particular, can you reproduce this behavior using a new profile? It isn't necessary to delete your current profile; just create a new one. It would also be useful to get console output and/or a stack trace, again using the instructions provided at https://wiki.ubuntu.com/MozillaTeam/Bugs.

Thanks and regards,

Kurt

Revision history for this message
Thierry Lemaire (thierry-lemaire) wrote : Re: [Bug 372103] Re: click on bookmark crashes firefox

I tried several times by deleting my profile (I removed the .mozilla
directory in my home directory) and I still have this problem.

This issue occurs randomly after a long time spent using the browser. and
when firefox bug, I can reproduce (almost all the time) immediatly by
clicking on a bookmark.

If I launch firefox from a terminal, I have the "Segmentation fault" error
diplayed.

Regards

2009/5/22 Kurt Wall <email address hidden>

> Thanks for taking the time to report this bug and helping to improve
> Ubuntu. Could you please add more information for it by following the
> suggestions at https://wiki.ubuntu.com/MozillaTeam/Bugs. In particular,
> can you reproduce this behavior using a new profile? It isn't necessary
> to delete your current profile; just create a new one. It would also be
> useful to get console output and/or a stack trace, again using the
> instructions provided at https://wiki.ubuntu.com/MozillaTeam/Bugs.
>
> Thanks and regards,
>
> Kurt
>
> --
> click on bookmark crashes firefox
> https://bugs.launchpad.net/bugs/372103
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Revision history for this message
Kurt Wall (kwall) wrote : Re: click on bookmark crashes firefox

Thierry, thanks for the reply. I'm not able to reproduce this behaviour here. A first step would be to execute the following command in a terminal session, and then to run firefox from that console: "ulimit -c unlimited". This will produce a core file if/when Firefox segfaults. A more comprehensive approach is described in https://wiki.ubuntu.com/MozillaTeam/Bugs#Crashes.

Revision history for this message
Thierry Lemaire (thierry-lemaire) wrote : Re: [Bug 372103] Re: click on bookmark crashes firefox

Hi, finally I was able to create the gdb-firefox.txt file.

Regards

2009/5/23 Kurt Wall <email address hidden>

> Thierry, thanks for the reply. I'm not able to reproduce this behaviour
> here. A first step would be to execute the following command in a
> terminal session, and then to run firefox from that console: "ulimit -c
> unlimited". This will produce a core file if/when Firefox segfaults. A
> more comprehensive approach is described in
> https://wiki.ubuntu.com/MozillaTeam/Bugs#Crashes.
>
> --
> click on bookmark crashes firefox
> https://bugs.launchpad.net/bugs/372103
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Revision history for this message
Stephan Zanger (bungoleena) wrote : Re: click on bookmark crashes firefox

We have the same problem with our 3 newly installed ubuntu systems, all running nearly the same configuration as already described above.

For us it looks like this issue is somehow related to the clipboard.

The crash is reproducable when we copy text in any other application with Ctrl+c. If we then try to click into our bookmarks, firefox crashes. On my particular system also the left and middle mouse button let firefox crash.

If you now restart firefox, mark and copy some random text on a site with Ctrl+c, you are able to use firefox. If you dont copy anything in firefox (overwrite clipboard content?), it keeps crashing on bookmark clicks.
Using middlemouse for copy paste doesnt help or affect firefox.

best regards
stephan

Revision history for this message
StormForge (br-cs) wrote : Re: [Bug 372103] Re: click on bookmark crashes firefox

Hi Kurt -- I have a 43 MB core file. Do you want it? It's from the
standard version of firefox rather than the debug version.

Thanks,
-Bill

Kurt Wall wrote:
> Thierry, thanks for the reply. I'm not able to reproduce this behaviour
> here. A first step would be to execute the following command in a
> terminal session, and then to run firefox from that console: "ulimit -c
> unlimited". This will produce a core file if/when Firefox segfaults. A
> more comprehensive approach is described in
> https://wiki.ubuntu.com/MozillaTeam/Bugs#Crashes.
>
>

Revision history for this message
Kurt Wall (kwall) wrote : Re: click on bookmark crashes firefox

StormForge,

Oy, a 43MB core file. I have no idea if you can attached a file that large or not. But, give it a shot and if it is too big, we'll work something out.

Regards,

Kurt

Changed in firefox-3.0 (Ubuntu):
status: New → Confirmed
1 comments hidden view all 135 comments
Revision history for this message
In , Stransky (stransky) wrote :

Downstream bug https://bugzilla.redhat.com/show_bug.cgi?id=501685

There's a crash at nsClipboard::HasDataMatchingFlavors()

Bactrace:

Thread 1 (Thread 20486):
#0 0x00000033b140ed5b in raise (sig=<value optimized out>) at
../nptl/sysdeps/unix/sysv/linux/pt-raise.c:42
#1 0x0000003f72873244 in nsProfileLock::FatalSignalHandler (signo=11) at
nsProfileLock.cpp:212
#2 <signal handler called>
#3 strcmp () at ../sysdeps/x86_64/strcmp.S:29
#4 0x0000003f7306c82d in nsClipboard::HasDataMatchingFlavors (this=<value
optimized out>,
    aFlavorList=<value optimized out>, aLength=1, aWhichClipboard=<value
optimized out>, _retval=0x7fff29c80a1c)
    at nsClipboard.cpp:448
#5 0x0000003f72e3d243 in nsHTMLEditor::HavePrivateHTMLFlavor (this=<value
optimized out>, aClipboard=0x0)
    at nsHTMLDataTransfer.cpp:1844
#6 0x0000003f72e3f5ff in nsHTMLEditor::Paste (this=0x7f430705f800,
aSelectionType=0) at nsHTMLDataTransfer.cpp:1869
#7 0x0000003f72d23ee6 in nsTextEditorMouseListener::MouseClick
(this=0x7f430704fd80, aMouseEvent=<value optimized out>)
    at nsEditorEventListeners.cpp:362
#8 0x0000003f72e7fb45 in nsHTMLEditorMouseListener::MouseClick
(this=0x7f430704fd80, aMouseEvent=0x7f43071b9640)
    at nsHTMLEditorMouseListener.cpp:307
[...]

It's here at sClipboard.cpp:448

  for (PRInt32 j = 0; j < n_targets; j++) {
     gchar *atom_name = gdk_atom_name(targets[j]);
>> if (!strcmp(atom_name, aFlavorList[i]))
         *_retval = PR_TRUE;

Looks like gdk_atom_name(targets[j]) returns NULL and we don't catch it.

Revision history for this message
In , Stransky (stransky) wrote :

The check is missing everywhere (Trunk, 1.9.1 & 1.9.0).

Revision history for this message
In , Stransky (stransky) wrote :

Created an attachment (id=380384)
patch

Simple NULL check added to nsClipboard::HasDataMatchingFlavors() and nsDragService::IsTargetContextList(). It applies to Trunk.

Revision history for this message
In , Stransky (stransky) wrote :

(From update of attachment 380384)
Can you check it please?

Revision history for this message
In , Mozbugz (mozbugz) wrote :

Thanks, Martin.

I don't understand why we should ever have (in gdk_atom_name)
GPOINTER_TO_UINT(targets[j]) >= virtual_atom_array->len

Would you have a testcase that you could make available to me, please?

Revision history for this message
In , Stransky (stransky) wrote :

I tried hard to reproduce it with instructions from original bugreport but w/o success. So at least I tested that gdk_atom_name() can really return the NULL value although official GTK documentation doesn't claims it.

Revision history for this message
In , Mozbugz (mozbugz) wrote :

gdk_atom_name() can return NULL, but only if it is given a bad GdkAtom parameter.

The problem appears to be that the GdkAtom is bad. I'd prefer to wait for more data to work out why the GdkAtom is bad, rather than patch some of the symptoms.

Revision history for this message
In , Stransky (stransky) wrote :

I think the pointer check is always good thing. There have been many bugs/crashes in mozilla codebase where somebody doesn't check the pointer value...

Revision history for this message
Henrik Storner (henrik-hswn) wrote : Re: click on bookmark crashes firefox

I have the exact same issue here - Ubuntu 9.04-amd64 with firefox "3.0.10+nobinonly-0ubuntu0.9.04.1". For me, it crashes immediately after startup when I right-click on any item in the bookmarks toolbar.

Backtrace from the core file looks like this:
#0 0x00007fece830df3b in raise () from /lib/libpthread.so.0
#1 0x00007fece5dad647 in ?? () from /usr/lib/xulrunner-1.9.0.10/libxul.so
#2 <signal handler called>
#3 0x00007fece765f6a0 in strcmp () from /lib/libc.so.6
#4 0x00007fece64740ce in ?? () from /usr/lib/xulrunner-1.9.0.10/libxul.so
#5 0x00007fece6535604 in NS_InvokeByIndex_P () from /usr/lib/xulrunner-1.9.0.10/libxul.so
#6 0x00007fece5dcfe91 in ?? () from /usr/lib/xulrunner-1.9.0.10/libxul.so
#7 0x00007fece5dd7c21 in ?? () from /usr/lib/xulrunner-1.9.0.10/libxul.so
#8 0x00007fece7379074 in js_Invoke () from /usr/lib/xulrunner-1.9.0.10/libmozjs.so
#9 0x00007fece736be17 in ?? () from /usr/lib/xulrunner-1.9.0.10/libmozjs.so
#10 0x00007fece73790bb in js_Invoke () from /usr/lib/xulrunner-1.9.0.10/libmozjs.so
#11 0x00007fece5dcd3f3 in ?? () from /usr/lib/xulrunner-1.9.0.10/libxul.so
#12 0x00007fece65361f1 in ?? () from /usr/lib/xulrunner-1.9.0.10/libxul.so
#13 0x00007fece653569f in ?? () from /usr/lib/xulrunner-1.9.0.10/libxul.so
#14 0x000000000265ea30 in ?? ()
#15 0x0000000002867670 in ?? ()
#16 0x00007ffff0732ff8 in ?? ()
#17 0x00007ffff0732fe0 in ?? ()
#18 0x0000000001a17a90 in ?? ()
#19 0x0000000000000000 in ?? ()

Corefile is about 6 MB compresssed, will try to attach it.

Revision history for this message
John Vivirito (gnomefreak) wrote :

If you are able to reproduce this crash please use apport to file this bug so i can get a better idea on what is causing this.

Us a new profile see if you can than reproduce this bug. if so please file it using apport.

Changed in firefox-3.0 (Ubuntu):
status: Confirmed → Invalid
Revision history for this message
Dan (djgavenda2) wrote : apport-collect data

Architecture: i386
DistroRelease: Ubuntu 9.04
NonfreeKernelModules: nvidia
ProcEnviron:
 SHELL=/bin/bash
 PATH=(custom, no user)
 LANG=en_US.UTF-8
Uname: Linux 2.6.28-11-generic i686
UserGroups: adm admin audio cdrom dialout dip floppy glassfish lpadmin mysql plugdev redsky sambashare scanner video

Revision history for this message
Dan (djgavenda2) wrote : Re: click on bookmark crashes firefox

I can recreate it even w/ a new profile. This is an annoying bug. Anytime I right click on the bookmark bar in Firefox, FF will crash.

Revision history for this message
Milos M (milos-miljkovic) wrote :

Using Ubuntu 9.04 64-bit, Firefox crashes related to clipboard. If a bookmark is clicked after using Ctrl+c or Ctrl+v in Matlab, Firefox closes. If clipboard is used last by Firefox (Ctrl+c or Ctrl+v) all is fine. Profile renewal does not help.

Revision history for this message
Stephan Zanger (bungoleena) wrote :

A simple but stupid workaround for our workgroup is running xclipboard all the time on an unused desktop or something.
As long as xclipboard is running (simple application to view clipboard content etc), firefox doesn't crash.

Revision history for this message
Tristan Schmelcher (tschmelcher) wrote :

Same problem here. Attaching backtrace with full symbols and changing back to Confirmed.

$ apt-cache policy firefox
firefox:
  Installed: 3.0.11+build2+nobinonly-0ubuntu0.9.04.1
  Candidate: 3.0.11+build2+nobinonly-0ubuntu0.9.04.1
  Version table:
 *** 3.0.11+build2+nobinonly-0ubuntu0.9.04.1 0
        500 http://archive.ubuntu.com jaunty-updates/main Packages
        500 http://archive.ubuntu.com jaunty-security/main Packages
        500 http://security.ubuntu.com jaunty-security/main Packages
        100 /var/lib/dpkg/status
     3.0.8+nobinonly-0ubuntu3 0
        500 http://archive.ubuntu.com jaunty/main Packages
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=9.04
DISTRIB_CODENAME=jaunty
DISTRIB_DESCRIPTION="Ubuntu 9.04"
$

Changed in firefox-3.0 (Ubuntu):
status: Invalid → Confirmed
Revision history for this message
In , Mozbugz (mozbugz) wrote :

*** Bug 501080 has been marked as a duplicate of this bug. ***

Revision history for this message
Tristan Schmelcher (tschmelcher) wrote : Re: click on bookmark crashes firefox

Also occurs with the Karmic FF 3.5.2 package.

Revision history for this message
G Cole (gregjcole) wrote :

This same situation has been happening to me as well. It seems to be related to the clipboard and/or the bookmarks. I have not been able to get a log of the problem since the whole system hangs when it happens. I am running Ubuntu Jaunty AMD64 version.

Revision history for this message
G Cole (gregjcole) wrote :

here is the trace back:

apt-cache policy firefox
firefox:
  Installed: 3.5.3~hg20090821r26255+nobinonly-0ubuntu2~umd1~jaunty
  Candidate: 3.5.3~hg20090821r26255+nobinonly-0ubuntu2~umd1~jaunty
  Version table:
 *** 3.5.3~hg20090821r26255+nobinonly-0ubuntu2~umd1~jaunty 0
        500 http://ppa.launchpad.net jaunty/main Packages
        100 /var/lib/dpkg/status
     3.0.13+nobinonly-0ubuntu0.9.04.1 0
        500 http://us.archive.ubuntu.com jaunty-updates/main Packages
        500 http://security.ubuntu.com jaunty-security/main Packages
     3.0.8+nobinonly-0ubuntu3 0
        500 http://us.archive.ubuntu.com jaunty/main Packages

Revision history for this message
G Cole (gregjcole) wrote :

 cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=9.04
DISTRIB_CODENAME=jaunty
DISTRIB_DESCRIPTION="Ubuntu 9.04"

Revision history for this message
In , Mats Palmgren (matspal) wrote :

*** Bug 511876 has been marked as a duplicate of this bug. ***

Revision history for this message
Krzysztof Juzaszek (aborygen3-wp) wrote : Re: click on bookmark crashes firefox

The same problem on Ubuntu 9.04 amd64

Revision history for this message
Tristan Schmelcher (tschmelcher) wrote :

Anyone have any idea why this makes the desktop unresponsive? The fact that a clipboard bug in Firefox can hang the whole system is a severe bug in the system itself. Whenever I accidentally trigger this bug I have to switch to a virtual terminal to kill Firefox.

Revision history for this message
John Vivirito (gnomefreak) wrote :

Tristan
Please file a separte bug since this bug is about Firefox crashing not hanging.
From hanging POV you may want to run firefox with a new profile. See link below on how to use new profile:
https://wiki.ubuntu.com/MozillaTeam/Bugs#Try%20with%20a%20new%20profile

Revision history for this message
John Vivirito (gnomefreak) wrote :

I thought i already commented on this bug.
Tristan you bug is not the same as this one please file a new bug using ubuntu bugs
the command to do this is below:
ubuntu-bugs firefox-3.0
or if using 3.5 just replace firefox-3.0 to firefox-3.5

Revision history for this message
Tristan Schmelcher (tschmelcher) wrote :

Thanks John. I thought from G Cole's comment that we all had the same bug, but I guess not. I've filed the hang behaviour as bug #429819.

Revision history for this message
In , pureblood (freeseek) wrote :

Please, add the pointer check, for the sake of saving time to hundreds of people around there. I do not understand why this bug is not considered a top priority for the team. I have starting experiencing this but with Thunderbird 2, around six months ago. I was startled. The crashes happened on four different machines I owned, so it must be overly spread. I upgraded to Thunderbird 3 hoping the problem to be solved, but it was not (I use version 3.0~b4~hg20090908r3585+nobinonly-0ubuntu1~umd1~jaunty). I have lost a lot of time having to rewrite my emails because of these crashes and now I have developed the practice to first copy the whole text of the email to the clipboard before pasting anything into it. The crash happens both on 32 bits machines and 64 bits machines. Also, it happens with all the machines I have, running either Ubuntu Intrepid or Jaunty. I have been wondering how the developers cope with that. Maybe the fact that I use KDE has something to do with it? Please do not let this bug open.

Revision history for this message
In , Mozbugz (mozbugz) wrote :

giulio, are there some particular apps from which copying causes the crash?
Any core KDE apps? Which versions?
(So far there only seem to have been reports from java apps.)

Revision history for this message
In , pureblood (freeseek) wrote :

Actually, my experience has been that the problem is extensive. Sometimes I copy text from kile and it crashes, sometimes from firefox, sometimes from chrome-browser and sometimes it crashes even when I paste text copied from Thunderbird itself. It does not crash if I paste the text in the subject field. The problem is not reproducible though. But when it crashes I know that I can reproduce it with what I have in the clipboard, as long as I do not change it. But I have not noticed any pattern. Actually, if I paste what I have in the clipboard and I copy it again, it usually does not crash. Sometimes it is even enough to open Klipper (the KDE clipboard manager), reselect what is already selected, and paste again, and it works fine. Please, let me know if you want me to debug it. I have no experience with debugging but I am willing to dedicate time to this.

Revision history for this message
In , pureblood (freeseek) wrote :

By the way, someone in this forum: http://bugs.archlinux.org/task/14076 mentioned as well that he is using KDE4 and not Gnome.

Bug Watch Updater (bug-watch-updater)
Changed in xulrunner:
status: Unknown → In Progress
ilna (a-gaydenko)
Changed in firefox-3.5 (Ubuntu):
status: New → Confirmed
55 comments hidden view all 135 comments
Revision history for this message
In , Stransky (stransky) wrote :

with gtk2-2.18.3-21.fc12.x86_64

Revision history for this message
In , Stransky (stransky) wrote :

The crash is reproducible on x86_64 too, with:

$java -version
java version "1.6.0_0"
OpenJDK Runtime Environment (IcedTea6 1.6) (fedora-33.b16.fc12-x86_64)
OpenJDK 64-Bit Server VM (build 14.0-b16, mixed mode)

There's one trick there - don't use proprietary java VM from sun, it seems to crash with the OpenJDK only.

Revision history for this message
In , Stransky (stransky) wrote :

As for the risk assessment, it's generally strcmp -> g_strcmp0 change at a few places. It can't regress unless there's a typo in the patch (or regression inside glib itself).

Revision history for this message
In , Bugzilla-standard8 (bugzilla-standard8) wrote :

(From update of attachment 412175)
See comments 52-55 for clear STR and risk assessments (I'm told we're seeing this a lot in Thunderbird on Linux as well).

Revision history for this message
In , Joe-drew (joe-drew) wrote :

It hurts me, but I don't think we should block on this. I do think this patch should be approved, though.

Revision history for this message
In , Karlt (karlt) wrote :

Yes, I don't think we should block on workarounds for every new bug introduced in GTK. However, the patch is safe to take.

Revision history for this message
In , Beltzner (beltzner) wrote :

Not blocking, a192=beltzner

Revision history for this message
In , Bugzilla-standard8 (bugzilla-standard8) wrote :

Checked into mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/c9c35333436b

Revision history for this message
In , Bugzilla-standard8 (bugzilla-standard8) wrote :

I had to back this out due to Linux build bustages across all trees:

http://hg.mozilla.org/mozilla-central/rev/6432560e430e

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1259100980.1259101752.9386.gz

/builds/slave/mozilla-central-linux/build/widget/src/gtk2/nsClipboard.cpp: In member function ‘virtual nsresult nsClipboard::HasDataMatchingFlavors(const char**, PRUint32, PRInt32, PRBool*)’:
/builds/slave/mozilla-central-linux/build/widget/src/gtk2/nsClipboard.cpp:434: error: ‘g_strcmp0’ was not declared in this scope
/builds/slave/mozilla-central-linux/build/widget/src/gtk2/nsClipboard.cpp:438: error: ‘g_strcmp0’ was not declared in this scope
NEXT ERROR make[6]: *** [nsClipboard.o] Error 1
make[6]: *** Waiting for unfinished jobs....
/builds/slave/mozilla-central-linux/build/widget/src/gtk2/nsDragService.cpp: In member function ‘virtual nsresult nsDragService::IsDataFlavorSupported(const char*, PRBool*)’:
/builds/slave/mozilla-central-linux/build/widget/src/gtk2/nsDragService.cpp:834: error: ‘g_strcmp0’ was not declared in this scope
/builds/slave/mozilla-central-linux/build/widget/src/gtk2/nsDragService.cpp:840: error: ‘g_strcmp0’ was not declared in this scope
/builds/slave/mozilla-central-linux/build/widget/src/gtk2/nsDragService.cpp:849: error: ‘g_strcmp0’ was not declared in this scope
/builds/slave/mozilla-central-linux/build/widget/src/gtk2/nsDragService.cpp:858: error: ‘g_strcmp0’ was not declared in this scope
/builds/slave/mozilla-central-linux/build/widget/src/gtk2/nsDragService.cpp: In member function ‘PRBool nsDragService::IsTargetContextList()’:
/builds/slave/mozilla-central-linux/build/widget/src/gtk2/nsDragService.cpp:981: error: ‘g_strcmp0’ was not declared in this scope
make[6]: *** [nsDragService.o] Error 1

Revision history for this message
In , Mozilla (mozilla) wrote :

argl, g_strcmp0() needs glib 2.16. That seems to be too recent.

Revision history for this message
In , Karlt (karlt) wrote :

Yes, sorry. That was my suggestion. I thought I checked but obviously I did something wrong.

Revision history for this message
In , Karlt (karlt) wrote :

(From update of attachment 380384)
Let's go back to this, then.

The check in nsDragService isn't really necessary because GdkDragContext is not subject to the same bug, but I guess it's consistent to do the same check everywhere.

Revision history for this message
In , Karlt (karlt) wrote :

(From update of attachment 380384)
Requesting approval 1.9.2 for these null checks that fix the most-reported Thunderbird crash on Linux. The patch only affect code paths in situations for which we'd crash atm.

Writing a unit test to test the crash would be a significant amount of work and would only be of any use when run with the broken versions of GTK, which we don't have on our test platforms.

This patch is a workaround for a bug in a workaround in GTK for a Java bug.
I've suggested that the incorrect workaround in GTK be removed, but there hasn't been any progress on that.

Revision history for this message
In , Karlt (karlt) wrote :

http://hg.mozilla.org/mozilla-central/rev/a293d150ebbd

Revision history for this message
In , Karlt (karlt) wrote :

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b8b04ef445a1

Revision history for this message
In , Karlt (karlt) wrote :

Also fixed in GTK+:
http://git.gnome.org/cgit/gtk+/commit/?id=6dfb21e616bdf1e1db7ed86bff08fcb68210f17e

Revision history for this message
ilna (a-gaydenko) wrote : Re: click on bookmark crashes firefox

In accordance with

https://bugzilla.mozilla.org/show_bug.cgi?id=495392

the bug is fixed by both mozilla and gtk upsteams:

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b8b04ef445a1
http://git.gnome.org/cgit/gtk+/commit/?id=6dfb21e616bdf1e1db7ed86bff08fcb68210f17e

I think it is safe to integrate 2-lines patches into appropriate Ubuntu packages.

Bug Watch Updater (bug-watch-updater)
Changed in xulrunner:
status: In Progress → Fix Released
Revision history for this message
Rene Visser (renevisser) wrote :

Also got this bug in FF 3.5.5 on Ubuntu 9.10. Besides the RMB it also crashes on a LMB click in the bookmarks sidebar. Error started after clearing the browser history.

Revision history for this message
Micah Gersten (micahg) wrote :

This has been fixed in Firefox 3.6.

Changed in firefox-3.5 (Ubuntu):
importance: Undecided → Medium
status: Confirmed → Triaged
summary: - click on bookmark crashes firefox
+ click on bookmark crashes firefox when selection contains data from java
summary: - click on bookmark crashes firefox when selection contains data from java
+ click on bookmark crashes firefox
Micah Gersten (micahg)
summary: - click on bookmark crashes firefox
+ click on bookmark crashes firefox with java content in clipboard
Revision history for this message
Micah Gersten (micahg) wrote :

Marking both Firefox 3.0 and 3.5 Triaged, but there's nothing we can do with them. The problem is in GTK. We'll see about patching that.

Changed in firefox-3.0 (Ubuntu):
importance: Undecided → Medium
status: Confirmed → Triaged
Revision history for this message
Micah Gersten (micahg) wrote :

Marking this Triaged as there's an upstream GTK bug.

Changed in gtk+2.0 (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Micah Gersten (micahg) wrote :

gtk+2.0 (2.19.1-1) experimental; urgency=low

  * New upstream development release:
    + debian/rules:
      - Include check-dist.mk to prevent accidental uploads to unstable.
    + debian/control.in:
      - Update ATK build dependency.
    + debian/rules,
      debian/libgtk-directfb-2.0-0.symbols,
      debian/libgtk2.0-0.symbols:
      - Update SHVER to 2.19.1 for the new API and add new symbols.
    + debian/patches/009_gtk-export-filechooser.patch,
      debian/patches/021_loader-files-d.patch:
      - Updated to apply cleanly again.
    + debian/patches/070_mandatory-relibtoolize.patch:
      - Regenerated for the new version.

gtk+2.0 (2.18.4-1) unstable; urgency=low

  * New upstream bugfix release:
    + debian/patches/070_mandatory-relibtoolize.patch:
      - Updated for the new version.
    + debian/patches/091_dont-omit-gtk-icon-size-dialog.patch,
      debian/patches/092_gtk-image-size-allocation.patch:
      - Dropped, merged upstream.
 -- Sebastian Dr?ge < <email address hidden> > Wed, 02 Dec 2009 11:59:41 +0000

Changed in gtk+2.0 (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Micah Gersten (micahg) wrote :

To get this fixed in Karmic, I need a reproducable test case. Could one person please edit the description at the top of the bug and add a test case? This has been fixed in Lucid as the comment above shows the sync with Debian.

Revision history for this message
ilna (a-gaydenko) wrote :

Micah, to reproduce - install any swing java app, use openjdk to run it, copy to clipboard anything in this swing app, click on firefox bookmarks.

Revision history for this message
Micah Gersten (micahg) wrote :

@ilna

Could you please see if the GTK package in my PPA fixes this for you?
https://launchpad.net/~micahg/+archive/sru-test/

Revision history for this message
ilna (a-gaydenko) wrote :

Micah,

I have added the ppa to source list, but am not sure I know how and which packages to install, and how to return to official gtk after trying the ppa.

Revision history for this message
Micah Gersten (micahg) wrote :

Here is a patch for Karmic with just this fix pulled from the upstream GTK bug.

Revision history for this message
ilna (a-gaydenko) wrote :

Micah,

How to reproduce (more elaborative):

- install openjdk-6-jdk
- verify it is selected with 'java -version'
- install netbeans
- start firefox
- start netbeans
- in netbeans: using any input field or editor window (create any new project and any new file in it) copy with Ctrl-C any text to clipboard
- switch to Firefox, click on any bookmark in bookmark tab tree
- Firefox crashes

In fact, instead of netbeans any java swing application can be used.

Fix from the ppa does work, thanks!

Micah Gersten (micahg)
description: updated
Revision history for this message
Micah Gersten (micahg) wrote :

Link to upstream cgit commit:
http://git.gnome.org/cgit/gtk+/commit/?id=6dfb21e616bdf1e1db7ed86bff08fcb68210f17e

Sebastien Bacher (seb128)
Changed in gtk+2.0 (Ubuntu Karmic):
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted gtk+2.0 into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
ilna (a-gaydenko) wrote :

Thanks! - verified for:

~$ aptitude -v -F '%c %p %V %d' --disable-columns search ~ilibgtk2
...
i libgtk2.0-0 2.18.3-1ubuntu2.1 The GTK+ graphical user interface library
i libgtk2.0-bin 2.18.3-1ubuntu2.1 The programs for the GTK+ graphical user interface library
i libgtk2.0-common 2.18.3-1ubuntu2.1 Common files for the GTK+ graphical user interface library
i libgtk2.0-dev 2.18.3-1ubuntu2.1 Development files for the GTK+ library
i libgtk2.0-doc 2.18.3-1ubuntu2.1 Documentation for the GTK+ graphical user interface library

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+2.0 - 2.18.3-1ubuntu2.1

---------------
gtk+2.0 (2.18.3-1ubuntu2.1) karmic-proposed; urgency=low

  * debian/patches/095_fix_java_clipboard_crash.patch:
    - add to fix (LP: #372103)
 -- Micah Gersten <email address hidden> Sun, 13 Dec 2009 02:33:20 -0600

Changed in gtk+2.0 (Ubuntu Karmic):
status: Fix Committed → Fix Released
Revision history for this message
Micah Gersten (micahg) wrote :

Marking Firefox tasks invalid since this was patched in GTK.

Changed in firefox-3.0 (Ubuntu):
status: Triaged → Invalid
Changed in firefox-3.0 (Ubuntu Karmic):
status: New → Invalid
Changed in firefox-3.5 (Ubuntu):
status: Triaged → Invalid
Changed in firefox-3.5 (Ubuntu Karmic):
status: New → Invalid
Revision history for this message
In , Wharms-bfs (wharms-bfs) wrote :

Just for completeness: i had the samebug with thunderbird running inside a NXcleint. No need for JAVA , just clip & bang.
thunderbird 2.0.23 on Opensuse11.1

backtrace:
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff169d854 in strcmp () from /lib64/libc.so.6
(gdb) bt
#0 0x00007ffff169d854 in strcmp () from /lib64/libc.so.6
#1 0x0000000000622b1b in nsClipboard::HasDataMatchingFlavors (this=<value optimized out>, aFlavorList=0x1000, aWhichClipboard=<value optimized out>, _retval=0x7fffffffc29c) at nsClipboard.cpp:396
#2 0x0000000000a40008 in nsHTMLEditor::HavePrivateHTMLFlavor (this=<value optimized out>, aClipboard=0x4415880) at nsHTMLDataTransfer.cpp:1846
#3 0x0000000000a400c7 in nsHTMLEditor::Paste (this=0x3a8a7d0, aSelectionType=0) at nsHTMLDataTransfer.cpp:1865

Revision history for this message
In , Bugzilla-standard8 (bugzilla-standard8) wrote :

Karl: would you be prepared to back port this to 1.9.1? We did see a few crashes with this stack for 3.0, though nothing yet for 3.0.1. It may be that the affected users have switched to something else or mainly use distro builds. I'm just wondering what your thoughts are?

Revision history for this message
In , pureblood (freeseek) wrote :

Can't agree better. I stopped using Thunderbird. This bug remained opened for too long.

Revision history for this message
In , Karlt (karlt) wrote :

(From update of attachment 380384)
Actively maintained distros using the GTK+-2.18 branch would have picked up the fix there. But distros on the GTK+-2.16 branch are unlikely to have backported the patch (Ubuntu 9.04 and Fedora 11 haven't), so applying the workaround to 1.9.1 would help people.

The patch only adds null checks in places where null values would cause a crash.

Revision history for this message
In , Dveditz (dveditz) wrote :

(From update of attachment 380384)
Approved for 1.9.1.9, a=dveditz for release-drivers

Revision history for this message
In , Bugzilla-standard8 (bugzilla-standard8) wrote :

Checked into 1.9.1:

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/62f3d28797e2

Bug Watch Updater (bug-watch-updater)
Changed in gtk:
importance: Unknown → Critical
status: Unknown → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in xulrunner:
importance: Unknown → Medium
Revision history for this message
In , Vseerror (vseerror) wrote :

*** Bug 534146 has been marked as a duplicate of this bug. ***

Displaying first 40 and last 40 comments. View all 135 comments or add a comment.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.