(From update of attachment 380384)
Requesting approval 1.9.2 for these null checks that fix the most-reported Thunderbird crash on Linux. The patch only affect code paths in situations for which we'd crash atm.
Writing a unit test to test the crash would be a significant amount of work and would only be of any use when run with the broken versions of GTK, which we don't have on our test platforms.
This patch is a workaround for a bug in a workaround in GTK for a Java bug.
I've suggested that the incorrect workaround in GTK be removed, but there hasn't been any progress on that.
(From update of attachment 380384)
Requesting approval 1.9.2 for these null checks that fix the most-reported Thunderbird crash on Linux. The patch only affect code paths in situations for which we'd crash atm.
Writing a unit test to test the crash would be a significant amount of work and would only be of any use when run with the broken versions of GTK, which we don't have on our test platforms.
This patch is a workaround for a bug in a workaround in GTK for a Java bug.
I've suggested that the incorrect workaround in GTK be removed, but there hasn't been any progress on that.