need to set proxy for smart too

I'm pushing this back to thames as I don't want to rush this in today. We have to write
a parser for the apt.conf format, which is a bit flexible, and I won't be around in the
next week as I'll be on holiday, and thus wouldn't be able to fix any issues.

Moving to pre-5

Gustavo, the description of the ticket does not make it clear why we need to write a parser for apt.conf. It looks like this ticket is just about configuring smart to use the http proxy that is specified during landscape-config.

Setting it during landscape-config was the original suggestion yes.

Following apt's proxy configuration everytime seems superior (like we do follow sources.list), though.

I'm fine with going either way. Using the proxy configuration from landscape-config
indeed sounds reasonable, even more if we consider that we'll likely have cases in
the future where landscape could be setup in a system where APT wasn't ever used.
We'd probably have to make Smart understand Landscape's configuration file (which
shouldn't be hard), so that current wedged systems would unblock.

Btw, just for the record, Matt Z. had a nice idea the other day: we could use apt-config to
get the proxy configuration from APT without any complex parsing. Of course, if we're
using Landscape's setup, that won't matter.

Using the landscape setup seems like a nice compromise. landscape will have to have a correct proxy configuration at all times in order to work properly. If landscape-client isn't working, it doesn't matter if smart is using the right proxy or not.

Pushed for thames-pre-6.

Moved to thames-pre-7.

Pushing for thames-pre-8

Pushed for thames-pre-9

Unfortunately there's no time to add this for Intrepid, so I'll postpone this one for the next major
milestone so that I can focus on helping to push the major features of 1.2.

This just happened to a real customer. shang debugged it and indeed it was a missing proxy setting for smart. The "smart update" cronjob was always stuck at this customer.

The customer said he did configure a proxy via landscape-config, but that smart didn't get that setting.

This is ready to review in the attached branch.

Hmm, I wonder how we should deal with ftp proxies. It's not something that landscape-client uses, so it won't ask for this information, but apt/smart repositories can surely be ftp://. Should we ask that too or assume the same proxy for ftp?

Hum I don't really know what to do...

So, the suggestion is to have the wizard also ask for the ftp proxy. So, three questions:
- http proxy
- https proxy
- ftp proxy

But for the last two, assume the same answer as for the first one, to minimize typing.

On another note, while running the wizard, I get this:
(...)
Enable script execution? [y/N]y

By default, scripts are restricted to the 'landscape' and
'nobody' users. Please enter a comma-delimited list of users
that scripts will be restricted to. To allow scripts to be run
by any user, enter "ALL".

Script users: ALL
'NoneType' object has no attribute 'set'
Aborting Landscape configuration
root@hardy-vm:~#

A new landscape plugin is working in Smart's trunk. With it, we can set the use-landscape-proxies in the distro.py file of the smartpm package, and get Smart to use the proxies which were set in Landscape itself.

This is going to be fixed in smart.

A 1.2 smart release is forthcoming. We will deal with the packaging once it's released.

I extensively tested this on Mar 4th, 2009:
- interaction with env proxy vars
- interaction with smart proxy config options
- what happens when landscape-client is not installed
- upgrading smart from a broken situation (no proxy set for smart, but one set for LC) fixes it

qa + 1

This bug was fixed in the package smart - 1.2-0ubuntu0.9.04

---------------
smart (1.2-0ubuntu0.9.04) jaunty; urgency=low

  * New upstream release (LP: #349866)
    - Added timeout for smart connections (LP: #268261)
    - New landscape plugin to set proxy for smart too,
      inheriting it from the landscape config (LP: #236884)
    - Support for python 2.6 (LP: #292542)
  * Added patch to fix a fetcher test (LP: #354027)

 -- Andreas Hasenack <email address hidden> Tue, 31 Mar 2009 11:07:00 -0300

This wa released in upstream 1.2

This was released in upstream 1.2

Decoupling server bugs from client ones.

Accepted smart into intrepid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

This bug was fixed in the package smart - 1.1.1~bzr20081010-0ubuntu1.8.10.0

---------------
smart (1.1.1~bzr20081010-0ubuntu1.8.10.0) intrepid-proposed; urgency=low

  * Bug-fixing SRU (LP: #347983)
    - Added timeout for smart connections (LP: #268261)
    - New landscape plugin to set proxy for smart too,
      inheriting it from the landscape config (LP: #236884)
    - Added 04_detect_plugins crasher fix (LP: #388577)
    - Added 05_curl_timeout fix for failures when downloading big
      packages (LP: #389001)

 -- Free Ekanayaka <email address hidden> Wed, 07 Oct 2009 09:16:59 +0200

Intrepid Ibex reached end-of-life on 30 April 2010 so I am closing the
report. The bug is still marked as having a fix committed in later versions of Ubuntu.