Fetcher test fails in jaunty

Bug #354027 reported by Andreas Hasenack
2
Affects Status Importance Assigned to Milestone
Smart Package Manager
Fix Released
Undecided
Unassigned
smart (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[tests/fetcher.py]
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python2.6/threading.py", line 522, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.6/threading.py", line 477, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/home/andreas/smart/smart-1.2/tests/fetcher.py", line 67, in server
    httpd.handle_request()
  File "/usr/lib/python2.6/SocketServer.py", line 266, in handle_request
    self._handle_request_noblock()
  File "/usr/lib/python2.6/SocketServer.py", line 283, in _handle_request_noblock
    self.handle_error(request, client_address)
  File "/home/andreas/smart/smart-1.2/tests/fetcher.py", line 28, in handle_error
    super(HTTPServer, self).handle_error(request, client_address)
TypeError: super() argument 1 must be type, not classobj

This patch from Niemeyer fixes it:
- super(HTTPServer, self).handle_error(request, client_address)
+ HTTPServer.handle_error(self, request, client_address)

Tags: ubuntu
tags: added: ubuntu
Revision history for this message
Anders F Björklund (afb) wrote :

This patch does not look right to me...
RuntimeError: maximum recursion depth exceeded while calling a Python object

It should be using "BaseHTTPServer.HTTPServer" for the super class, I think.
Or inherit the HTTPServer from object too ?

Changed in smart (Ubuntu):
status: New → Fix Released
Revision history for this message
Anders F Björklund (afb) wrote :

See #349866

Revision history for this message
Anders F Björklund (afb) wrote :

Bug ##349866

Revision history for this message
Anders F Björklund (afb) wrote :

Bug #349866

Sigh. Edit ?

Changed in smart:
milestone: none → 1.3.1
Changed in smart:
status: New → Fix Committed
Changed in smart:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.