mountall messages are showed untranslated in Plymouth

Please attach your /etc/fstab

it happens on 3 different computers, do you want the 3 ones ?

Here is the one of the computer I'm on now

reopening to "new", infos needed provided.

Thanks, I wondered whether you had /usr on a separate partition - it appears that you do not.

No idea why this isn't working, then

Another fstab, from another of my computers. Can I help you find where the problem is, Scott ?

On Mon, 2010-04-26 at 20:38 +0000, Nicolas DERIVE wrote:

> Another fstab, from another of my computers. Can I help you find where
> the problem is, Scott ?
>
Well, I don't really know much about how translations or gettext work;
so if you can find out, and then debug to find out why gettext isn't
loading the translations, that'd be great.

I'll happily apply any patch that fixes it.

Scott
--
Scott James Remnant
<email address hidden>

Hi,

After debugging this a bit, I came to the conclusion that locale isn't yet set when mountall is called. Thus mountall runs with LANG=C and doesn't display translated messages.

The attached patch to /etc/init/mount/mountall.conf fixes the problem here. I've taken a few lines from /etc/init/kdm.conf that source the appropriate files and then export LANG and LANGUAGE.
It may not be the best solution (in which case please give us a better one :)), but it works.

Once this is fixed in maverick, I think fixing it in lucid could be worth it: it's a trivial patch but it's very important for some kind of users.

Adrien: Works great here! Huge thanks. I did look a bit at the mountall code few months ago, but was completely in the wrong place :) I just added the patch manually to /etc/init/mountall.conf on my lucid.

Since this is one of the most visible I18N bugs in lucid, and the fix is trivial (unless it needs to be done in some better way), I'd suggest this as SRU for 10.04 LTS as well. I'm happy to test any proposed packages with the fix include.

/etc/default/locale can set other relevant variables than just LANG and LANGUAGE; LC_MESSAGES for instance. Instead of

  . /etc/default/locale
  export LANG LANGUAGE

one could do

  set -a
  . /etc/default/locale
  set +a

in order to export all variables set in the file.

This seems a reasonable work-around, though in practice I think that Upstart should place the contents of /etc/default/locale into the environment of all jobs

Maverick debdiff attached (needs sponsoring). Lucid SRU to come.

Again, just LANG and LANGUAGE aren’t enough. Please see my previous comment. Thanks.

Johan: as said, this is a workaround, which works. kdm does the same thing.
The real fix in upstart will probably export more environment variables, as appropriate.

I think the less changes we make here for the SRU, the better.

Works, except for, say, the LANG=en_US.UTF-8, LC_MESSAGES=fi_FI.UTF-8 case. :-)

“set -a; . /foo/bar; set +a” isn’t that much bigger a change than “. /foo/bar; export FOO BAR”.

Sorry, I meant the LANG=fi_FI.UTF-8, LC_MESSAGES=en_US.UTF-8 case.

SRU ack, please upload. But please fix in maverick first, so that this gets more testing and isn't forgotten about.

Indeed there are more LC_* variables, but the only on we are interested in here is LC_MESSAGES. So if we export LC_MESSAGES, LANG, and LANGUAGES, we should be good.

Updated debdiffs with LC_MESSAGES exported coming, ready for upload.

This bug was fixed in the package mountall - 2.16

---------------
mountall (2.16) maverick; urgency=low

  * conf/mountall.conf: set $LANG so that messages appearing in plymouth are
    translated (LP: #569365); this is a temporary workaround until upstart is
    fixed to pass the appropriate env vars to all init scripts
 -- Adrien Cunin <email address hidden> Tue, 24 Aug 2010 20:47:33 +0200

SRU ack for comment 23, thank you! Please upload.

Accepted mountall into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

2.15.1 works fluently here in lucid. Thanks a lot!

This is ok as a partial fix, but note that:

 - LC_ALL is missing from the list of variables
 - use of /etc/environment for locale settings is long obsolete and we shouldn't be adding support for this to new packages.

I've addressed both of these issues in the mountall bzr branch; I don't think it's worth respinning the SRU for either issue.

Perfect in Lucid

This bug was fixed in the package mountall - 2.15.1

---------------
mountall (2.15.1) lucid-proposed; urgency=low

  * conf/mountall.conf: set $LANG so that messages appearing in plymouth are
    translated (LP: #569365); this is a temporary workaround until upstart is
    fixed to pass the appropriate env vars to all init scripts
 -- Adrien Cunin <email address hidden> Tue, 24 Aug 2010 20:47:33 +0200