clamav 0.95(.1) build fails with fakeroot on Intrepid due to race condition

Already fixed in Jaunty

This is eventually likely to interfere with security updates on Intrepid, so we need to consider how to deal with it in -security too.

Patched fakeroot 1.9.5 source package from Intrepid with the one-liner from

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=499142

installed the package in an Intrepid pbuilder environment, and succesfully built clamav 0.95.1, which previously failed to build. It didn't hang this time, all the tests completed error-free.

One-liner tested on Hardy's fakeroot-1.9, it works.

wontfix Gutsy due to near eol.

fakeroot (1.9.5ubuntu2) intrepid; urgency=low

  * fixed deadlock problem when using threads (LP: #360122)
    - fixed with patch from fakeroot 1.11 (#499142)

 -- Imre Gergely <email address hidden> Mon, 13 Apr 2009 17:05:29 +0300

TEST CASE:
Download clamav 0.95.1 source package from Jaunty, try building a package with pbuilder for Intrepid (which uses fakeroot 1.9.5). After compiling it moves on to do some stress testing of clamav, clamscan, clamd. At clamd it does all the tests, gives one error and hangs forever. Look for this output:

Running suite(s): clamd
98%: Checks: 77, Failures: 0, Errors: 1
check_clamd.c:205:E:clamd stress test:test_connections:0: (after this point) Test timeout expired

***
*** Failed clamd protocol test!
***

After this it just hangs and does not do anything. Look at the process list, there should be a clamd/clamdscan process, run a strace -p <pid>, it should be stuck at semop(...). The build process must be aborted with Ctrl+C.

fakeroot (1.9.5ubuntu1.1) intrepid-proposed; urgency=low

  * fixed deadlock problem when using threads (LP: #360122)
    - fixed with patch from fakeroot 1.11 (#499142)

 -- Imre Gergely <email address hidden> Mon, 13 Apr 2009 17:27:33 +0300

fakeroot (1.9ubuntu1.1) hardy-proposed; urgency=low

  * fixed deadlock problem when using threads (LP: #360122)
    - fixed with patch from fakeroot 1.11 (#499142)

 -- Imre Gergely <email address hidden> Mon, 13 Apr 2009 17:55:23 +0300

fakeroot (1.5.6ubuntu2.1) dapper-proposed; urgency=low

  * fixed deadlock problem when using threads (LP: #360122)
    - fixed with patch from fakeroot 1.11 (#499142)

 -- Imre Gergely <email address hidden> Mon, 13 Apr 2009 18:01:56 +0300

Uploaded for Intrepid. Waiting for Ubuntu SRU to accept it for testing.

Accepted into intrepid-proposed; please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Hardy uploaded. Waiting for it to get accepted.

Uploaded for Dapper. Waiting for it to be accepted.

In order to test this fix I uploaded a version of clamav the runs its test suite to the ubuntu-clamav PPA. As expected, it FTBFS on all archs. I've left it un-retried on lpia for the full log: https://launchpad.net/~ubuntu-clamav/+archive/ppa/+build/949389

The error was:

Running suite(s): clamd
94%: Checks: 77, Failures: 0, Errors: 4
check_clamd.c:398:E:clamd stress test:test_fildes_many:0: (after this point) Test timeout expired
check_clamd.c:205:E:clamd stress test:test_idsession_stress:0: (after this point) Test timeout expired
check_clamd.c:205:E:clamd stress test:test_fildes_unwanted:0: (after this point) Test timeout expired
check_clamd.c:68:E:clamd stress test:test_connections:0: (after this point) Test timeout expired

***
*** Failed clamd protocol test!
***

Session terminated, killing shell...make[1]: *** wait: No child processes. Stop.
make[1]: *** Waiting for unfinished jobs....
make[1]: *** wait: No child processes. Stop.
make: *** wait: No child processes. Stop.
make: *** Waiting for unfinished jobs....
make: *** wait: No child processes. Stop.
make[3]: *** [check-TESTS] Terminated
make[2]: *** [check-am] Terminated
 ...killed.
Build killed with signal 15 after 150 minutes of inactivity
******************************************************************************
Build finished at 20090415-1916
FAILED [dpkg-buildpackage died]

Then I added -proposed to the PPA and retried. Now the build succeeds:

https://launchpad.net/~ubuntu-clamav/+archive/ppa/+build/949388

This bug was fixed in the package fakeroot - 1.9.5ubuntu1.1

---------------
fakeroot (1.9.5ubuntu1.1) intrepid-proposed; urgency=low

  * fixed deadlock problem when using threads (LP: #360122)
    - fixed with patch from fakeroot 1.11 (#499142)

 -- Imre Gergely <email address hidden> Mon, 13 Apr 2009 17:27:33 +0300

Resetting v-done tag for dapper/hardy

Accepted into hardy-proposed; please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Accepted into dapper-proposed; please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

For testing fakeroot from -proposed in Hardy, I followed the same procedure as Scott above. I've uploaded clamav to the PPA with tests enabled, it failed to build on archs. Here's the failed lpia build:

https://launchpad.net/~ubuntu-clamav/+archive/ppa/+build/955819

The relevant snip if the build log disappears:

Running suite(s): clamd
94%: Checks: 77, Failures: 0, Errors: 4
check_clamd.c:398:E:clamd stress test:test_fildes_many:0: (after this point) Test timeout expired
check_clamd.c:205:E:clamd stress test:test_idsession_stress:0: (after this point) Test timeout expired
check_clamd.c:205:E:clamd stress test:test_fildes_unwanted:0: (after this point) Test timeout expired
check_clamd.c:68:E:clamd stress test:test_connections:0: (after this point) Test timeout expired

***
*** Failed clamd protocol test!
***

Session terminated, killing shell...make[1]: *** [check-recursive] Terminated
make: *** [check] Terminated
make[3]: *** [check-TESTS] Terminated
make[2]: *** [check-am] Terminated
 ...killed.
Build killed with signal 15 after 150 minutes of inactivity
******************************************************************************
Build finished at 20090421-1220
FAILED [dpkg-buildpackage died]
Purging chroot-autobuild/build/buildd/clamav-0.95.1+dfsg

After this I added -proposed to the PPA dependecies (with the new fakeroot in it) and did a retry on the i386 build. As expected, it built without problems:

https://launchpad.net/~ubuntu-clamav/+archive/ppa/+build/955818

I couldn't test it with the above method on Dapper, because on Dapper the stress tests which would block fakeroot don't get run because of old versions. From the build log:

*** Check version too old, clamd tests not run!

So by not running these tests at build time, the build is just fine, there is no error.

For testing's sake I added -proposed and rebuilt the package with the new fakeroot, and it did build, although this doesn't prove anything, just that it didn't break the build.

Here's a build without -proposed (without the new fakeroot):

https://launchpad.net/~ubuntu-clamav/+archive/ppa/+build/955821

And the build with -proposed enabled (with the new fakeroot):

https://launchpad.net/~ubuntu-clamav/+archive/ppa/+build/956212

I still think it would be a good idea to SRU this to Dapper, too. Would there be any problem to SRU this without further testing?

Updated the 'check' package for Dapper in the PPA, and rebuilt the clamav package. Now it did run all the tests necessary and it didn't fail. Buildlog:

https://launchpad.net/~ubuntu-clamav/+archive/ppa/+build/956763

And the relevant part:

Running suite(s): clamd
100%: Checks: 77, Failures: 0, Errors: 0

This would mean the fakeroot package is OK on Dapper, too.

Thanks for testing! I consider hardy verified.

If we don't need the fakeroot SRU for dapper, then let's not do it. No need to potentially break builds for that LTS.

I removed the dapper SRU from -proposed again.

We don't need the new fakeroot in Dapper to build this package (clamav), but it does fail to build when stress tests are run.

Here's a build that failed on Dapper without the new fakeroot (and with added new 'check' package for the tests to run):

https://launchpad.net/~ubuntu-clamav/+archive/ppa/+build/956778

It's not a show stopper for clamav backporting, but you may want to consider the SRU if/when somebody else runs into this problem (if ever) with another package.

Thanks.

This bug was fixed in the package fakeroot - 1.9ubuntu1.1

---------------
fakeroot (1.9ubuntu1.1) hardy-proposed; urgency=low

  * fixed deadlock problem when using threads (LP: #360122)
    - fixed with patch from fakeroot 1.11 (#499142)

 -- Imre Gergely <email address hidden> Mon, 13 Apr 2009 17:55:23 +0300