Unity

unity-window-decorator doesn't draw "unfocused state" of title bar

Bug #704413 reported by Didier Roche-Tolomelli on 2011-01-18

This bug affects 3 people

	Status	Importance	Assigned to	Milestone
Mago	Fix Released	Undecided	Jean-Baptiste Lallement
Unity	Fix Released	Low	Sam Spilsbury	Unity 3.4 "alpha-2"
compiz (Ubuntu)	Fix Released	Low	Unassigned
unity (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

1. open a first application (not maximized and which shouldn't be maximized)
-> title bar draw the close/minimize/maximize buttons with color (as the window is focused)
2. open another application
-> title bar of the new application is drawn with colored close/minimize/maximize button (as the window is focused), BUT, most of the time, the previous application (which is then unfocused), still have colored buttons.

Related branches

lp:~compiz/compiz/ubuntu

lp:ubuntu/natty/compiz

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2011-01-18:

two-focused-window.png Edit (31.3 KiB, image/png)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2011-01-18:

confirming the issue on current natty

Changed in compiz (Ubuntu):
importance:	Undecided → Low
status:	New → Confirmed

Revision history for this message

David Barth (dbarth) wrote on 2011-01-20:

Theming issue, so most probably in the code of the decorator itself.

Cimi: can you take a look at this one?

Changed in unity:
assignee:	nobody → Andrea Cimitan (cimi)
importance:	Undecided → Low
milestone:	none → 3.4

Neil J. Patel (njpatel) on 2011-01-21

Changed in unity:
milestone:	3.4 → 3.6
status:	New → Confirmed

Revision history for this message

Andrea Cimitan (cimi) wrote on 2011-01-21:

ok david, next week sounds better

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2011-01-21:

adding a mago task for regression testing.

Changed in compiz (Ubuntu):
assignee:	nobody → Jean-Baptiste Lallement (jibel)

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2011-01-21:

sorry for the noise, I assigned the wrong task to myself and won't be of any help to fix compiz

Changed in compiz (Ubuntu):
assignee:	Jean-Baptiste Lallement (jibel) → nobody
Changed in mago:
assignee:	nobody → Jean-Baptiste Lallement (jibel)
status:	New → In Progress

Andrea Cimitan (cimi) on 2011-01-21

Changed in unity:
assignee:	Andrea Cimitan (cimi) → Sam "SmSpillaz" Spilsbury (smspillaz)

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2011-01-21: Re: [Bug 704413] [NEW] unity-window-decorator doesn't draw "unfocused state" of title bar

On Fri, Jan 21, 2011 at 6:57 PM, Launchpad Bug Tracker
<email address hidden> wrote:

> 2. open another application
> -> title bar of the new application is drawn with colored close/minimize/maximize button (as the window is focused), BUT, most of the time, the previous application (which is then unfocused), still have colored buttons.

So this here is actually a bug in the composite extensions of X
(damage race condition) and it is fixed in the newest X Server.
Although to avoid this happening we should add support for sync fences
where available.

>
> ** Affects: mago
> Importance: Undecided
> Assignee: Jean-Baptiste Lallement (jibel)
> Status: In Progress
>
> ** Affects: unity
> Importance: Low
> Assignee: Sam "SmSpillaz" Spilsbury (smspillaz)
> Status: Confirmed
>
> ** Affects: compiz (Ubuntu)
> Importance: Low
> Status: Confirmed
>
> --
> unity-window-decorator doesn't draw "unfocused state" of title bar
> https://bugs.launchpad.net/bugs/704413
> You received this bug notification because you are a bug assignee.
>

--
Sam Spilsbury

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2011-01-21:

Regression test pushed up to pushed up to revision 19 of mago-testsuite.

Changed in mago:
status:	In Progress → Fix Committed
status:	Fix Committed → Fix Released

Sam Spilsbury (smspillaz) on 2011-01-28

Changed in unity:
status:	Confirmed → In Progress

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2011-01-30:

Ok, so this isn't the XDamage bug that I thought it was. It seemed like we were implicitly redrawing the decoration when the pixmap size changes (obviously) which explains why I was not seeing this with differentiated shadows compared to no differentiated shadows with the default themes. Fix committed.

Changed in unity:
status:	In Progress → Fix Released
status:	Fix Released → Fix Committed
Changed in compiz (Ubuntu):
status:	Confirmed → Fix Committed

Didier Roche-Tolomelli (didrocks) on 2011-01-31

Changed in unity:
milestone:	3.6 → 3.4

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2011-01-31:

#10

ok, trickier to get it for sam as there are some side effects, resetting it for 3.6 then, sorry for the noise.

Changed in unity:
milestone:	3.4 → 3.6

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-01-31:

#11

This bug was fixed in the package compiz - 1:0.9.2.1+glibmainloop4-0ubuntu8

---------------
compiz (1:0.9.2.1+glibmainloop4-0ubuntu8) natty; urgency=low

  * debian/patches/14_fix_empathy_list_vanish.patch:
    - fix the buddy list disappearing (LP: #682781)
  * debian/patchs/15_hidden_maximized_decoration.patch:
    - fix sometimes invisible decoration on maximized window still decorated
  * 16_display_unfocused_state.patch:
    - fix unfocused state not being displayed properly in the decoration
      (LP: #704413)
-- Didier Roche <email address hidden> Mon, 31 Jan 2011 15:50:17 +0100