Please merge faad2 2.7-6 (universe) from Debian unstable (main)

Bug #680474 reported by Angel Abad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
faad2 (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Please merge new Debian revision:

 faad2 (2.7-6) unstable; urgency=high
 .
   [ Alessio Treglia ]
   * Fix segmentation fault in faad due to an incorrect pointer size
     (Closes: #603807, LP: #665802).
   * Add gbp config file.
 .
   [ Andres Mejia ]
   * Revert changes in 2.7-5. Upload of 2.7-5 was unintentionally done.
   * Refresh patches.

Thanks!

Related branches

Revision history for this message
Angel Abad (angelabad) wrote :
Changed in faad2 (Ubuntu):
assignee: nobody → Angel Abad (angelabad)
status: New → In Progress
Revision history for this message
Angel Abad (angelabad) wrote :
Changed in faad2 (Ubuntu):
status: In Progress → Confirmed
assignee: Angel Abad (angelabad) → nobody
Revision history for this message
Alessio Treglia (quadrispro) wrote :

Is this chunk needed? I see an #if defined (_WIN32) who makes me suppose that it is unnecessary.

+@@ -315,7 +315,7 @@
+
+ #if defined(_WIN32) && !defined(__MINGW32__)
+ #define HAS_LRINTF
+- static INLINE int lrintf(float f)
++ static INLINE int _lrintf(float f)
+ {
+ int i;
+ __asm

Revision history for this message
Angel Abad (angelabad) wrote :

Really this chunk is not necessary, Do you think the best option is to
remove it?

Thanks!

Revision history for this message
Alessio Treglia (quadrispro) wrote :

If the package builds fine without that chuck, please remove it.
I'll push this change into the git branch, too.

Revision history for this message
Lorenzo De Liso (blackz) wrote :

The package builds fine without that chunk so remove it from the patch.

Revision history for this message
Bhavani Shankar (bhavi) wrote :

Hello lorenzo and alessio,

yes sorry for the oversight caused

regards

Changed in faad2 (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Bhavani Shankar (bhavi) wrote :

Sponsoring this

regards

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package faad2 - 2.7-6ubuntu1

---------------
faad2 (2.7-6ubuntu1) natty; urgency=low

  [ Angel Abad <email address hidden> ]
  * Merge from debian unstable (LP: #680474). Remaining changes:
    - debian/patches/fix_ftbfs_with_gcc4.5.patch
      + Correctly declare lrintf in libfaad/common.h to avoid a conflict of
        declaration in mathcalls.h to fix FTBFS on i386

  [ Bhavani Shankar <email address hidden> ]
  * Remove useless chunk from the patch I created above to fix FTBFS
    which happened due to my mistake. Sigh!

faad2 (2.7-6) unstable; urgency=high

  [ Alessio Treglia ]
  * Fix segmentation fault in faad due to an incorrect pointer size
    (Closes: #603807, LP: #665802).
  * Add gbp config file.

  [ Andres Mejia ]
  * Revert changes in 2.7-5. Upload of 2.7-5 was unintentionally done.
  * Refresh patches.
 -- Angel Abad <email address hidden> Tue, 23 Nov 2010 13:48:21 +0100

Changed in faad2 (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.