Aptdaemon

Programming error during installation of downloaded software because of an invalid package size

Bug #656633 reported by Jason Wamsley
336
This bug affects 57 people
Affects Status Importance Assigned to Milestone
Aptdaemon
Fix Released
Critical
Unassigned
aptdaemon (Ubuntu)
Fix Released
Medium
mamh17
Maverick
Fix Released
Medium
Unassigned

Bug Description

TEST CASE:
1. try to install songbird http://skyzim.com/songbird-1-7-3-installer
2. verify that it fails
3. install aptdaemon from maverick-proposed
4. reboot (just to be 100% sure aptdaemon got restarted)
5. install the deb again and verify that it works

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/aptdaemon/worker.py", line 769, in simulate
    return self._simulate_helper(trans, status_path)
  File "/usr/lib/python2.6/dist-packages/aptdaemon/worker.py", line 852, in _simulate_helper
    size = int(deb["Installed-Size"]) * 1024
ValueError: invalid literal for int() with base 10: '116,940'

See original description
Sebastian Heinlein (glatzor)
summary: - Trying to install Songbird on 10.10rc
+ Some manually created packages contain thounds commas in the size and
+ break installation
Michael Vogt (mvo)
Changed in aptdaemon:
status: New → Confirmed
Changed in aptdaemon (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Michael Vogt (mvo) wrote : Re: Some manually created packages contain thounds commas in the size and break installation

A example deb would be very useful.

Changed in aptdaemon (Ubuntu Maverick):
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Michael Vogt (mvo) wrote :

Looks like http://skyzim.com/songbird-1-7-3-installer is one

description: updated
Revision history for this message
Michael Vogt (mvo) wrote :

Sebastian pointed out that here is another example:
http://sourceforge.net/projects/clutterflow/files/banshee-extension-clutterflow.deb/download

Revision history for this message
Steve Langasek (vorlon) wrote :

These packages are in violation of Debian policy:

5.6.20. `Installed-Size'
------------------------

     This field appears in the control files of binary packages, and in the
     `Packages' files. It gives an estimate of the total amount of disk
     space required to install the named package. Actual installed size
     may vary based on block size, file system properties, or actions taken
     by package maintainer scripts.

     The disk space is given as the integer value of the estimated
     installed size in bytes, divided by 1024 and rounded up.

Ubuntu policy currently has a different wording currently, but I would expect it to be in sync in the next release.

Is it really warranted to do an SRU for compatibility with non-conformant packages?

Michael Vogt (mvo)
Changed in aptdaemon (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Michael Vogt (mvo) wrote :

Hey Steve, thanks for your review. While the packages are wrong the fix is relatively cheap and dpkg itself does not complain. So I would be in favor for this fix. But if its rejected on the grounds that its the packages that are broken then I will accepted that of course.

Revision history for this message
Sebastian Heinlein (glatzor) wrote : Re: [Bug 656633] Re: Some manually created packages contain thounds commas in the size and break installation

It is also an usability issue, since we don't have got a proper
"invalid package file" error message. It just results in an exception.

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

Sebastian Heinlein (glatzor)
Changed in aptdaemon:
importance: Undecided → Critical
Revision history for this message
Steve Langasek (vorlon) wrote :

On Wed, Oct 20, 2010 at 08:21:26AM -0000, Sebastian Heinlein wrote:
> It is also an usability issue, since we don't have got a proper
> "invalid package file" error message. It just results in an exception.

Maybe we could fix that issue (no proper error message) instead?

Anyway, I don't feel strongly about this either way. I would be happier
about this as an SRU if there were more bugs fixed in the process. Do you
have any other severe bugs in aptdaemon that need fixing? :)

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>

Revision history for this message
Sebastian Heinlein (glatzor) wrote : Re: Some manually created packages contain thounds commas in the size and break installation

I added a check using lintian before installing .deb files in the trunk branch.

Revision history for this message
mallardquacken (mallard) wrote :

http://www.blackmagic-design.com/downloads/software/DeckLink_Linux_7.9.tar.gz contains DeckLink-7.9rc7-amd64.deb which is another .deb that exhibits this problem under Maverick (it installs fine in Lucid.) So does the MediaExpress package from the same .gz (MediaExpress-2.2rc19-amd64.deb).

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted aptdaemon into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in aptdaemon (Ubuntu Maverick):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Petzi (stone-goldhead) wrote : Re: Some manually created packages contain thounds commas in the size and break installation

Hi All,

I've got Bug #658204

I've installed the new version of aptdaemon and then i've got bibblepro_4.10.1-1_i386.deb installed.

Many thanks for your Work

Best regards

P.S. With launchpad i can reinstall bibblepro_4.10.1-1_i386.deb but i can't remove it, no remove button

I've installed spamassassin in between ( ?? )

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Ivanov I.I. (wuppy) wrote : Re: [Bug 656633] Re: Some manually created packages contain thounds commas in the size and break installation

I've just tested Aptdaemon from maverick-proposed.
Great! Thank you for your support. All fixed.

Revision history for this message
Launchpad Janitor (janitor) wrote : Re: Some manually created packages contain thounds commas in the size and break installation

This bug was fixed in the package aptdaemon - 0.31+bzr506-0ubuntu4

---------------
aptdaemon (0.31+bzr506-0ubuntu4) maverick-proposed; urgency=low

  * debian/patches/06_rosetta_po_update.patch:
    - updated translations from rosetta, this includes the
      policy.in files that can not be updated via language-packs
      (LP: #655642)

aptdaemon (0.31+bzr506-0ubuntu3) maverick-proposed; urgency=low

  * debian/patches/08_fix_deb_install.patch:
    - fix installing deb packages with odd/broken installed-size
      fields (LP: #656633)
 -- Michael Vogt <email address hidden> Wed, 20 Oct 2010 10:12:52 +0200

Changed in aptdaemon (Ubuntu Maverick):
status: Fix Committed → Fix Released
Sebastian Heinlein (glatzor)
summary: - Some manually created packages contain thounds commas in the size and
- break installation
+ Programming error during installation from downloaded software because
+ of an invalid package size
summary: - Programming error during installation from downloaded software because
- of an invalid package size
+ Programming error during installation of downloaded software because of
+ an invalid package size
mamh17 (mamh17-1712)
Changed in aptdaemon (Ubuntu):
assignee: nobody → mamh17 (mamh17-1712)
dragon (dragon-hell)
Changed in aptdaemon:
status: Confirmed → Fix Committed
Ubuntu Foundations Team Bug Bot (crichton)
tags: added: testcase
Revision history for this message
Ruben (info-rubenfelix) wrote : Re: [Bug 656633] Re: Programming error during installation of downloaded software because of an invalid package size

Hey!

Bedankt voor je mail! Ik ben er even tussenuit geknepen naar een lekker warm land! Ik beantwoord je mail na mijn vakantie (11 oktober).

Groetjes!

Ruben

samanx (sh4rk1zm4st3rc0der)
Changed in aptdaemon:
status: Fix Committed → In Progress
status: In Progress → Invalid
Sebastian Heinlein (glatzor)
Changed in aptdaemon:
status: Invalid → In Progress
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.