FTBFS: cairo.h:1976: error: comma at end of enumerator list

Bug #651183 reported by Michael Terry
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
cairo
Fix Released
Medium
desktop-webmail
Fix Released
Undecided
Unassigned
cairo (Ubuntu)
Fix Released
Undecided
Unassigned
desktop-webmail (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: desktop-webmail

desktop-webmail failed to build during a rebuild test: http://people.ubuntuwire.org/~lucas/ubuntu-nbs/64/desktop-webmail_002-0ubuntu1_lubuntu64.buildlog

It is because (A) it is built with -pedantic and (B) cairo.h has a comma where a pedantic gcc does not like it. I think both should be fixed.

-pedantic is great when testing and developing, but too fragile for released tarballs.

And cairo.h should not be shipping public headers with pedantic errors.

Related branches

Revision history for this message
Michael Terry (mterry) wrote :

For the record, this is also causing FTBFS in gnurobots, mssh, and sgt-puzzles.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cairo - 1.10.0-1ubuntu2

---------------
cairo (1.10.0-1ubuntu2) maverick; urgency=low

  * debian/patches/fix_trailing_comma.patch:
    Fix the "comma at end of enumerator list" error when building with strict
    flags and -Werror. (LP: #651183)
 -- Fabien Tassin <email address hidden> Wed, 22 Sep 2010 18:40:13 +0200

Changed in cairo (Ubuntu):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package desktop-webmail - 002-0ubuntu2

---------------
desktop-webmail (002-0ubuntu2) maverick; urgency=low

  * debian/patches/ftbfs-no-pedantic.patch:
    - Fix FTBFS by not building with -pedantic (LP: #651183)
 -- Michael Terry <email address hidden> Wed, 29 Sep 2010 10:51:52 -0400

Changed in desktop-webmail (Ubuntu):
status: New → Fix Released
Changed in cairo:
status: Unknown → Fix Released
Changed in cairo:
importance: Unknown → Medium
Revision history for this message
Alexander Sack (asac) wrote :

fixed in desktop-webmail upstream:

------------------------------------------------------------
revno: 35
committer: Alexander Sack <email address hidden>
branch nick: desktop-webmail
timestamp: Sat 2011-12-03 11:42:28 +0100
message:
  stop building with -pedantic to make release tarball consumption less fragile lp:651183
------------------------------------------------------------

Changed in desktop-webmail:
milestone: none → 003
status: New → Fix Committed
Revision history for this message
Alexander Sack (asac) wrote :
Changed in desktop-webmail:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.