Ubuntu
predict package

[ARMEL] FTBFS: previous definition of 'R0'

Bug #645036 reported by Niall Creech on 2010-09-22

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	predict (Ubuntu)	Fix Released	Medium	Unassigned

Bug Description

Binary package hint: predict

Fails to build on armel due to conflict with system definition of R0

earthtrack.c:52: error: 'R0' redeclared as different kind of symbol
//usr/include/sys/ucontext.h:43: note: previous definition of 'R0' was here

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: predict (not installed)
ProcVersionSignature: Ubuntu 2.6.35-22.33-generic 2.6.35.4
Uname: Linux 2.6.35-22-generic i686
Architecture: i386
Date: Wed Sep 22 10:19:30 2010
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release i386 (20091028.5)
ProcEnviron:
LANG=en_GB.utf8
SHELL=/bin/bash
SourcePackage: predict

Tags:

Related branches

lp:ubuntu/maverick/predict

lp:ubuntu/quantal/predict

Revision history for this message

Niall Creech (sevenmachines-deactivatedaccount) wrote on 2010-09-22:

fix-R0-conflict Edit (1.1 KiB, text/plain)

Change variable name to avoid conflict

Changed in predict (Ubuntu):
assignee:	nobody → SevenMachines (sevenmachines)

Revision history for this message

Niall Creech (sevenmachines-deactivatedaccount) wrote on 2010-09-22:

Waiting for armel test build

predict (2.2.3-3ubuntu1) maverick; urgency=low

  * debian/patches/fix-R0-conflict:
    - Some systems define an enumeration containing R0 in
    sys/ucontext.h. Changing the name avoids any conflict.(LP: #645036)

Revision history for this message

Niall Creech (sevenmachines-deactivatedaccount) wrote on 2010-09-22:

predict_2.2.3-3ubuntu1.debdiff Edit (6.3 KiB, text/plain)

More R0 replacements

tags:

added: patch

Niall Creech (sevenmachines-deactivatedaccount) on 2010-09-22

Changed in predict (Ubuntu):
assignee:	SevenMachines (sevenmachines) → nobody

Revision history for this message

Artur Rona (ari-tczew) wrote on 2010-09-22:

Thanks for your work SevenMachines, but I have some tips to your debdiff.
* debian/patches/fix-R0-conflict:
- There are no filetype extension. Package uses .diff for previous patches, so you should use .diff as well.
- You should add Origin tag with http adress to point an original patch, following with http://dep.debian.net/deps/dep3/.

* debian/changelog:
- Why do you make debdiff for someone else? Debdiff is done by you and only patch (I guess) is made by Niall, about which you wrote in patch using Author tag.

Also, I would see the buildlog from build on armel. Please fix debdiff, attach a buildlog and resubscribe ubuntu-sponsors (not ubuntu-security-sponsors).

Changed in predict (Ubuntu):
importance:	Undecided → Medium
status:	New → Incomplete

Revision history for this message

Niall Creech (sevenmachines-deactivatedaccount) wrote on 2010-09-22:

Hi Artur. It was mentioned that it was preferred that i use my real name to sign debdiffs, i dont do them for anyone else. Patch and debdiff are mine and signed with my real name and key as requested.

Since I'm the author i left out origin as per dep-3 "If the Author field is present, the Origin field can be omitted and it’s assumed that the patch comes from its author."

I'l see about the build log on armel in the next few days if i can get the armel pbuild working properly again

Revision history for this message

Niall Creech (sevenmachines-deactivatedaccount) wrote on 2010-09-23:

pbuilder-armel-predict.log Edit (115.7 KiB, text/plain)

Attached is pbuilder build log, note that this is for lucid and not maverick, maverick pbuilder is broken here so if necessary someone would need to check on maverick armel

Revision history for this message

Niall Creech (sevenmachines-deactivatedaccount) wrote on 2010-09-23:

predict_2.2.3-3ubuntu1.debdiff Edit (6.3 KiB, text/plain)

predict (2.2.3-3ubuntu1) maverick; urgency=low

* debian/patches/fix-R0-conflict:
- Some systems define an enumeration containing R0 in
sys/ucontext.h. Changing the name avoids any conflict.(LP: #645036)

Changed in predict (Ubuntu):
status:	Incomplete → Confirmed

Revision history for this message

Artur Rona (ari-tczew) wrote on 2010-09-23:

I made a small pedantic change in debian/changelog:
s/* debian/patches/fix-R0-conflict:/* debian/patches/fix-R0-conflict.diff:

Thanks for your contribution!

Changed in predict (Ubuntu):
status:	Confirmed → Fix Committed

Revision history for this message

Niall Creech (sevenmachines-deactivatedaccount) wrote on 2010-09-23:

Doh! I thought i'd done that! Thanks Artur

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-09-23:

#10

This bug was fixed in the package predict - 2.2.3-3ubuntu1

---------------
predict (2.2.3-3ubuntu1) maverick; urgency=low

  * debian/patches/fix-R0-conflict.diff:
    - Some systems define an enumeration containing R0 in
      sys/ucontext.h. Changing the name avoids any conflict.(LP: #645036)
-- Niall Creech <email address hidden> Wed, 22 Sep 2010 10:28:53 +0100