Show a spinner/loading indicator whil T&C webpage loads

Bug #620456 reported by Natalia Bidart
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Single Sign On Client
Fix Released
Low
Ubuntu One Client Engineering team
ubuntu-sso-client (Ubuntu)
Fix Released
Low
Natalia Bidart

Bug Description

When the user clicks on "Terms & Conditions", a webkit browser is shown and a given url is loaded. But until the url is loaded, there is no indication of what's going on.

Related branches

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

I think we can show a spinner and hook a callback to webkit, and when the page is loaded, remove the spinner and show the browser.

For webkit signals:

http://webkitgtk.org/reference/webkitgtk-webkitwebview.html#webkitgtk-webkitwebview.signals

Changed in ubuntu-sso-client:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+)
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

See "load-finished" signal.

Changed in ubuntu-sso-client:
importance: Medium → Low
tags: added: u1-natty
tags: added: desktop+
Changed in ubuntu-sso-client:
status: Confirmed → Triaged
tags: added: sso-gui
Changed in ubuntu-sso-client (Ubuntu):
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Naty Bidart (nataliabidart)
dobey (dobey)
Changed in ubuntu-sso-client:
status: Triaged → Fix Committed
Changed in ubuntu-sso-client (Ubuntu):
status: Triaged → Fix Committed
Changed in ubuntu-sso-client (Ubuntu):
status: Fix Committed → Triaged
milestone: none → natty-alpha-1
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-sso-client - 1.1.1-0ubuntu1

---------------
ubuntu-sso-client (1.1.1-0ubuntu1) natty; urgency=low

  * New upstream release (1.1.1):

    [ Alejandro J. Cura <email address hidden> ]
      * Call the dbus mainloop thread init (fixes LP: #656545).

    [ Natalia B. Bidart <email address hidden> ]
      * Added the new dbus iface to the executable. Deprecated a few Dbus
      constants.

    [ Natalia B. Bidart <email address hidden> ]
      * Adding a new DBus iface to manage credentials with flexible API (LP:
      #653113).

    [ Natalia B. Bidart <email address hidden> ]
      * Replace twisted gtk reactor with the standard gtk mainloop. (LP:
      #655327).

    [ Natalia B. Bidart <email address hidden> ]
      * The TC browser will not be shown until the TOS page has been loaded. A
      spinner is shown in the mean time (LP: #620456).
      * The TC browser does not allow link navigation other than the TOS page
      (LP: #616961).

    [ Natalia B. Bidart <email address hidden> ]
      * Terms and conditions label is now translatable. Added a button to be
      able to browse the TC (LP: 654534).

    [ Natalia B. Bidart <email address hidden> ]
      * Moved logic from DBus SSOCredentials module into a self-contained, DBus
      agnostic module called 'credentials' (LP: #653113).

    [ Natalia B. Bidart <email address hidden> ]
      * Isolating SSO login processor into a separated module (LP: #637204).

    [ Natalia B. Bidart <email address hidden> ]
      * Cleanup code and modules to prepare the code for the DBus API refactor.

    [ Natalia B. Bidart <email address hidden> ]
      * Made entries name to be unicode to avoid a faulty capitalization when
      using turkish locale (LP: #652939).

    [ Natalia B. Bidart <email address hidden> ]
      * Workaround for LP: #467397 (when using turkish locale, decimal module
      import fails).

    [ Natalia B. Bidart <email address hidden> ]
      * Added encoding declaration on every file. Fixed error passing from GUI
      in GTK signals (LP: #652318).

    [ Natalia B. Bidart <email address hidden> ]
      * Avoiding calling a callback twice for buttons (LP: #652248).

    [ Natalia B. Bidart <email address hidden> ]
      * Removed unneeded assert sentences and replaced with warning logging
      when necessary (LP: #649317).

  * New upstream release (1.1.0):

    [ Natalia B. Bidart <email address hidden> ]
      * Avoiding having the main window freezing when pinging the U1 server
      (LP: #645162).

    [ Natalia B. Bidart <email address hidden> ]
      * Do not create the login keyring, use default instead (LP: #639690).

    [ Natalia B. Bidart <email address hidden> ]
      * Avoid duplicating logging messages for module "main" (LP: #638981).

    [ Natalia B. Bidart <email address hidden> ]
      * Delay import of webkit to be able to build on non-graphical envs (LP:
      #628956).
 -- Natalia Bidart (nessita) <email address hidden> Mon, 11 Oct 2010 10:22:28 -0300

Changed in ubuntu-sso-client (Ubuntu):
status: Triaged → Fix Released
Changed in ubuntu-sso-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.