Ubuntu
xfce4-notifyd package

xfce4-notify doesn't support notification specs 1.1

Bug #606994 reported by Lionel Le Folgoc on 2010-07-18

This bug affects 6 people

	Status	Importance	Assigned to
xfce4-notifyd (Debian)	Fix Released	Unknown	debbugs #588272
xfce4-notifyd (Ubuntu)	Fix Released	Medium	Lionel Le Folgoc
Lucid	Fix Released	Medium	Lionel Le Folgoc
Maverick	Fix Released	Medium	Lionel Le Folgoc

Bug Description

Binary package hint: xfce4-notifyd

TEST CASE:
$ python /usr/share/doc/python-notify/examples/test-basic.py

It should fail (lucid):
libnotify-Message: GetServerInformation call failed: Too few arguments in reply
libnotify-Message: Error getting spec version

** (test-basic.py:1520): CRITICAL **: dbus_g_proxy_connect_signal: assertion `DBUS_IS_G_PROXY (proxy)' failed

** (test-basic.py:1520): CRITICAL **: dbus_g_proxy_call: assertion `DBUS_IS_G_PROXY (proxy)' failed

With the patch, or on maverick, it should display a bubble containing "Summary" "This is some sample content".

You can also check that the server returns correct info:
$ python /usr/share/doc/python-notify/examples/test-server-info.py
Name: Xfce Notify Daemon
Vendor: Xfce
Version: 0.1.0
Spec Version: 1.0
Capabilities:
actions
body
body-markup
body-hyperlinks
icon-static

See original description

Tags:

Related branches

lp:ubuntu/lucid-proposed/xfce4-notifyd

Revision history for this message

Lionel Le Folgoc (mrpouit) wrote on 2010-07-18:

It should be fixed in maverick since 0.1.0-5fakesync1. The new patch "02_add-spec-version-to-GetServerInformation.patch" needs to be SRU'd to lucid to fix that.

Changed in xfce4-notifyd (Ubuntu Maverick):
assignee:	nobody → Lionel Le Folgoc (mrpouit)
importance:	Undecided → Medium
status:	New → Fix Released
Changed in xfce4-notifyd (Ubuntu Lucid):
assignee:	nobody → Lionel Le Folgoc (mrpouit)
importance:	Undecided → Medium
status:	New → In Progress

Bug Watch Updater (bug-watch-updater) on 2010-07-18

Changed in xfce4-notifyd (Debian):
status:	Unknown → Fix Released

Revision history for this message

Lionel Le Folgoc (mrpouit) wrote on 2010-07-19:

I slightly changed the original patch (applied in maverick) to include the diff from a generated file, to avoid running ./configure with --enable-maintainer-mode (as it is done in maverick).

Revision history for this message

Jonathan Riddell (jr) wrote on 2010-07-20:

SRU needs a test case and patch attached to this bug (also approval from ubuntu-sru).

Revision history for this message

Lionel Le Folgoc (mrpouit) wrote on 2010-07-20:

> SRU needs a test case

The /usr/share/doc/python-notify/examples/test-basic.py part of the bug description looks like a straightforward test case to me. If it's because the magic "TEST CASE:" token is missing, I can add it.

> and patch attached to this bug

Right, I forgot, I'll upload it in a few hours. Thanks.

> (also approval from ubuntu-sru).

Mmh, sorry, no, I'm supposed to upload *before* the approval, see https://lists.ubuntu.com/archives/ubuntu-devel/2010-July/030999.html

Revision history for this message

Charlie Kravetz (cjkgeek) wrote on 2010-07-20:

I think bug #497729 is a duplicate of this bug and will be fixed by it in Lucid.

Revision history for this message

Lionel Le Folgoc (mrpouit) wrote on 2010-07-20:

02_add-spec-version-to-GetServerInformation.patch Edit (15.7 KiB, text/plain)

Lionel Le Folgoc (mrpouit) on 2010-07-20

description:

updated

Revision history for this message

Martin Pitt (pitti) wrote on 2010-07-27: Please test proposed package

Accepted xfce4-notifyd into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in xfce4-notifyd (Ubuntu Lucid):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Revision history for this message

Sébastien Launay (sebastien-launay) wrote on 2010-07-28:

Installing proposed package and restarting the Xfce session fixes the issue on my Lucid, thanks.

Martin Pitt (pitti) on 2010-07-28

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-08-02:

This bug was fixed in the package xfce4-notifyd - 0.1.0-4ubuntu1.1

---------------
xfce4-notifyd (0.1.0-4ubuntu1.1) lucid-proposed; urgency=low

  * debian/patches:
    - 02_add-spec-version-to-GetServerInformation added, returns spec version
      information so we're conform to 1.0. lp: #606994
    - series: refreshed.
-- Lionel Le Folgoc <email address hidden> Sun, 18 Jul 2010 23:17:10 +0200