Ubuntu
xorg package

Failsafe X displays variable name instead of file name for debugging tarball

Bug #596819 reported by Geir Ove Myhr
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xorg (Ubuntu)
Fix Released
Low
Bryce Harrington

Bug Description

Binary package hint: xorg

As reported in https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/589940/comments/3 , when failsafe X is triggered by using the nomodeset kernel option on intel hardware (which leads to an expected failure on Maverick), the failsafe X dialog displays:

Relevant configuration and log files have been saved to:
  $xorg_backup_file

In this particular case the expected behaviour is that $xorg_backup_file should have been expanded to /var/log/failsafeX-backup-100619201009.tar.

See original description

Related branches

lp:ubuntu/natty/xorg
Bryce Harrington (bryce)
Changed in xorg (Ubuntu):
status: New → Confirmed
Revision history for this message
Geir Ove Myhr (gomyhr) wrote :

I can now confirm this myself. I have installed a Maverick partition and got a "no screens" when booting with an external monitor attached and X in low-graphics mode. Thanks to Glen for already finding out where the failsafeX-backup-....tar went.

description: updated
Revision history for this message
Geir Ove Myhr (gomyhr) wrote :

The problem is in line 177 of debian/local/Failsafe/failsafeXinit. There is an \ before the $ in $xorg_backup_file which shouldn't be there. Since there is an eval_gettext at the beginning, the varable name was probably supposed to be part of the preceding string. So either remove the \ or do everything in one string as in the attached diff, which I have tested (at least in English).

I hope this is close enough to a patch.

Changed in xorg (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → Low
Brian Murray (brian-murray)
tags: added: patch
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks. The patch actually would break the translation gettext() calls, since the filename would not be the same every time. That's why the variable was segregated as it was.

However, the variable name certainly should not be escaped like that. I've dropped the \ - this is committed to git and will go out in natty. Let me know if it's worth putting through as an SRU - its a simple enough patch but given it's Low importance maybe it's not worth the trouble?

Changed in xorg (Ubuntu):
assignee: nobody → Bryce Harrington (bryce)
status: Triaged → Fix Committed
Revision history for this message
Geir Ove Myhr (gomyhr) wrote :

I agree that it is not worth the trouble putting this through as an SRU.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xorg - 1:7.5+6ubuntu4

---------------
xorg (1:7.5+6ubuntu4) natty; urgency=low

  * debian/local/Failsafe/failsafeXinit:
    + Fix variable escaping so shows file name for debugging tarball
      (LP: #596819)
  * debian/apport/source_xorg.py:
    + Extract VGA pci info
    + Quell display of errors when glxinfo, gdm logs, etc. aren't present
    + Check for dist-upgraded systems
    + Attach plymouth logs if present
 -- Bryce Harrington <email address hidden> Wed, 22 Dec 2010 12:03:51 -0800

Changed in xorg (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Paul Sladen (sladen) wrote :

A natty upgrade 24 hours later results in GDM appearing as a flashing white rectangle (bug #693843). This may, or may not be related.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.