Automounting not prevented with GParted in Ubuntu 10.04

Thanks Curtis! Indeed this should be applied as an SRU for lucid, so that it'll land on the 10.04.1 point release.

I've noticed unmounting partitions is not enough, any existing SWAP-type partitions on internal hard disks are detected and enabled and require sudo swapoff -a to "free" such disks for partitioning. Should I open another bug report for swap specifically ?

I believe that it is the Ubuntu Live CD that enables the swap on bootup. This is not the same as partitions that are automatically mounted when introduced to the system, such as plugging in a USB flash drive.

From GParted you can select the swap partition and then use the "Partition --> Swapoff" menu option to disable the swap.

I applied the patch to the lucid package, and tested locally. Works fine here. Uploaded to lucid-proposed queue, needs review by an SRU team member.

This bug was fixed in the package gparted - 0.5.2-2ubuntu2

---------------
gparted (0.5.2-2ubuntu2) maverick; urgency=low

  * Add 02_udisks.patch: Use udisks in favor of devicekit-disks and hal to
    inhibit automount while gparted is running. Patch backported from 6.0.
    (LP: #588530)
 -- Martin Pitt <email address hidden> Tue, 20 Jul 2010 15:00:40 +0200

SRU needs a test case

15:11 <cjwatson> pitti: do we need to handle both udisks and hal-lock being there?
15:33 <pitti> cjwatson: yes, in case hal is running
15:48 <cjwatson> pitti: the current fix only calls udisks, and doesn't have the udisks && hal-lock case to match devkit-disks && hal-lock below

Based on comment #7, are you saying that you need something like the following if both udisks and hal-lock are present together?

E.g.:

 udisks --inhibit -- \
  hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive \
   --run "/path-to-gpartedbin $*"

My testing on Lucid with only the udisks command (without hal-lock) has shown that udisks alone appears to prevent auto-mounting.

E.g.:

 sudo udisks --inhibit -- /path-to-gpartedbin $*

Martin reckoned that on current Ubuntu, only udisks is running by default, while on current Kubuntu, only hal is running by default - but it's conceivable that somebody might end up with both the udisks and hal daemons running due to installing additional packages. At least, so I understand it.

Jonathan Riddell [2010-07-20 13:38 -0000]:
> SRU needs a test case

Added.

Colin Watson [2010-07-21 7:03 -0000]:
> Martin reckoned that on current Ubuntu, only udisks is running by
> default, while on current Kubuntu, only hal is running by default - but
> it's conceivable that somebody might end up with both the udisks and hal
> daemons running due to installing additional packages.

Having the daemons running is not a problem, but the case where this
fails would be that you are running Kubuntu (which uses hal for
automounting), have udisks installed, and start gparted. Admittedly
this is not a very common scenario, but it's easy to fix this case as
well by locking both hal and udisks.

Curtis, would you mind committing something like in comment 8?

Thanks,

Martin

--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

The following patch will use both udisks and hal-lock to prevent auto-mounting if both binaries exist and both daemons are running:
http://git.gnome.org/browse/gparted/commit/?id=f242ccba462ae12bc7fd82a0ae774e60bf12e008

I also re-worded the comment after committing if you want this portion of the patch too:
http://git.gnome.org/browse/gparted/commit/?id=280f532f4aad28bf738f8a9eb627862251b312e2

If you need any updates to this patch then just let me know.

Thanks Curtis!

I updated the maverick package:

gparted (0.5.2-2ubuntu3) maverick; urgency=low

  * 02_udisks.patch: Apply upstream commit f242cc to also fix the corner case
    of having both udisks and hal running. Thanks Curtis Gedak! (LP: #588530)

 -- Martin Pitt <email address hidden> Fri, 23 Jul 2010 10:50:48 +0200

Updated package upload to lucid-proposed.

Accepted gparted into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

I was able to reproduce this bug using gparted 0.5.1-1ubuntu2; however, I can *not* recreate this bug using gparted 0.5.1-1ubuntu3 in lucid-proposed. Please let me know if I need to provide any additional information. Thanks.

This bug was fixed in the package gparted - 0.5.1-1ubuntu3

---------------
gparted (0.5.1-1ubuntu3) lucid-proposed; urgency=low

  * Add 02_udisks.patch: Use udisks in favor of devicekit-disks and hal to
    inhibit automount while gparted is running. Patch backported from 6.0.
    (LP: #588530)
 -- Martin Pitt <email address hidden> Tue, 20 Jul 2010 14:24:10 +0200

Thanks for the work here, guys. As long as you are busy working out uuid issues to do with gparted, this seems to me to be a perfect time to tackle bug #579703, which I reported some time ago.

https://bugs.launchpad.net/ubuntu/+source/gparted/+bug/579703