Cairo: clicking the Chromium launcher opens an application icon instead of just marking the launcher with arrow

Bug #587664 reported by zsolt.ruszinyák
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
cairo-dock (Ubuntu)
Invalid
Undecided
Matthieu Baerts
Lucid
Invalid
Undecided
Unassigned
Maverick
Invalid
Undecided
Matthieu Baerts
chromium-browser (Ubuntu)
Fix Released
Low
Fabien Tassin
Lucid
Fix Released
Low
Unassigned
Maverick
Fix Released
Low
Fabien Tassin

Bug Description

Binary package hint: cairo-dock

It doesn't happen with any other application but Chromium, or I haven't realized so far. Check the screenshot, I have 2 Chromium icons on the dock, 1 on the left side (launcher), the other 1 on the right side (application icon).

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: cairo-dock-core 2.1.3-10-lucid-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.32-22.33-generic 2.6.32.11+drm33.2
Uname: Linux 2.6.32-22-generic i686
Architecture: i386
Date: Sun May 30 23:05:37 2010
ExecutablePath: /usr/bin/cairo-dock
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100429)
ProcEnviron:
 LANG=en_GB.utf8
 SHELL=/bin/bash
SourcePackage: cairo-dock
XsessionErrors:
 (polkit-gnome-authentication-agent-1:10489): GLib-CRITICAL **: g_once_init_leave: assertion `initialization_value != 0' failed
 (nm-applet:10476): Gdk-CRITICAL **: gdk_window_thaw_toplevel_updates_libgtk_only: assertion `private->update_and_descendants_freeze_count > 0' failed
 (gnome-terminal:11094): Gtk-CRITICAL **: gtk_accel_map_unlock_path: assertion `entry != NULL && entry->lock_count > 0' failed

Revision history for this message
zsolt.ruszinyák (zsolt-ruszinyak) wrote :
Revision history for this message
Matthieu Baerts (matttbe) wrote :

Hello,
Thank you for having reported this bug!
Can you edit Chromium launcher (right click on it) and have a look at the application class (Extras Parameters). You can click on 'Grab' and select Chromium window.
BTW I think that Chromium doesn't use a strange class and it should be "Chromium-browser" (the same name as the launcher and its command). If it's not the case, which version of Chromium do you have and what's its class?

Changed in cairo-dock (Ubuntu):
assignee: nobody → Matthieu Baerts (matttbe)
status: New → Incomplete
Revision history for this message
zsolt.ruszinyák (zsolt-ruszinyak) wrote :

Thanks, it was so easy! I grabbed the window and the Application launcher immediately disappeared. It looks like the problem was that the Program class was set to "Chromium" insted of "Chromium-browser", because grabbing the window has changed it to "Chromium-browser".

Changed in cairo-dock (Ubuntu):
status: Incomplete → Fix Committed
Changed in cairo-dock (Ubuntu):
status: Fix Committed → Invalid
Revision history for this message
Matthieu Baerts (matttbe) wrote :

@Chromium team: Hello,
It seems that StartupWMClass value in chromium-browser.desktop file is not correct because the right class is "Chromium-browser".
You can verify it with this command:
  $ xprop |grep CLASS
(the class is the second value or directly with this one: $ xprop |grep CLASS |cut -d, -f2).
BTW, StartupWMClass parameter is optional because the class is the same as the binary (and the icon) with the first character capitalized.

It affects the trunk branch lp:chromium-browser (http://bazaar.launchpad.net/~chromium-team/chromium-browser/chromium-browser.head/annotate/head:/debian/chromium-browser.desktop) but also all other branches linked to the Chromium-Browser project on launchpad (https://code.launchpad.net/chromium-browser) and maybe also some other distributions which use this file!

Revision history for this message
Fabien Tassin (fta) wrote :

Fixed in the .head branch. It will 1st appear in the next valid daily build (tomorrow).
Please test then and report here so i can merge the fix in the other branches.

Changed in chromium-browser (Ubuntu):
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Matthieu Baerts (matttbe) wrote :

Thank you Fabien for this quick fix. It's now correct!

Changed in chromium-browser (Ubuntu):
assignee: nobody → Fabien Tassin (fta)
status: Fix Committed → Fix Released
Revision history for this message
Steve Beattie (sbeattie) wrote :

chromium-broswer has been accepted into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in cairo-dock (Ubuntu Lucid):
status: New → Invalid
Changed in chromium-browser (Ubuntu Lucid):
status: New → Fix Committed
importance: Undecided → Low
tags: added: verification-needed
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I performed the following with 5.0.375.70~r48679-0ubuntu0.10.04.1 from -proposed:
$ xprop | grep CLASS
WM_CLASS(STRING) = "chromium-browser", "Chromium-browser"

so this passes the test case. Marking "verification-done".

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package chromium-browser - 5.0.375.70~r48679-0ubuntu0.10.04.1

---------------
chromium-browser (5.0.375.70~r48679-0ubuntu0.10.04.1) lucid-security; urgency=low

  * New upstream release from the Stable Channel (LP: #591474)
    Fixes the following security issues:
    - [15766] Medium Cross-origin keystroke redirection. Credit to Michal
      Zalewski of Google Security Team.
    - [39985] High Cross-origin bypass in DOM methods. Credit to Sergey
      Glazunov.
    - [42723] High Memory error in table layout. Credit to wushi of team509.
    - [43304] High Linux sandbox escape. Credit to Mark Dowd under contract to
      Google Chrome Security Team.
    - [43307] High Bitmap stale pointer. Credit to Mark Dowd under contract to
      Google Chrome Security Team.
    - [43315] High Memory corruption in DOM node normalization. Credit to Mark
      Dowd under contract to Google Chrome Security Team.
    - [43487] High Memory corruption in text transforms. Credit to wushi of
      team509.
    - [43902] Medium XSS in innerHTML property of textarea. Credit to
      sirdarckcat of Google Security Team.
    - [44740] High Memory corruption in font handling. Credit: Apple.
    - [44868] High Geolocation events fire after document deletion. Credit to
      Google Chrome Security Team (Justin Schuh).
    - [44955] High Memory corruption in rendering of list markers. Credit:
      Apple.
  * Add a --temp-profile knob to the launcher script starting Chromium with
    a new profile which will last only for the duration of the session
    - update debian/chromium-browser.sh
  * Change StartupWMClass to Chromium-browser in the desktop launcher so
    cairo-dock does the right thing (LP: #587664)
    - update debian/chromium-browser.desktop
  * Set XLIB_SKIP_ARGB_VISUALS=1 in the wrapper to prevent flash from dying
    with a Gdk-ERROR when gtk2 is built with RGBA support (like in Maverick).
    (LP: #584959)
    - update debian/chromium-browser.sh
  * Unbreak get-orig-source when it needs to drop its cache after a channel jump
    (replace brace expansion - which is a bashism - with proper $(wildcard))
    - update debian/rules
 -- Fabien Tassin <email address hidden> Wed, 09 Jun 2010 07:30:50 +0200

Changed in chromium-browser (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.