Quickly

Faulty preferences dialog code in default ubuntu-application

Bug #587090 reported by Nick Veitch on 2010-05-29

This bug affects 1 person

	Status	Importance	Assigned to
Quickly	Fix Released	Low	Unassigned
quickly (Ubuntu)	Fix Released	Low	Unassigned
Lucid	Fix Released	Low	Unassigned

Bug Description

The auto-generated code for the main module contains some commented out code for loading Preferences at startup. It reads:

#Uncomment the following code to read in preferences at start up.
#dlg = PreferencesAppnameDialog.NewPreferencesAppnameDialog()
#self.preferences = dlg.get_preferences()

I believe it should read:

#Uncomment the following code to read in preferences at start up.
#dlg = PreferencesAppnameDialog.PreferencesAppnameDialog()
#self.preferences = dlg.get_preferences()

obviously, it doesn't generate an error unless you do uncomment it :)

Tags:

Related branches

lp:~evilnick/quickly/587090

Merged into lp:quickly at revision 508

Didier Roche-Tolomelli: Approve on 2010-06-01

lp:ubuntu/lucid-proposed/quickly

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2010-05-31:

Thanks for your interest in Quickly and help to make it better.

Sure, the default boiler plate changed there. Do you want to give a patch against the bzr branch? If not, I will integrate it for Quickly 0.4.3.

Thanks again !

Changed in quickly:
status:	New → Triaged
importance:	Undecided → Low

Revision history for this message

Nick Veitch (evilnick) wrote on 2010-05-31:

Yeah, sorry I should have done that already. might get around to it tomorrow.
I am in the middle of writing an epic tutorial on Quickly for Linux Format so I just spotted it.

Nick

Revision history for this message

Shane Fagan (shanepatrickfagan) wrote on 2010-05-31:

@Nick you could just help out on the official quickly tutorial instead of doing a different one.

Revision history for this message

Nick Veitch (evilnick) wrote on 2010-06-01:

Hi, got around to making that change and pushed it into a branch for merging

@Sahne, sure, when I have the time. Writing the LXF tutorial is sort of my job. On the plus side, it will be read by about 40,000 people who may not have heard of Quickly before, so it's a community win :)

Revision history for this message

Shane Fagan (shanepatrickfagan) wrote on 2010-06-01:

@Nick very very true

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2010-06-01:

That's a very good news Nick, Thanks a lot for your work there.

Can you make your tutorial under CC:BY-SA, so that we can reuse some pieces and integrate them in our tutorial?

Changed in quickly:
status:	Triaged → Fix Committed
Changed in quickly (Ubuntu):
status:	New → Triaged
importance:	Undecided → Low

Revision history for this message

Nick Veitch (evilnick) wrote on 2010-06-04:

well, i'll certainly ask :)

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2010-06-14:

quickly (0.4.3-0ubuntu1) lucid-proposed; urgency=low
.
   * New bugfix release:
     quickly core:
     - fix wrong template proposal for commands not followed by template
     ubuntu-application template:
     - change label caption from glade to design (LP: #571409)
     - fix dialog when having - in title name (LP: #578710)
     - fix unicode problems in About dialog (LP: #582584) (Petar Vasić)
     - fix the boiler plate for faulty preferences dialog code (LP: #587090)
       (Nick Veitch)
     ubuntu-application and inherited:
     - fix configure stripping team name for ppa (LP: #587314) (Frederik Elwert)
     - fix not all syntax for dependencies supported (LP: #587520) (Frederik
       Elwert)
     - fix issue and description of release: quickly release <number>
     updated translations

TestCase:
- install the new version
- check that the bugs listed in the changelog are fixed
- check that it doesn't break the normal Quicklly workflow

Changed in quickly (Ubuntu Lucid):
status:	New → Triaged
importance:	Undecided → Low

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2010-06-14:

Filtered diff (without translation) Edit (14.9 KiB, text/plain)

Changed in quickly:
status:	Fix Committed → Fix Released

Revision history for this message

Martin Pitt (pitti) wrote on 2010-06-18: Please test proposed package

#10

Accepted quickly into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in quickly (Ubuntu Lucid):
status:	Triaged → Fix Committed
tags:	added: verification-needed

Revision history for this message

Ryan Macnish (nisshh) wrote on 2010-06-18:

#11

I have tested 0.4.3 and this bug is fixed.

Martin Pitt (pitti) on 2010-06-18

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-06-24:

#12

This bug was fixed in the package quickly - 0.4.3-0ubuntu1

---------------
quickly (0.4.3-0ubuntu1) lucid-proposed; urgency=low

  * New bugfix release:
    quickly core:
    - fix wrong template proposal for commands not followed by template
    ubuntu-application template:
    - change label caption from glade to design (LP: #571409)
    - fix dialog when having - in title name (LP: #578710)
    - fix unicode problems in About dialog (LP: #582584) (Petar Vasić)
    - fix the boiler plate for faulty preferences dialog code (LP: #587090)
      (Nick Veitch)
    ubuntu-application and inherited:
    - fix configure stripping team name for ppa (LP: #587314) (Frederik Elwert)
    - fix not all syntax for dependencies supported (LP: #587520) (Frederik
      Elwert)
    - fix issue and description of release: quickly release <number>
    updated translations
-- Didier Roche <email address hidden> Fri, 11 Jun 2010 13:18:01 +0200