Add a wrapper for LD_LIBRARY_PATH to gnome-shell so we don't have to rebuild gjs for xulrunner updates

For gjs, it's a matter of building against xulrunner-1.9.2 without specifying a version.

Sorry, for gjs it's adding unversioned binary depends on xulrunner-1.9.2

I'm not sure whether this would be the best way to solve the problem, but couldn't you install a file in /etc/ld.so.conf.d for xulrunner-1.9.2 so that the appropriate directory is included in the library search path? A related bug, from which this suggestion comes, is https://bugs.launchpad.net/ubuntu/+source/xulrunner-1.9/+bug/557275.

Thanks, but we won't be installing a file in /etc/ld.so.conf.d because we don't want xulrunner to be treated as a normal system library (this is why it is not already installed in an existing search path). If we wanted to treat xulrunner as a system library, then we would install all of the libraries in /usr/lib instead.

Could this be done the debian way.
The debian packages gnome-shell (2.31.5), gjs (0.7.1-1) and libgjs0a (0.7.1-1) depend on the package libmozjs2d, which provides the file libmozjs.so.2d.
So these are not depending on the package xulrunner.

Not unless we add back libmozjs which is what bug 286906 is for.

On 08/07/2010 02:58 PM, Harry wrote:
> Could this be done the debian way.
> The debian packages gnome-shell (2.31.5), gjs (0.7.1-1) and libgjs0a
(0.7.1-1) depend on the package libmozjs2d, which provides the file
libmozjs.so.2d.
> So these are not depending on the package xulrunner.
>

Exactly, this works in debian.
libmozjs2d for xulrunner_1.9.1.11
libmozjs3d for xulrunner_1.9.2.8

This bug was fixed in the package gjs - 0.7.1-1ubuntu2

---------------
gjs (0.7.1-1ubuntu2) maverick; urgency=low

  * fix LP: #576991 - Make gjs not need a rebuild for each xulrunner release;
    Use dh_xulrunner to add binary depends on xulrunner for libgjs0a;
    Add binary depends on xulrunner-dev (>= 1.9.2) for libgjs-dev
    - update debian/control
    - update debian/rules
  * fix LP: #629631 - gnome-shell will not install due to depends issues; fixed
    by the above changes
  * Add back chrpath as a build-dep and delete the rpath in libgjs; Any rdepends
    of libgjs will now need a wrapper script to find libmozjs
    - update debian/rules
    - update debian/control
  * Add a wrapper around gjs-console so it can find libmozjs; install wrapper
    in override_dh_install
    - update debian/rules
 -- Micah Gersten <email address hidden> Sat, 04 Sep 2010 21:03:36 -0500

This bug was fixed in the package gnome-shell - 2.31.5-2ubuntu2

---------------
gnome-shell (2.31.5-2ubuntu2) maverick; urgency=low

  * Fix gnome-shell to set LD_LIBRARY_PATH so that libmozjs can be found;
    Don't use pkg-config, use xulrunner-1.9.2 to figure out the path to
    libmozjs (LP: #576991) (LP: #629828)
    - update debian/patches/04_workaround_libmozjs_build.patch
  * Drop binary depends on pkg-config and replace with xulrunner-1.9.2;
    xulrunner-1.9.2 is already pulled in by the depends in any case, but
    now it's needed directly by gnome-shell
    - update debian/control.in
 -- Micah Gersten <email address hidden> Sat, 04 Sep 2010 21:00:09 -0500

Any plans for Lucid?

 Yes, shortly.

On 09/10/2010 07:04 AM, thiagoss wrote:
> Any plans for Lucid?
>

This built fine in my PPA:
https://launchpad.net/~micahg/+archive/sru-test/+sourcepub/1292146/+listing-archive-extra

This built fine in my PPA:
https://launchpad.net/~micahg/+archive/sru-test/+sourcepub/1292182/+listing-archive-extra

gjs:
O: libgjs0: binary-or-shlib-defines-rpath ./usr/lib/libgjs-gi.so.0.0.0 /usr/lib/xulrunner-1.9.2.3

gnome-shell:
I don't see the dependancy changes mentioned in the changelog.

Dropped rpath for /usr/lib/libgjs-gi.so.0.0.0 as well

Fixed binary depends

I: libgjs0: unused-override binary-or-shlib-defines-rpath

Do we want to drop that override too?

Accepted gnome-shell into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

lintian override removed

gjs uploaded to lucid-proposed.

As soon as it's accepted we can rebuild the gnome-shell in proposed, sorry I think my pbuilder didn't test it with -updates and -proposed enabled.

Verification for Lucid:
I can not test the version in lucid-proposed because of bug 642724 which seems to be a regression for bug 608940

Accepted gjs into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

 That's not a regression. That's expected until this bug is fixed
(which is what the packages in -proposed are supposed to do :) )

On 09/23/2010 05:38 AM, Jean-Baptiste Lallement wrote:
> Verification for Lucid:
> I can not test the version in lucid-proposed because of bug 642724 which seems to be a regression for bug 608940
>

> (which is what the packages in -proposed are supposed to do :) )

Except that they were uploaded in the wrong order, so gnome-shell hasn't built yet, and build until gjs has built. I'll organise the rebuilds.

situations improving on lucid used to be having to restrict the version of xulrunner to get things to work now its simpler
 as harry said in the duplicate (he made a link to the version in xulrunner-1.9.2.8)
As a workaround, I made a symlink to /usr/lib/xulrunner-1.9.2.10/libmozjs.so in the directory /usr/lib/
Now gnome-shell loads OK.
wonder if it will break again on the next update - least ways now gnome-shell doesn't get uninstalled on upgrades which i found happening previously.

To update this bug with a conversation that happened on IRC:
gnome-shell doesn't seem to build on lucid-proposed (it did before upload). Micah Gersten will investigate this and provide a new patch.

This patch adds LD_LIBRARY_PATH to the build system which should fix the FTBFS.

Uploaded

Accepted gnome-shell into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

I have never left feedback on a bug before so sorry if this isn't useful. I enabled lucid-proposed, gnome-shell installed with no broken packages. Please let me know if you need any more information.

Thanks for testing!

This bug was fixed in the package gjs - 0.5-1ubuntu2.3

---------------
gjs (0.5-1ubuntu2.3) lucid-proposed; urgency=low

  * fix LP: #576991 - Make gjs not need a rebuild for each xulrunner release;
    Use dh_xulrunner to add binary depends on xulrunner for libgjs0a;
    Add binary depends on xulrunner-dev (>= 1.9.2) for libgjs-dev
    - update debian/control
    - update debian/rules
  * Add back chrpath as a build-dep and delete the rpath in libgjs and
    libgjs-gi.so; Any rdepends of libgjs will now need a wrapper script to find
    libmozjs
    - update debian/rules
    - update debian/control
  * Add a wrapper around gjs-console so it can find libmozjs; install wrapper
    in override_dh_install
    - update debian/rules
    - add debian/gjs-console.sh
  * Drop lintian override for libgj0 since we dropped the rpath
    - drop debian/libgjs0.lintian-overrides
 -- Micah Gersten <email address hidden> Fri, 17 Sep 2010 09:29:37 +0200

This bug was fixed in the package gnome-shell - 2.28.1~git20091125-1ubuntu0.2

---------------
gnome-shell (2.28.1~git20091125-1ubuntu0.2) lucid-proposed; urgency=low

  * Add LD_LIBRARY_PATH to the build system so libmozjs symbols can be found
    (LP: #576991); Patch adapted from Maverick version
    - add debian/patches/04_workaround_libmozjs_build.patch
 -- Micah Gersten <email address hidden> Tue, 19 Oct 2010 08:49:07 +0200