Ubuntu
qbzr package

qlog search not working correctly.

Bug #575338 reported by Gary van der Merwe
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Critical
Gary van der Merwe
QBzr 0.18.6
qbzr (Ubuntu)
Fix Released
Undecided
Unassigned
Lucid
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: qbzr

qlog search not working correctly in lucid. It only matches the last part of a field it's searching. eg. if you search for 'a' it will find 'ba' but not 'ab'.

This is due to a change in the behaviour of pythons fnmatch.translate. Previously fnmatch.translate('a') == 'a$'. This has changed in lucid. Now fnmatch.translate('a') == 'a\\Z(?ms)'

qlog did .rstrip('$') so that it would match anywhere. This no longer works.

Related branches

lp:qbzr/0.18
Gary van der Merwe (garyvdm)
Changed in qbzr:
importance: Undecided → High
milestone: none → 0.18.6
status: New → Confirmed
Gary van der Merwe (garyvdm)
Changed in qbzr:
assignee: nobody → Gary van der Merwe (garyvdm)
status: Confirmed → Fix Released
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

Steps to reproduce.

bzr init test
cd test
echo foo > foo
bzr add
bzr commit -m "ab"
echo bar > foo
bzr commit -m "ba"
bzr qlog

type 'a' in to the search box.

Actual result:
only Rev 2 shows ('ba')

Expected result:
both revisions show.

Revision history for this message
Gary van der Merwe (garyvdm) wrote :

SRU requriments:

This affects users of qbzr and bzr-explorer who want to use the log search functionality.

The bug has be fixed in the upstream qbzr 0.18.6 release.

This shows a diff of the fix: http://bazaar.launchpad.net/~qbzr-dev/qbzr/0.18/revision/1234

TEST CASE: Please see comment # 1

Regression potential: qbzr is used by bzr-explorer. However, the fix is very limited, so the regression potential is very small.

Changed in qbzr:
importance: High → Critical
Revision history for this message
Gary van der Merwe (garyvdm) wrote :
Revision history for this message
Martin Pitt (pitti) wrote :

Looks fine, approved. Please upload.

Changed in qbzr (Ubuntu Lucid):
status: New → In Progress
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

On 05/05/2010 08:32, Martin Pitt wrote:
> Looks fine, approved.
 Thanks.

> Please upload.
Sorry, I'm not a motu. I've subscribed ubuntu-universe-sponsors.

Revision history for this message
Benjamin Drung (bdrung) wrote :

uploaded

Revision history for this message
Benjamin Drung (bdrung) wrote :

I had to change the target from lucid to lucid-proposed.

Changed in qbzr (Ubuntu Lucid):
status: In Progress → Fix Committed
Revision history for this message
Gary van der Merwe (garyvdm) wrote : Re: [Bug 575338] Re: qlog search not working correctly.

On 05/05/2010 15:21, Benjamin Drung wrote:
> uploaded
>
 Thanks Benjamin.

Revision history for this message
Scott Kitterman (kitterman) wrote : Please test proposed package

Accepted into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

I've tested. It works.

It may be good to get some one independent to test.

Revision history for this message
Stefan Lesicnik (stefanlsd) wrote :

I've tested and can confirm the bug behavior before and that the fix in proposed works.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qbzr - 0.18.6-0ubuntu1

---------------
qbzr (0.18.6-0ubuntu1) lucid-proposed; urgency=low

  * New upstream release
   - Fixes qlog search. (LP: #575338)
 -- Gary van der Merwe <email address hidden> Tue, 04 May 2010 22:13:23 +0200

Changed in qbzr (Ubuntu Lucid):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Copied to maverick.

Changed in qbzr (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.