"Delete" and "Apply" buttons shows untranslated, and can't be translated

Bug #442990 reported by Ricardo Pérez López
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Translations
Fix Released
Undecided
Adi Roiban
gnome-desktop
Fix Released
Medium
gnome-disk-utility (Ubuntu)
Fix Released
Low
Martin Pitt

Bug Description

Binary package hint: gnome-disk-utility

The "Delete" and "Apply" buttons shows untranslated in my Karmic Beta Spanish desktop, and can't be translated because there aren't in the Launchpad template:

https://translations.edge.launchpad.net/ubuntu/karmic/+source/gnome-disk-utility/+pots/gnome-disk-utility/es/+translate?batch=10&show=all&search=Delete

https://translations.edge.launchpad.net/ubuntu/karmic/+source/gnome-disk-utility/+pots/gnome-disk-utility/es/+translate?batch=10&show=all&search=Apply

I attach an screenshot to illustrate the problem.

Revision history for this message
Ricardo Pérez López (ricardo) wrote :
Adi Roiban (adiroiban)
Changed in gnome-disk-utility (Ubuntu):
status: New → Confirmed
Changed in ubuntu-translations:
status: New → Confirmed
Revision history for this message
Adi Roiban (adiroiban) wrote :

Be problem is in src/palimpsest/gdu-section-partition.c as the Delete and Apply text are not marked for translations.

This is one possible sollution.

        button = gtk_button_new_with_mnemonic (_("_Delete"));
        gtk_widget_set_tooltip_text (button, _("Delete the partition"));
        g_signal_connect (button, "clicked", G_CALLBACK (on_delete_partition_clicked), section);
        gtk_container_add (GTK_CONTAINER (button_box), button);

        button = gtk_button_new_with_mnemonic (_("_Revert"));
        section->priv->modify_part_revert_button = button;
        gtk_container_add (GTK_CONTAINER (button_box), button);

        button = gtk_button_new_with_mnemonic (_("_Apply"));
        gtk_widget_set_tooltip_text (button, _("Apply the changes made"));
        g_signal_connect (button, "clicked", G_CALLBACK (on_modify_partition_apply_clicked), section);
        section->priv->modify_part_apply_button = button;
        gtk_container_add (GTK_CONTAINER (button_box), button);

Another one would be to use the gtk_button_new_from_stock function and in this later case it will use the default GTK translations.

Adi Roiban (adiroiban)
Changed in ubuntu-translations:
assignee: nobody → Adi Roiban (adiroiban)
Revision history for this message
Sebastien Bacher (seb128) wrote :

The issue should be easy to fix there, Martin could you have a look since the package is in sync with debian and you probably want to keep it this way?

Changed in gnome-disk-utility (Ubuntu):
importance: Undecided → Low
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Martin Pitt (pitti) wrote :

Patch created and sent upstream, and applied to Debian git head.

Changed in gnome-disk-utility (Ubuntu):
status: Confirmed → In Progress
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-disk-utility - 2.28.0-1karmic1

---------------
gnome-disk-utility (2.28.0-1karmic1) karmic; urgency=low

  * Debian packaging git snapshot to get bug fix below.
  * debian/rules: Enable quilt patch system. Add quilt build dependency.
  * Add 01_untranslated_buttons.patch: Replace untranslatable "Apply" and
    "Delete" buttons with stock GTK buttons. (LP: #442990)

 -- Martin Pitt <email address hidden> Mon, 05 Oct 2009 16:06:53 +0200

Changed in gnome-disk-utility (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Ricardo Pérez López (ricardo) wrote :

That was fast! Thanks very much, Martin!

Changed in ubuntu-translations:
status: Confirmed → Fix Released
Changed in gnome-desktop:
importance: Unknown → Medium
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.