dpkg-source sets -i -I by default

Looking at the changelog in http://changelogs.ubuntu.com/changelogs/pool/main/d/dpkg/dpkg_1.14.20ubuntu6/changelog , I believe it version 1.14.17 that broke debuild.
Not including some binaries in the sources is IMO a good choice, but we should at least have a way to tell dpkg-source to include them (bypassing the default).

I cannot reproduce this with a trivial test case. Please provide your full build log, and the contents of ~/.devscripts.

Hi,

I am not home for the moment so I can't provide a build.log right now but I can give you a link to the sources I wanted to pack on intrepid.

https://edge.launchpad.net/~team-xbmc-svn/+archive
    * xbmc_8.10final1svn17113-hardy1.diff.gz (6.6 KiB)
    * xbmc_8.10final1svn17113-hardy1.dsc (1.7 KiB)
    * xbmc_8.10final1svn17113.orig.tar.gz (121.3 MiB)

Getting those, you can unpack them and try to repack using "debuild -S -sa", you migth notice a diff between the two packages.

I will try to create a smaller example to reproduce, when I get home.

Oki,

Here is an example I have made. On intrepid, when running debuild -S -sa, the orig file doesn't contain the .a files.

I ran your test and the resulting test_1.0.orig.tar.gz is as follows:

$ tar tzvf ../test_1.0.orig.tar.gz
drwxr-xr-x cjwatson/cjwatson 0 2009-01-16 20:00 test-1.0.orig/
-rw-r--r-- cjwatson/cjwatson 4204734 2009-01-16 19:49 test-1.0.orig/libsmbclient-x86_64-linux.a
-rw-r--r-- cjwatson/cjwatson 2675908 2009-01-16 19:49 test-1.0.orig/libsmbclient-i486-linux.a

As I requested a few comments ago, could you please provide the full build log that you see (you'll find it in test_1.0-1_source.build) and the contents of your ~/.devscripts file?

Here is my log file.

I don't have a .devscripts in my HOME directory.

By the way, are you using intrepid for your tests ?

Ah, this is specifically a bug in Intrepid's dpkg, not in other releases. It was fixed by Debian in dpkg 1.14.21.

I've uploaded a fix for this to intrepid-proposed. ubuntu-sru team: please review.

Fix tested and works for me

Accepted into intrepid-proposed; please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

I had run into this bug the other day in building a commercial package with .so files in it. I installed the update from proposed and can confirm that -I is now disabled by default as it should be.

I built some source packages with this version, and confirm that -i -I are not used by default. Explicitly using -i and -I still works correctly.

I also tested dpkg itself with some dist-upgrades, and dpkg -P, and did not see any regressions. Together with Brian's testimonial I consider this verified.

This bug was fixed in the package dpkg - 1.14.20ubuntu6.2

---------------
dpkg (1.14.20ubuntu6.2) intrepid-proposed; urgency=low

  * Backport from 1.14.21 (Raphael Hertzog):
    - Fix dpkg-source to not use -i and -I by default with "1.0" source
      packages. Closes: #495138, LP: #317761

 -- Colin Watson <email address hidden> Thu, 05 Mar 2009 09:37:38 +0000

Has this bug regressed to dpkg 1.16.1.2?

> tar -xzf foo-app-full.tgz
> cd fooapp-1.0

> cat debian/source/include-binaries
extra/bar
extra/bar.so
extra/bar.a

> dpkg-source -b .
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building fooapp using existing ./fooapp_1.0.orig.tar.gz
dpkg-source: info: building fooapp in fooapp_1.0-1.debian.tar.gz
dpkg-source: info: building fooapp in fooapp_1.0-1.dsc

> tar -ztf ../fooapp_1.0-1.debian.tar.gz | grep bar
extra/bar

> dpkg-source -b -I*.dat .
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building fooapp using existing ./fooapp_1.0.orig.tar.gz
dpkg-source: info: building fooapp in fooapp_1.0-1.debian.tar.gz
dpkg-source: info: building fooapp in fooapp_1.0-1.dsc

> tar -ztf ../fooapp_1.0-1.debian.tar.gz | grep bar
extra/bar.so
extra/bar.a
extra/bar

for source format 3.0 (quilt), the --help switch shows you which -I options are set by default:

  -I[<pattern>] filter out files when building tarballs
                             (defaults to: -I*.a -I*.la -I*.o -I*.so -I.*.sw? -I*/*~ -I,,* -I.[#~]* -I.arch-ids -I.arch-inventory -I.be -I.bzr -I.bzr.backup -I.bzr.tags -I.bzrignore -I.cvsignore -I.deps -I.git -I.gitattributes -I.gitignore -I.gitmodules -I.hg -I.hgignore -I.hgsigs -I.hgtags -I.shelf -I.svn -ICVS -IDEADJOE -IRCS -I_MTN -I_darcs -I{arch}).

I believe indeed this is a bug in dpkg-dev, since we are explicitely requesting those files to be included. The default set of excludes should not remove this file from the source package. which is why I reported a debian bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=718984