Syntax error in xkbcomp call in apport hook

Bug #311442 reported by Matt Zimmerman
2
Affects Status Importance Assigned to Milestone
xorg (Ubuntu)
Fix Released
Low
Bryce Harrington

Bug Description

Binary package hint: xorg

/usr/share/apport/package-hooks/source_xorg.py reads:

        script = subprocess.Popen(['xkbcomp', ':0 -'], stdout=subprocess.PIPE)

but this results in:

Error: Cannot open display ":0 -"
                  Exiting

this should instead be:

        script = subprocess.Popen(['xkbcomp', ':0', '-'], stdout=subprocess.PIPE)

Note ':0' and '-' being passed as separate arguments to xkbcomp.

ProblemType: Bug
Architecture: amd64
DistroRelease: Ubuntu 9.04
Package: x11-common 1:7.4~5ubuntu9
PackageArchitecture: all
ProcEnviron:
 LC_COLLATE=C
 PATH: custom, user
 LANG=en_US.UTF-8
 SHELL=/bin/zsh
ProcVersion: Linux version 2.6.28-3-generic (buildd@yellow) (gcc version 4.3.3 20081210 (prerelease) (Ubuntu 4.3.2-2ubuntu8) ) #4-Ubuntu SMP Fri Dec 12 22:47:31 UTC 2008

SourcePackage: xorg
Uname: Linux 2.6.28-3-generic x86_64
xkbcomp:

Tags: apport-bug

Related branches

Revision history for this message
Matt Zimmerman (mdz) wrote :
Revision history for this message
Matt Zimmerman (mdz) wrote :

You might also consider converting some of this hook to use apport.hookutils, which lets you do, e.g.:

report['xkbcomp'] = hookutils.command_output(['xkbcomp',':0','-'])

and it does the error handling for you.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Bryce knows more about this :)

Changed in xorg:
assignee: nobody → bryceharrington
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Bryce Harrington (bryce) wrote :

Committed to ubuntu-x git

Changed in xorg:
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xorg - 1:7.4~5ubuntu10

---------------
xorg (1:7.4~5ubuntu10) jaunty; urgency=low

  * apport/source_xorg.py: Fix arg list to prevent error
    'Error: Cannot open display ":0 -"'
    (LP: #311442)

 -- Bryce Harrington <email address hidden> Tue, 06 Jan 2009 01:56:25 -0800

Changed in xorg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.