Launchpad itself

Some projects erroneously reported as proprietary

Bug #308192 reported by Brad Crittenden
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Curtis Hovey
Launchpad itself 2.2.4

Bug Description

A project with one of the pre-approved licenses was marked as 'license reviewed' in the administrative interface. When that was done the project was seen to LP as proprietary and the owner was shown the message stating he needed to purchase a subscription.

The logic determining whether a project is proprietary needs to take the actual license into consideration, not just look at the combination of the 'reviewed' and 'approved' flags.

Tags: lp-registry
Revision history for this message
Brad Crittenden (bac) wrote :

Ensure the fix for this bug does not regress bug 248534.

Brad Crittenden (bac)
Changed in launchpad:
assignee: nobody → bac
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Undecided → Low
status: New → Triaged
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → 2.2.2
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 2.2.2 → 2.2.3
Revision history for this message
Curtis Hovey (sinzui) wrote :

Brad I'm moving this to 2.2.5 because I believe the private teams work will take most of your time in 2.2.4.

Changed in launchpad-registry:
milestone: 2.2.3 → 2.2.5
Revision history for this message
Curtis Hovey (sinzui) wrote :

This is the cause of the insanity in the context object

        elif (self.license_reviewed and
              (License.OTHER_OPEN_SOURCE in self.licenses or
               self.license_info not in ('', None))):

This means that there are explict and implicit OTHER_OPEN_SOURCE. We cannot approve the latter. We need to ask the project owner to add OTHER_OPEN_SOURCE for us to approve the additional license information, or the owner can clear the field.

    /!\ The license information is ambiguous. Either choose Other Open Source License
    or clear the License Information field so that the license can be approved.

To prevent this insane data state, we need to ensure that the license info cannot be submitted if OTHER_OPEN_SOURCE is not selected.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
assignee: Brad Crittenden (bac) → Curtis Hovey (sinzui)
Revision history for this message
Curtis Hovey (sinzui) wrote :

I am marking this high because we can see that this is a problems for hundreds of projects,

Changed in launchpad-registry:
importance: Low → High
status: Triaged → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

After discussing the issue with other developers, we want to continue to allow owners to provide additional license information. We want to change the Approval rule to allow explicit Other/Open Source and implicit because there is unaccounted for license info. The license review ca mark the project approved and there will be no other issues with the project.

It would be nice to allow the reviewer to select or unselect Other/Open Source to clarify the
license, but this is a not required.

Revision history for this message
Curtis Hovey (sinzui) wrote :

The behaviour is fixed. Now we need a few evenings to review the backlog of projects that were reviewed, but not approved.

Changed in launchpad-registry:
milestone: 2.2.5 → 2.2.4
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.