Comment 3 for bug 308192

Revision history for this message
Curtis Hovey (sinzui) wrote :

This is the cause of the insanity in the context object

        elif (self.license_reviewed and
              (License.OTHER_OPEN_SOURCE in self.licenses or
               self.license_info not in ('', None))):

This means that there are explict and implicit OTHER_OPEN_SOURCE. We cannot approve the latter. We need to ask the project owner to add OTHER_OPEN_SOURCE for us to approve the additional license information, or the owner can clear the field.

    /!\ The license information is ambiguous. Either choose Other Open Source License
    or clear the License Information field so that the license can be approved.

To prevent this insane data state, we need to ensure that the license info cannot be submitted if OTHER_OPEN_SOURCE is not selected.