Jockey tries to override -envy packages with ubuntu packages (with fglrx)

Bug #221968 reported by Alberto Milone
6
Affects Status Importance Assigned to Milestone
Jockey
Fix Released
Undecided
Martin Pitt
jockey (Ubuntu)
Fix Released
Undecided
Martin Pitt
Hardy
Fix Released
Undecided
Martin Pitt
Intrepid
Fix Released
Undecided
Martin Pitt

Bug Description

TEST CASE: a user installs xorg-driver-fglrx-envy, fglrx-kernel-source-envy, gets direct rendering, tries to enable the 3D effects but Jockey says that the driver is not enabled and therefore tries to install Ubuntu's xorg-driver-fglrx instead.

Adding fglrx to devices[0].driver in ['ati', 'radeon', None] in /usr/share/jockey/handlers/fglrx.py solves the problem.

Revision history for this message
Martin Pitt (pitti) wrote :

Confirmed, just discussed in IRC. Easy and straightforward patch, good for SRU.

Changed in jockey:
assignee: nobody → pitti
milestone: none → ubuntu-8.04.1
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Note to self: nvidia handler probably has the same problem.

Revision history for this message
Martin Pitt (pitti) wrote :
Changed in jockey:
assignee: nobody → pitti
status: New → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Explanation of the patch: This fixes the fglrx handlers' enables_composite() method to detect whether 'fglrx' is already selected in xorg.conf. If so, then we don't need to install the Ubuntu fglrx package to provide composite support, the currently running driver is sufficient (which is also fglrx, but from a third party).

Changed in jockey:
assignee: nobody → pitti
milestone: none → ubuntu-8.04.1
status: New → In Progress
Revision history for this message
Steve Langasek (vorlon) wrote :

accepted in hardy-proposed, please test.

Changed in jockey:
status: In Progress → Fix Committed
Steve Langasek (vorlon)
Changed in jockey:
milestone: ubuntu-8.04.1 → none
Revision history for this message
Alberto Milone (albertomilone) wrote :

Ok, here's what happens with the packages in hardy-proposed:
1) 1st try: it says that "Desktop effects can't be enabled".
2) 2nd try (after few seconds): I can enable the desktop effects.

See the attached xsession-errors

Revision history for this message
Alberto Milone (albertomilone) wrote :

Jockey no longer tries to install Ubuntu's xorg-driver-fglrx and therefore doesn't try to overwrite -envy packages any longer.

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks, Alberto. The appearance-properties problem actually sounds a bit like bug 208026, but apparently it's a different one. Can you please report a new bug against gnome-control-center?

Revision history for this message
Alberto Milone (albertomilone) wrote :

reported in #221977

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jockey - 0.3.3-0ubuntu9

---------------
jockey (0.3.3-0ubuntu9) intrepid; urgency=low

  * Upload fixes from hardy-proposed to intrepid.

jockey (0.3.3-0ubuntu8) hardy-proposed; urgency=low

  * fglrx.py: Do not override already installed third-party fglrx driver with
    --check-composite. (LP: #221968)
  * debian/control: Updated Vcs-Bzr: to point to the hardy branch.
  * XorgDriverHandler, nvidia, fglrx: Set identifiers for newly created
    sections, they are invalid without one. Thanks to Laszlo Pandy!
    (LP: #218478)
  * nvidia.py: Fix "enabled" handling: check if the package is installed and
    module not blacklisted. (LP: #216650)
  * OSLib.open_app(): Wait until the subprocess returned, so that we can check
    the system state afterwards. (prerequisite for change below)
  * jockey/ui.py, --check-composite: Re-check the system after attempting to
    enable the driver, and only signal success (exit with 0) if the driver was
    actually enabled. Otherwise, cancelling installation would invalidly
    signal success to the caller. (LP: #208026)

 -- Martin Pitt <email address hidden> Mon, 05 May 2008 20:49:10 +0200

Changed in jockey:
status: In Progress → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Copied to hardy-updates.

Changed in jockey:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.