cupsd 2.4.7-1.2ubuntu5 on noble crashes due to recently backported commits from 2.4.x git

Bug #2060692 reported by Andreas Karlson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cups (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

While checking out the latest versions of cups (2.4.7-1.2ubuntu4 and 2.4.7-1.2ubuntu5),
I noticed that cupsd crashes consistently after closing my Firefox tab / window.
The title of the crash (from the bug-report window) is "cupsd crashed with SIGSEGV in ???()"

I'm running the noble-desktop-amd64.iso from 2024-03-25 after applying some updates from the noble and noble-proposed pockets.

Reproduction steps:
1. Open Firefox and manage CUPS on http://localhost:631
2. Go to Administration -> Printers -> Add Printer and choose your printer
3. Add your printer (I used the ipps:// protocol to manage the printer)
4. After clicking the "Add printer" button, immediately close your Firefox tab
5. cupsd will crash and Ubuntu will display a bug-report popup

Versions:
    Firefox - 124.0.1-1 r4033
    CUPS - 2.4.7-1.2ubuntu5

Printer:
    Lexmark MS415dn (supported)

I am unable to reproduce this bug on versions prior to 2.4.7-1.2ubuntu4 (Tried with 2.4.7-1.2ubuntu1 and 2.4.7-1.2ubuntu2).

Versions 2.4.7-1.2ubuntu4 and 2.4.7-1.2ubuntu5 only backported commits from the 2.4.x upstream git branch, so I also opened an issue on GitHub:
https://github.com/OpenPrinting/cups/issues/934

Tags: noble
Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

Andreas,

thanks for also reporting upstream. Michael, Sweet, author of CUPS, has already found a solution. See:

https://github.com/OpenPrinting/cups/issues/934

I will apply this solution soon.

Changed in cups (Ubuntu):
status: New → In Progress
Revision history for this message
Andreas Karlson (akarlson) wrote :

Till,
Thanks for the quick reply!

Revision history for this message
Andreas Karlson (akarlson) wrote :

Till,
I have pushed another commit that fixes this regression.
https://github.com/OpenPrinting/cups/issues/934#issuecomment-2047651106

Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

Andreas, thanks a lot for the quick fix!

I have applied it now in Ubuntu's CUPS, version 2.4.7-1.2ubuntu6. Note that the package will probably only land in the distro after the release of 24.04 beta.

Changed in cups (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Andreas Karlson (akarlson) wrote :

Great!
Where did you publish the changes?
I would like to make sure the bug does not reproduce with the new package :)

Revision history for this message
Andreas Karlson (akarlson) wrote :

Till,
Your changed only backported on of the two commits that fix this regression.
The missing commit can be found here: https://github.com/OpenPrinting/cups/pull/935

Changed in cups (Ubuntu):
status: Fix Committed → In Progress
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

https://launchpad.net/ubuntu/+source/cups/2.4.7-1.2ubuntu6 is in noble-proposed claiming to fix this bug.

Comment #6 above says there is a missing patch still.

In any case, doesn't look like there is anything to sponsor here, so unsubscribing ubuntu-sponsors.

Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

Sorry, I completely overlooked that there were 2 fixes. I have applied the patch of PR #935 now, too, and uploaded this as cups 2.4.7-1.2ubuntu7.

Changed in cups (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Andreas Karlson (akarlson) wrote :

Are you sure the changes were uploaded?
I'm having a hard time finding them in https://git.launchpad.net/ubuntu/+source/cups

Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

I have uploaded it, but starting from beta freeze until the final release all uploads have to be approved by the release team. As I have done the upload on Friday late at night (CEST) there was probably nobody of the release team around to pass this upload through. Probably this will happen only on Monday.

Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

My upload got approved now:

https://launchpad.net/ubuntu/+source/cups/2.4.7-1.2ubuntu7

This means that the package is in noble-proposed now. The autopkgtests of the package itself and its dependencies get run on all the 6 supported architectures. When they all pass, the package gets into noble-release, the actual release of Noble.

Revision history for this message
Andreas Karlson (akarlson) wrote :

Great!
I'm unable to reproduce the bug on my machine with the new version (2.4.7-1.2ubuntu7).

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cups - 2.4.7-1.2ubuntu7

---------------
cups (2.4.7-1.2ubuntu7) noble; urgency=low

  * Another fix for crash caused by the fix of the background polling of
    printer capability information in ...ubuntu4. Added also commit 6aeb03b
    from 2.4.x GIT branch to the patch (LP: #2060692, Upstream issue #934,
    pull request #935).

 -- Till Kamppeter <email address hidden> Fri, 12 Apr 2024 22:13:19 +0200

Changed in cups (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.