[SRU] Disable pressure for Precision5680 2nd source touchpad

Bug #2023623 reported by Kai-Chuan Hsieh
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
Undecided
Kai-Chuan Hsieh
libinput (Ubuntu)
Fix Released
High
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Lunar
Fix Released
Undecided
Unassigned

Bug Description

[ Impact ]

 * libinput will detect contact size by pressure if the touchpad report pressure event, and it has threshold need to be tuned, however, the tuning might need be done every time if the touchpad firmware update. To relieve the workload, touchpad vendor decide to disable pressure event for libinput in upstream.

 * It will disable pressure event for i2c touchpad vid 0x06cb pid 0xcfa0

[ Test Plan ]

 * on Dell precision 5680 with touchpad vid:0x06cb pid:0xcfa0

 * check left/right button

 * check 2 fingers scrolling

 * check 1 finger drag and drop

 * check 2 fingers drag and drop

[ Where problems could occur ]

 * The quirk match the PID VID only, it won't impact other touchpad

[ Other Info ]

 * https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/869

tags: added: oem-priority originate-from-2023272 somerville
Changed in oem-priority:
assignee: nobody → Kai-Chuan Hsieh (kchsieh)
Revision history for this message
Kent Lin (kent-jclin) wrote :

@KC,

Touchpad has following test cases:
Manual:
 touchpad/basic certification-status=blocker
 touchpad/palm-rejection certification-status=non-blocker
 touchpad/continuous-move certification-status=blocker
 touchpad/singletouch-selection certification-status=blocker
 touchpad/drag-and-drop certification-status=blocker
 touchpad/multitouch-rightclick certification-status=blocker
 touchpad/multitouch certification-status=blocker

Automated:
 touchpad/detected-as-mouse certification-status=blocker
 touchpad/palm-rejection-firmware-labeling_.* certification-status=non-blocker

Detail of each test case could be found in https://github.com/canonical/checkbox/blob/main/providers/base/units/touchpad/jobs.pxu

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Upload debdiff for jammy

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Upload debdiff for lunar

summary: - Disable pressure for Precision5680 2nd source touchpad
+ [SRU] Disable pressure for Precision5680 2nd source touchpad
Revision history for this message
Sebastien Bacher (seb128) wrote :

The issue is fixed in the mantic libinput version. I've sponsored the fix for the L/J series now

Changed in libinput (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote (last edit ):

Regarding the impact section:

[ Impact ]

 * It will disable pressure event for i2c touchpad vid 0x06cb pid 0xcfa0

You are describing what the update will do, but not why. Why do we need to "disable pressure event" for this device? What's going on? What happens to users of this hardware without this patch?

I also don't see a kinetic upload, can you please clarify that you are skipping kinetic on purpose, and why?

Changed in libinput (Ubuntu Jammy):
status: New → Incomplete
Changed in libinput (Ubuntu Lunar):
status: New → Incomplete
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote (last edit ):

reply #5

Based on Dell schedule, the platform will be launched after kinetic EOL, therefore, I didn't do SRU for kinectic.

About the Impact, I update the description, please help to check if the information is enough.

Thanks,

description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Kai-Chuan, or anyone else affected,

Accepted libinput into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libinput/1.22.1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libinput (Ubuntu Lunar):
status: Incomplete → Fix Committed
tags: added: verification-needed verification-needed-lunar
Changed in libinput (Ubuntu Jammy):
status: Incomplete → Fix Committed
tags: added: verification-needed-jammy
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Kai-Chuan, or anyone else affected,

Accepted libinput into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libinput/1.20.0-1ubuntu0.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (libinput/1.22.1-1ubuntu0.1)

All autopkgtests for the newly accepted libinput (1.22.1-1ubuntu0.1) for lunar have finished running.
The following regressions have been reported in tests triggered by the package:

clutter-1.0/1.26.4+git2779b932+dfsg-4 (armhf)
mutter/44.1-0ubuntu1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/lunar/update_excuses.html#libinput

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Zorro Zhang (zorro-zhang) wrote :

Verified the 1.20.0-1ubuntu0.3 via proposed channel, the new touchpad works after installation.

tags: added: verification-done-jammy
tags: removed: verification-needed-jammy
Revision history for this message
Sebastien Bacher (seb128) wrote :

could you also do the verification on lunar?

tags: added: originate-from-2024428
Sherry (sherrychen)
tags: added: verification-done-lunar
tags: added: verification-done
removed: verification-needed verification-needed-lunar
Revision history for this message
Sherry (sherrychen) wrote :

CID: 202306-31716
SKU: MYBY-DVT2-A01
Ubuntu ver: Lunar

Result:the touchpad is working properly.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libinput - 1.20.0-1ubuntu0.3

---------------
libinput (1.20.0-1ubuntu0.3) jammy; urgency=medium

  * Disable pressure for Precision5680 2nd source touchpad (LP: #2023623)
    - d/p/0001-quirks-Dell-Mayabay-Pressure-Pad.patch

 -- Kai-Chuan Hsieh <email address hidden> Tue, 13 Jun 2023 13:59:01 +0800

Changed in libinput (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for libinput has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libinput - 1.22.1-1ubuntu0.1

---------------
libinput (1.22.1-1ubuntu0.1) lunar; urgency=medium

  * Disable pressure for Precision5680 2nd source touchpad (LP: #2023623)
    - d/p/0001-quirks-Dell-Mayabay-Pressure-Pad.patch

 -- Kai-Chuan Hsieh <email address hidden> Thu, 15 Jun 2023 11:39:41 +0800

Changed in libinput (Ubuntu Lunar):
status: Fix Committed → Fix Released
jeremyszu (os369510)
Changed in oem-priority:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.