Xorg crashed with SIGABRT in xf86ModeVRefresh() from drmmode_output_add_gtf_modes() from drmmode_output_get_modes() from xf86ProbeOutputModes() from xf86InitialConfiguration()

Bug #1999008 reported by errors.ubuntu.com bug bridge
38
This bug affects 3 people
Affects Status Importance Assigned to Milestone
xorg-server (Ubuntu)
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned
Lunar
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
The recent SRU'd patch had a bug in it that caused a crash if xf86ModeVRefresh returned 0. Amend the patch to fix this.

[Test case]
Would need an affected system to test this on, but we haven't been able to reproduce this even on an identical system as on one of the reported errors (XPS 15 9560).

[Where things could go wrong]
This only adds a new check.

--

The Ubuntu Error Tracker has been receiving reports about a problem regarding xorg-server. This problem was most recently seen with package version 2:21.1.4-2ubuntu1.2, the problem page at https://errors.ubuntu.com/problem/67a241f90d338c8f1b9c48466cf1f6121bece6bf contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

summary: - /usr/lib/xorg/Xorg:6:xf86ModeVRefresh:drmmode_output_add_gtf_modes:drmmode_output_get_modes:xf86ProbeOutputModes:xf86InitialConfiguration
+ Xorg crashed with SIGABRT in xf86ModeVRefresh() from
+ drmmode_output_add_gtf_modes() from drmmode_output_get_modes() from
+ xf86ProbeOutputModes() from xf86InitialConfiguration()
Timo Aaltonen (tjaalton)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in xorg-server (Ubuntu Jammy):
status: New → Confirmed
Changed in xorg-server (Ubuntu Kinetic):
status: New → Confirmed
Changed in xorg-server (Ubuntu):
status: New → Confirmed
Revision history for this message
AceLan Kao (acelankao) wrote :

Adopt the fix by Markus on bug 1999852
Verified it on my laptop, it works, and will verify more sku and the target 2.5k panel with 90Hz machines later.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "0001-hw-xfree86-re-calculate-the-clock-and-refresh-rate.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
AceLan Kao (acelankao) wrote :

Add back the check for xf86ModeVRefresh() returns 0, the patch works on my laptop and the target 2.5k 90Hz panel.
Will submit another MR soon.

Revision history for this message
AceLan Kao (acelankao) wrote :
tags: added: regression-update
Revision history for this message
Aurimas Fišeras (aurimas-gmail) wrote :

Verified on Dell Vostro V3750 (LP: #2000775) that with latest 0001-hw-xfree86-re-calculate-the-clock-and-refresh-rate.patch xserver no longer crashes.

Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello errors.ubuntu.com, or anyone else affected,

Accepted xorg-server into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server/2:21.1.4-2ubuntu1.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in xorg-server (Ubuntu Kinetic):
status: Confirmed → Fix Committed
tags: added: verification-needed verification-needed-kinetic
Revision history for this message
Chris Halse Rogers (raof) wrote :

Hello errors.ubuntu.com, or anyone else affected,

Accepted xorg-server into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server/2:21.1.3-2ubuntu2.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in xorg-server (Ubuntu Jammy):
status: Confirmed → Fix Committed
tags: added: verification-needed-jammy
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (xorg-server/2:21.1.3-2ubuntu2.6)

All autopkgtests for the newly accepted xorg-server (2:21.1.3-2ubuntu2.6) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

mutter/42.5-0ubuntu1 (arm64)
imagination/3.6-1build1 (amd64)
soqt/1.6.0+ds1-3 (armhf)
gscan2pdf/2.12.6-1 (amd64)
sasview/5.0.4-1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#xorg-server

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (xorg-server/2:21.1.4-2ubuntu1.4)

All autopkgtests for the newly accepted xorg-server (2:21.1.4-2ubuntu1.4) for kinetic have finished running.
The following regressions have been reported in tests triggered by the package:

libsoup2.4/2.74.3-1 (s390x)
sphinx/4.5.0-4 (armhf)
xcolorsel/1.1a-22 (armhf)
spyder/5.3.2+dfsg-1 (arm64, armhf)
mutter/43.0-1ubuntu4 (amd64, armhf)
aptdaemon/1.1.1+bzr982-0ubuntu39 (amd64, s390x)
jsurf-alggeo/0.4.1+ds-3 (s390x)
openmsx-catapult/18.0-1 (armhf)
pipewalker/0.9.4-6 (armhf)
gtk4/4.8.1+ds-1ubuntu1 (armhf)
notepadqq/2.0.0~beta1-3 (armhf)
xautomation/1.09-4 (armhf)
xautolock/1:2.2-7 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/kinetic/update_excuses.html#xorg-server

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Test on Precision 5750 with jammy.

xorg-server (2:21.1.3-2ubuntu2.5) will gets below error:

Jan 19 09:23:14 u-Precision /usr/libexec/gdm-x-session[2139]: X Error of failed request: BadValue (integer parameter out of range for operation)
Jan 19 09:23:14 u-Precision /usr/libexec/gdm-x-session[2139]: Major opcode of failed request: 140 (RANDR)
Jan 19 09:23:14 u-Precision /usr/libexec/gdm-x-session[2139]: Minor opcode of failed request: 35 (RRSetProviderOutputSource)
Jan 19 09:23:14 u-Precision /usr/libexec/gdm-x-session[2139]: Value in failed request: 0x45
Jan 19 09:23:14 u-Precision /usr/libexec/gdm-x-session[2139]: Serial number of failed request: 16
Jan 19 09:23:14 u-Precision /usr/libexec/gdm-x-session[2139]: Current serial number in output stream: 17

xorg-server (2:21.1.3-2ubuntu2.6), the error didn't occur.

Revision history for this message
AceLan Kao (acelankao) wrote :

xserver-xorg-core 21.1.3-2ubuntu2.5
1. power off the machine
2. connect DP monitor on the dock
3. plug the dock type-c cable to the machine
4. waiting the machine auto bootup, and no output on the DP monitor
5. no external monitor found in display menu

updated xserver-xorg-core to 21.1.3-2ubuntu2.6
1. power off the machine
2. connect DP monitor on the dock
3. plug the dock type-c cable to the machine
4. waiting the machine auto bootup, and no output on the DP monitor
5. found monitor in display menu and win + p toggle display mode work

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
AceLan Kao (acelankao) wrote :

Updated xserver-xorg-core to 21.1.4-2ubuntu1.4(kinetic) with the same test on comment #14, toggle display works

ii xserver-xorg-core 2:21.1.4-2ubuntu1.4 amd64 Xorg X server - core server

tags: added: verification-done verification-done-kinetic
removed: verification-needed verification-needed-kinetic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xorg-server - 2:21.1.6-1ubuntu1

---------------
xorg-server (2:21.1.6-1ubuntu1) lunar; urgency=medium

  * Merge from Debian.
  * re-calculate-the-clock-and-refresh-rate.diff: Replace with a newer
    version.

 -- Timo Aaltonen <email address hidden> Thu, 05 Jan 2023 16:11:27 +0200

Changed in xorg-server (Ubuntu Lunar):
status: Confirmed → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

In Kinetic, there is a DEP8 regression on armhf that was not addressed yet:

autopkgtest for openmsx-catapult/18.0-1: amd64: Pass, arm64: Pass, armhf: Regression ♻ , ppc64el: Pass, s390x: Pass

I see it was retried multiple times, and a migration-reference/0 run passed, so it's indeed a regression with xorg-server/2:21.1.4-2ubuntu1.4. Can someone address it please?

Revision history for this message
Chris Halse Rogers (raof) wrote :

Looks like the DEP8 test is flaky; it has failed with previous non-xorg-server packages as well, and I've just retried it and it has passed.

Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for xorg-server has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xorg-server - 2:21.1.3-2ubuntu2.6

---------------
xorg-server (2:21.1.3-2ubuntu2.6) jammy; urgency=medium

  * re-calculate-the-clock-and-refresh-rate.diff: Import v3, fix a
    crash. (LP: #1999008)

 -- Timo Aaltonen <email address hidden> Wed, 07 Dec 2022 11:32:56 +0200

Changed in xorg-server (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xorg-server - 2:21.1.4-2ubuntu1.4

---------------
xorg-server (2:21.1.4-2ubuntu1.4) kinetic; urgency=medium

  * re-calculate-the-clock-and-refresh-rate.diff: Import v3, fix a
    crash. (LP: #1999008)

 -- Timo Aaltonen <email address hidden> Wed, 07 Dec 2022 11:28:20 +0200

Changed in xorg-server (Ubuntu Kinetic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.