sh: 48: /usr/share/debootstrap/scripts/gutsy: EXTRACTOR_OVERRIDE: parameter not set

Bug #1971951 reported by Benjamin Drung
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
debootstrap (Ubuntu)
Fix Released
Undecided
Unassigned
Jammy
Won't Fix
Undecided
Unassigned
mmdebstrap (Ubuntu)
Won't Fix
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

All users of bdebstrap/mmdebstrap are affected.

[Test Plan]

$ cat test.yaml
---
name: test
mmdebstrap:
  suite: jammy
  target: root.squashfs
  variant: minbase
$ bdebstrap -c test.yaml
I: automatically chosen mode: unshare
I: chroot architecture amd64 is equal to the host's architecture
sh: 48: /usr/share/debootstrap/scripts/gutsy: EXTRACTOR_OVERRIDE: parameter not set
Can't exec "tar2sqfs": No such file or directory at /usr/bin/mmdebstrap line 5178.
E: cannot exec tar2sqfs --version: No such file or directory
E: failed to start tar2sqfs --version
2022-05-06 10:22:50,438 bdebstrap ERROR: mmdebstrap failed with exit code 2. See above for details.

This test shuold produce a root.squashfs without a failure.

[Where problems could occur]
Worst case scenario is that deboostrap breaks, but this one-line fix is so trivial that I fail to come up with possible problem (except for other bugs that only appear when upgrading the package).

Revision history for this message
Benjamin Drung (bdrung) wrote :
Benjamin Drung (bdrung)
Changed in debootstrap (Ubuntu):
status: New → Fix Committed
Revision history for this message
Benjamin Drung (bdrung) wrote :

Attached patch for uploaded jammy SRU.

description: updated
Changed in debootstrap (Ubuntu Jammy):
status: New → Fix Committed
tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package debootstrap - 1.0.127ubuntu1

---------------
debootstrap (1.0.127ubuntu1) kinetic; urgency=medium

  * Fix EXTRACTOR_OVERRIDE: parameter not set (LP: #1971951)
  * Fix failures with "set -u"

 -- Benjamin Drung <email address hidden> Fri, 05 Aug 2022 15:19:50 +0200

Changed in debootstrap (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

While this fix looks appropriate to me for a development release, I don't think for an SRU it makes sense that we should change the debootstrap script to be safe under set -u when debootstrap itself never uses set -u. I think mmdebstrap should set +u before sourcing debootstrap scripts (it can set -u again afterwards) and that this would be a more appropriate change to SRU.

Benjamin Drung (bdrung)
Changed in debootstrap (Ubuntu Jammy):
status: Fix Committed → Won't Fix
Revision history for this message
Benjamin Drung (bdrung) wrote :

Okay. I marked the jammy SRU for debootstrap as won't fix and marked mmdebstrap as affected.

Revision history for this message
Chris Halse Rogers (raof) wrote : Proposed package upload rejected

An upload of debootstrap to jammy-proposed has been rejected from the upload queue for the following reason: "Rejecting as per last comment".

Revision history for this message
Benjamin Drung (bdrung) wrote :

Attached debdiff for jammy SRU for mmdebstrap. I forwarded this fix for mmdebstrap to josch via email.

Revision history for this message
Benjamin Drung (bdrung) wrote :

josch prefers to have deboostrap support "set -eu" instead of mmdebstrap only using "set -e". So marking the bug for mmdebstrap in Ubuntu >= 22.10 (kinetic) as "Won't fix".

Changed in mmdebstrap (Ubuntu):
status: New → Won't Fix
Revision history for this message
Robie Basak (racb) wrote :

Ah, I thought I'd accepted this on my shift yesterday.

Changed in mmdebstrap (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Benjamin, or anyone else affected,

Accepted mmdebstrap into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mmdebstrap/0.8.4-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Benjamin Drung (bdrung) wrote :

Upgraded mmdebstrap and tested "bdebstrap -c test.yaml". It does not print this warning any more.

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for mmdebstrap has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mmdebstrap - 0.8.4-1ubuntu0.1

---------------
mmdebstrap (0.8.4-1ubuntu0.1) jammy; urgency=medium

  * Do not require "set -u" for /usr/share/debootstrap/scripts/gutsy
    (LP: #1971951)

 -- Benjamin Drung <email address hidden> Mon, 12 Sep 2022 10:48:08 +0200

Changed in mmdebstrap (Ubuntu Jammy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.