openafs/1.6.15-1ubuntu1 ADT test failure with linux/4.4.0-207.239

Bug #1922242 reported by Kleber Sacilotto de Souza
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Invalid
Undecided
Unassigned
Xenial
Invalid
Undecided
Unassigned
openafs (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
High
Kleber Sacilotto de Souza

Bug Description

[Impact]
autopkgtest caught a build failure with openafs-modules-dkms with the xenial/linux kernel currently in -proposed (4.4.0-207.239).

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/o/openafs/20210331_082652_48bc3@/log.gz
    armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/armhf/o/openafs/20210331_001828_facc7@/log.gz
    s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/o/openafs/20210331_001310_48c45@/log.gz

Build error:

  CC [M] /var/lib/dkms/openafs/1.6.15/build/src/libafs/MODLOAD-4.4.0-207-generic-SP/osi_file.o
/var/lib/dkms/openafs/1.6.15/build/src/libafs/MODLOAD-4.4.0-207-generic-SP/osi_file.c: In function ‘osi_UFSTruncate’:
/var/lib/dkms/openafs/1.6.15/build/src/libafs/MODLOAD-4.4.0-207-generic-SP/osi_file.c:187:12: error: implicit declaration of function ‘inode_change_ok’ [-Werror=implicit-function-declaration]
     code = inode_change_ok(inode, &newattrs);
            ^
cc1: some warnings being treated as errors

This was caused by commit "fs: Give dentry to inode_change_ok() instead of inode" applied to xenial/linux as part of the fixes for CVE-2015-1350, which renamed inode_change_ok() to setattr_prepare().

[Fix]
The proposed fix is to cherry-pick commit 8aeb711eeaa5ddac5a74c354091e2d4f7ac0cd63 "Linux 4.9: inode_change_ok() becomes setattr_prepare()" from openafs repository (git://git.openafs.org/openafs.git).

[Test]
Install openafs-modules-dkms on a xenial system running an older kernel without the interface change (<4.4.0-207) and with a newer kernel with the interface change (>=4.4.0-207). The openafs module should be built and loaded with all kernels.

[Where problems could occur]
The fix is based on the detection made during build time of the function available on the kernel headers. If the detection doesn't work correctly the build would fail.

Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :
tags: added: kernel-adt-failure
description: updated
description: updated
Changed in linux (Ubuntu):
status: New → Invalid
Changed in linux (Ubuntu Xenial):
status: New → Invalid
Changed in openafs (Ubuntu Xenial):
status: New → Confirmed
importance: Undecided → High
status: Confirmed → Triaged
Changed in openafs (Ubuntu):
status: New → Invalid
Changed in openafs (Ubuntu):
status: Invalid → Fix Released
Changed in openafs (Ubuntu Xenial):
assignee: nobody → Kleber Sacilotto de Souza (kleber-souza)
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :
description: updated
Changed in openafs (Ubuntu Xenial):
status: Triaged → In Progress
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Kleber, or anyone else affected,

Accepted openafs into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/openafs/1.6.15-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in openafs (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

I can confirm that openafs-modules-dkms/1.6.15-1ubuntu1.1 can be built and installed on both older and newer xenial/linux kernels:

$ dkms status
openafs, 1.6.15, 4.4.0-206-generic, x86_64: installed
openafs, 1.6.15, 4.4.0-208-generic, x86_64: installed

autopkgtests were also successful:

* xenial/linux 4.4.0-208.240
  - amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/o/openafs/20210407_161651_8b22b@/log.gz
  - armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/armhf/o/openafs/20210407_163444_963c5@/log.gz
  - i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/i386/o/openafs/20210407_161429_59fe1@/log.gz
  - s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/o/openafs/20210407_161222_963c5@/log.gz

* xenial/linux 4.4.0-206.238:
  - amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/o/openafs/20210407_142619_8fbc1@/log.gz
  - armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/armhf/o/openafs/20210407_142941_8fbc1@/log.gz
  - i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/i386/o/openafs/20210407_142002_8fbc1@/log.gz
  - s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/o/openafs/20210407_142101_8fbc1@/log.gz

Note: arm64 and ppc64el has never passed.

Thanks,
Kleber

tags: added: verification-done-xenial
removed: verification-needed-xenial
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for openafs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package openafs - 1.6.15-1ubuntu1.1

---------------
openafs (1.6.15-1ubuntu1.1) xenial; urgency=medium

  * debian/patches/1002-Linux-4.9-inode_change_ok-becomes-setattr_prepare.patch
   - Linux 4.9: inode_change_ok() becomes setattr_prepare()
     (LP: #1922242)

 -- Kleber Sacilotto de Souza <email address hidden> Thu, 01 Apr 2021 18:20:36 +0200

Changed in openafs (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.