[SRU] Please add Finnish translation for gnome-flashback

Bug #1896885 reported by Timo Jyrinki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-flashback (Ubuntu)
Fix Released
Wishlist
Unassigned
Bionic
Fix Released
Wishlist
Unassigned
Focal
Fix Released
Wishlist
Unassigned

Bug Description

[Impact]

People running GNOME Flashback with fi language have missing very visible strings like "Home" both on the desktop background and in menus.

[Test Case]

Install gnome-panel (which installs gnome-flashback among else), use Finnish for language, check eg desktop and "Järjestelmätyökalut" submenu.

There is eg Home, Administration, Preferences visible. With the fix, those among else are now translated.

[Regression Potential]

Low, it's a no-change rebuild otherwise. I've also checked from build logs that the make update-gmo only creates the gmo file for fi, does not update the upstream shipped ones for others.

---

Please add Finnish translation from upstream.

https://gitlab.gnome.org/GNOME/gnome-flashback/-/commit/5fb1353f5f1eece1bd4ad6bdf37636748793284c.patch

(I'll handle the uploads myself)

Changed in gnome-flashback (Ubuntu Bionic):
importance: Undecided → Wishlist
Changed in gnome-flashback (Ubuntu Focal):
importance: Undecided → Wishlist
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

I will make 3.38.0 and new 3.36.x release when I have time, most likely next week.

For 3.36.x there are other updated translations and also one fix - https://bugs.launchpad.net/bugs/1894213.

Why did you add bionic? That has very old release 3.28...

Changed in gnome-flashback (Ubuntu):
status: New → Fix Committed
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Hi Alberts! Thank you, I just want to make sure these translations get to users as soon as possible, as some new users are starting to use the flashback session. Groovy wouldn't be needed otherwise but the general rule is devel first, so I did an upload there first.

My uploads can be safely simply ignored/overridden when next upstream releases are released and uploaded, and I also made a comment like so in debian/rules where I run update-gmo (that only touches that one new translation).

I'm adding bionic since it's supported until 2023, and I know some people who are likely continuing to use it until then.

Test builds were done at https://launchpad.net/~timo-jyrinki/+archive/ubuntu/yetanotherppa1/+packages and tested from there before uploading.

Changed in gnome-flashback (Ubuntu Bionic):
status: New → Fix Committed
Changed in gnome-flashback (Ubuntu Focal):
status: New → Fix Committed
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Are you using same file from gnome-3-36 branch for master/3.38 and also for 3.28?

https://l10n.gnome.org/vertimus/gnome-flashback/master/po/fi/
https://l10n.gnome.org/vertimus/gnome-flashback/gnome-3-36/po/fi/

It is only 31% translated (for master and gnome-3-36). For gnome-3-28 there is no upstream commit... But with same file for gnome-3-28 it might be less.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-flashback - 3.37.3-1ubuntu2

---------------
gnome-flashback (3.37.3-1ubuntu2) groovy; urgency=medium

  * debian/patches/fi-translation.patch:
    - Add Finnish translation (LP: #1896885)
  * debian/rules:
    - Run update-gmo (only touches fi.gmo)

 -- Timo Jyrinki <email address hidden> Thu, 24 Sep 2020 10:03:20 +0300

Changed in gnome-flashback (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I submitted it to 3-36 and selected a merge to master as well.

I only cared about the important, user visible strings, so I translated until I had translated everything visible in the default UI and then some. For example there are 56 strings that are only in schemas, essentially not seen by any normal user.

For gnome-3-28 there is indeed no upstream commit since I do not have git commit rights to GNOME and l10n.gnome.org does not support targetting that version anymore for extra GNOME applications. I have the 3-28 branch checked out locally but since there is no changes to 3-28 branch since August 2019, I thought not to waste someone's review time over it with the likelihood someone picking it from there being quite low - Debian stable is on 3.30, SUSE is on 3.26/3.34. RHEL7 would be on 3.28 though.

I did test that all the important strings are also correctly translated under 3.28 / Ubuntu 18.04 LTS, it's just as good as 3.36/20.04 in practical use.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Hi Timo!

Can you please add SRU template paperwork to this bug?

I would wait for 3.36.5 release to avoid double load on SRU team (it will also contain the Russian translation I am interested in), but filling the SRU template is needed in any case.

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Thanks!

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Hi Dmitry! Yes, thanks, I just came back here simply because I realized the same that I'm missing the SRU paperwork.

summary: - Please add Finnish translation for gnome-flashback
+ [SRU] Please add Finnish translation for gnome-flashback
description: updated
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

This is currently 3.36.4-0ubuntu1.1 in focal queue and 3.28.0-1ubuntu1.5 in bionic queue.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Timo, or anyone else affected,

Accepted gnome-flashback into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-flashback/3.36.4-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-focal
tags: added: verification-needed-bionic
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Timo, or anyone else affected,

Accepted gnome-flashback into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-flashback/3.28.0-1ubuntu1.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Everything seems to work as planned on both bionic and focal using the proposed builds, see screenshot.

tags: added: verification-done verification-done-bionic verification-done-focal
removed: verification-needed verification-needed-bionic verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-flashback - 3.28.0-1ubuntu1.5

---------------
gnome-flashback (3.28.0-1ubuntu1.5) bionic; urgency=medium

  * debian/patches/fi-translation.patch:
    - Add Finnish translation (LP: #1896885)
  * debian/rules:
    - Run update-gmo (only touches fi.gmo)

 -- Timo Jyrinki <email address hidden> Thu, 24 Sep 2020 10:36:02 +0300

Changed in gnome-flashback (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-flashback has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-flashback - 3.36.4-0ubuntu1.1

---------------
gnome-flashback (3.36.4-0ubuntu1.1) focal; urgency=medium

  * debian/patches/fi-translation.patch:
    - Add Finnish translation (LP: #1896885)
  * debian/rules:
    - Run update-gmo (only touches fi.gmo)

 -- Timo Jyrinki <email address hidden> Thu, 24 Sep 2020 10:01:09 +0300

Changed in gnome-flashback (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.