Ubuntu
rtl8821ce package

rtl8821ce 5.5.2.1-0ubuntu3 ADT test failure with linux-5.8 5.8.0-1.2

Bug #1884648 reported by Seth Forshee on 2020-06-22

This bug affects 6 people

	Status	Importance	Assigned to
HWE Next	Fix Released	High	Unassigned
rtl8821ce (Ubuntu)	Fix Released	High	You-Sheng Yang
Focal	Fix Released	High	You-Sheng Yang
Groovy	Fix Released	High	You-Sheng Yang

Bug Description

[SRU Justification]

[Impact]
rtl9921ce-dkms may fail to compile dkms modules on devices with v5.5 kernel or newer due to kernel data structure changes.

[Fix]
Following changes required with modifications to fix such errors:
* commit ff74b75511c5 ("convert file_operations structs to proc_ops structs for compatibility with linux 5.6") from https://github.com/tomaspinho/rtl8821ce .
* commit 5e7d1302d3c4 (".mgmt_frame_register -> .update_mgmt_frame_registrations") from https://github.com/tomaspinho/rtl8821ce .
* Additional fix to "core/rtw_security.c" for v5.8 kernels.

[Test Case]
Verified with kernels:
* 5.4.0-26-generic
* 5.6.0-1010-oem
* 5.7.0-9-generic
* 5.8.0-1-generic

[Regression Potential]
Low. The patches are to adopt new interface changes when compiled against new kernels. For existing users with older kernels, they're not affected. For those with new kernels they're still fine as that's what new kernels do.

========== Original Bug Description ==========

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy-canonical-kernel-team-bootstrap/groovy/amd64/r/rtl8821ce/20200619_205745_0b364@/log.gz
    arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy-canonical-kernel-team-bootstrap/groovy/arm64/r/rtl8821ce/20200619_213437_0716f@/log.gz
    armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy-canonical-kernel-team-bootstrap/groovy/armhf/r/rtl8821ce/20200619_212413_7d687@/log.gz
    ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy-canonical-kernel-team-bootstrap/groovy/ppc64el/r/rtl8821ce/20200619_205635_5dd77@/log.gz
    s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy-canonical-kernel-team-bootstrap/groovy/s390x/r/rtl8821ce/20200619_210358_a1fbc@/log.gz

See original description

Tags:

Related branches

~vicamo/ubuntu/+source/rtl8821ce-dkms/+git/rtl8821ce-dkms:bug-1884648/fix-build-failure-against-latest-kernel/focal

Merged into ~canonical-hwe-team/ubuntu/+source/rtl8821ce-dkms/+git/rtl8821ce-dkms:ubuntu/focal at revision c6ed8683193007ba952f800c4239dca9d24717fb

Timo Aaltonen: Approve on 2020-07-28

~vicamo/ubuntu/+source/rtl8821ce-dkms/+git/rtl8821ce-dkms:bug-1884648/fix-build-failure-against-latest-kernel/groovy

Merged into ~canonical-hwe-team/ubuntu/+source/rtl8821ce-dkms/+git/rtl8821ce-dkms:ubuntu/groovy at revision 6f6a173d8d410afe4ec2eb10842c622fadd1eeb8

You-Sheng Yang: Approve on 2020-07-24

Revision history for this message

Seth Forshee (sforshee) wrote on 2020-06-22:

make.log (5.8.0-1-generic) Edit (1.6 KiB, text/plain)

tags:

added: kernel-adt-failure

Revision history for this message

Launchpad Janitor (janitor) wrote on 2020-07-03:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in rtl8821ce (Ubuntu):
status:	New → Confirmed

You-Sheng Yang (vicamo) on 2020-07-03

Changed in rtl8821ce (Ubuntu):
assignee:	nobody → You-Sheng Yang (vicamo)
status:	Confirmed → In Progress
tags:	added: hwe-networking-wifi

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2020-07-03:

Add Focal as it also fails to compile against oem-5.6.

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2020-07-03:

make.log (5.6.0-1010-oem) Edit (14.0 KiB, text/plain)

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2020-07-03:

make.log (5.7.0-9-generic) Edit (13.7 KiB, text/plain)

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2020-07-03:

PPA https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1884648

tags:

added: oem-priority originate-from-1886147 stella

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2020-07-03:

Need review & sponsor for the fix. Tested:
* groovy:
  - 5.4.0-26-generic
  - 5.6.0-1010-oem
  - 5.7.0-9-generic
  - 5.8.0-1-generic
* focal:
  - 5.4.0-37-generic
  - 5.6.0-1010-oem
* eoan:
  - 5.3.0-62-generic
* bionic:
  - 4.15.0-109-generic
  - 4.15.0-1091-oem
  - 4.18.0-25-generic
  - 5.0.0-1063-oem-osp1
  - 5.0.0-53-generic
  - 5.3.0-62-generic
  - 5.4.0-40-generic

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2020-07-10:

Need review and upload to Groovy.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2020-07-22:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in rtl8821ce (Ubuntu Focal):
status:	New → Confirmed

Revision history for this message

Chih-Hsyuan Ho (chih) wrote on 2020-07-22:

#10

@Seth, can you also help review it and upload it to Focal at your earliest convenience please? We have a couple of OEM platforms whose GM image release are depending on this fix. Thank you in advance.

Anthony Wong (anthonywong) on 2020-07-22

tags:

added: rls-ff-incoming

Anthony Wong (anthonywong) on 2020-07-22

Changed in rtl8821ce (Ubuntu Focal):
assignee:	nobody → You-Sheng Yang (vicamo)

Revision history for this message

Seth Forshee (sforshee) wrote on 2020-07-22: Re: [Bug 1884648] Re: rtl8821ce 5.5.2.1-0ubuntu3 ADT test failure with linux-5.8 5.8.0-1.2

#11

On Wed, Jul 22, 2020 at 09:53:34AM -0000, Chih-Hsyuan Ho wrote:
> @Seth, can you also help review it and upload it to Focal at your
> earliest convenience please? We have a couple of OEM platforms whose GM
> image release are depending on this fix. Thank you in advance.

I don't have rights to upload this package, sorry.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2020-07-22:

#12

This bug was fixed in the package rtl8821ce - 5.5.2.1-0ubuntu4

---------------
rtl8821ce (5.5.2.1-0ubuntu4) groovy; urgency=medium

  * Reconcile with debian/sid.
    - migrate to debhelper compatible level 12.
    - address lintian warnings
    - enable GitLab CI
    - enable autopkgtest

* Fix build against v5.8 kernel (LP: #1884648)

* Add missing supplier data rates (22, 33MB) (LP: #1865147)

-- You-Sheng Yang <email address hidden> Fri, 03 Jul 2020 15:43:11 +0800

Changed in rtl8821ce (Ubuntu Groovy):
status:	In Progress → Fix Released

Anthony Wong (anthonywong) on 2020-07-23

Changed in rtl8821ce (Ubuntu Focal):
importance:	Undecided → High
Changed in hwe-next:
importance:	Undecided → High

You-Sheng Yang (vicamo) on 2020-07-24

Changed in rtl8821ce (Ubuntu Focal):
status:	Confirmed → In Progress

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2020-07-24:

#13

For Focal:
* https://code.launchpad.net/~vicamo/ubuntu/+source/rtl8821ce-dkms/+git/rtl8821ce-dkms/+merge/388031
* https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1884648 version 5.5.2.1-0ubuntu4~20.04.2

You-Sheng Yang (vicamo) on 2020-07-24

description:

updated

Mathew Hodson (mhodson) on 2020-07-30

Changed in rtl8821ce (Ubuntu Groovy):
importance:	Undecided → High

Revision history for this message

Chih-Hsyuan Ho (chih) wrote on 2020-08-05:

#14

@Mathew, can we get your help to review the fix in Focal and get it to land on updates as soon as possible please? We have multiple OEM platforms whose GM release schedule is urgently relying on it. Thank you in advance.

Revision history for this message

Chris Halse Rogers (raof) wrote on 2020-08-06: Please test proposed package

#15

Hello Seth, or anyone else affected,

Accepted rtl8821ce into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/rtl8821ce/5.5.2.1-0ubuntu4~20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in rtl8821ce (Ubuntu Focal):
status:	In Progress → Fix Committed
tags:	added: verification-needed verification-needed-focal

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2020-08-07:

#16

Verified 5.5.2.1-0ubuntu4~20.04.2 from focal-proposed against kernel 5.4.0-42-generic and 5.6.0-1020-oem.

tags:

added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal

Revision history for this message

Chih-Hsyuan Ho (chih) wrote on 2020-08-17:

#17

@vicamo, as of 8/17, the 5.5.2.1-0ubuntu4~20.04.2 still seems to be in -proposed, can you help check what's holding it please? Thanks.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2020-08-17:

#18

This bug was fixed in the package rtl8821ce - 5.5.2.1-0ubuntu4~20.04.2

---------------
rtl8821ce (5.5.2.1-0ubuntu4~20.04.2) focal; urgency=medium

* Fix build against v5.8 kernel (LP: #1884648)

* Add missing supplier data rates (22, 33MB) (LP: #1865147)

-- You-Sheng Yang <email address hidden> Fri, 24 Jul 2020 13:46:53 +0800

Changed in rtl8821ce (Ubuntu Focal):
status:	Fix Committed → Fix Released

Revision history for this message

Timo Aaltonen (tjaalton) wrote on 2020-08-17: Update Released

#19

The verification of the Stable Release Update for rtl8821ce has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Anthony Wong (anthonywong) on 2020-08-17

Changed in hwe-next:
status:	New → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubunturtl8821ce package

rtl8821ce 5.5.2.1-0ubuntu3 ADT test failure with linux-5.8 5.8.0-1.2

Bug Description

Related branches

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
rtl8821ce package