[SRU] nodejs should use openssl1.0 in testing as well

Bug #1798367 reported by Dimitri John Ledkov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nodejs (Ubuntu)
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
Unassigned

Bug Description

[SRU] nodejs should use openssl1.0 in testing as well

Previous SRU in #1779863 reverted to using openssl1.0 for the runtime, but it should also use openssl1.0 in test.

This allows to execute more test cases and is future-proof against using tls1.3 capable openssl 1.1.1 by accident which test-suites do not assert against correctly.

[Impact]

 * Incomplete test-suite executed at build-time and autopkgtest time, due to openssl -> openssl1.0 revert not applied to testing either.
 * Future-proofs test-suite assertions against openssl upgrade to 1.1.1 series
 * Partial backport of https://launchpad.net/ubuntu/+source/nodejs/8.11.4~dfsg-0ubuntu1

[Test Case]

 * unit-tests pass
 * autopkgtests pass

[Regression Potential]

 * Test infra changes only

Changed in nodejs (Ubuntu):
status: New → Fix Released
Changed in nodejs (Ubuntu Bionic):
status: New → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dimitri, or anyone else affected,

Accepted nodejs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nodejs/8.10.0~dfsg-2ubuntu0.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in nodejs (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

nodejs autopkgtests now pass, with the extra enabled tests also passing.

there are minimal amount of node packages "regressions" in reverse deps triggered, which do not show any grave problems with interpreter itself and are good to skiptest/release this sru, as was done with nodejs uploads during release time as well.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nodejs - 8.10.0~dfsg-2ubuntu0.4

---------------
nodejs (8.10.0~dfsg-2ubuntu0.4) bionic; urgency=medium

  * Use openssl1.0 client binary in tests LP: #1798367
    - resurrect fix_sslv3_test.patch
    - revert s_client_tls12.patch, as not needed with old ssl
    - reenable-more-tests.patch - reenable openssl1.0 and zlib tests, they
      should work

 -- Dimitri John Ledkov <email address hidden> Wed, 17 Oct 2018 13:21:44 +0100

Changed in nodejs (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for nodejs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Robie Basak (racb)
tags: added: bionic-openssl-1.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.