Ubuntu
meld package

Tabs don't close after saving changes

Bug #1768369 reported by Trucoto
60
This bug affects 13 people
Affects Status Importance Assigned to Milestone
meld (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

It began to fail after updating to Ubuntu 18.04. This reproduces the bug on my side:

1) Edit p1.cc with the following text: "hello, world" (no quotes)
2) Edit p2.cc with the following text: "hello,world" (no quotes)
3) Meld them
4) Correct p2.cc with p1.cc's contents.
5) Control+W to close tab, it appears the "Save" dialog, save the changes

I expected the tab to be closed after saving, as usual, but the tab was not closed, and cannot be closed afterwards neither with Control+W nor closing the tab with the mouse. On console I have:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/meld/meldwindow.py", line 436, in on_menu_close_activate
    page.on_delete_event()
  File "/usr/lib/python3/dist-packages/meld/filediff.py", line 842, in on_delete_event
    del self._cached_match
AttributeError: _cached_match

Eventually tabs pile up and cannot be closed, except by closing Meld.

$ lsb_release -rd
Description: Ubuntu 18.04 LTS
Release: 18.04

$ apt-cache policy meld
meld:
  Installed: 3.18.0-6
  Candidate: 3.18.0-6
  Version table:
 *** 3.18.0-6 500
        500 http://archive.ubuntu.com/ubuntu bionic/universe amd64 Packages
        500 http://archive.ubuntu.com/ubuntu bionic/universe i386 Packages
        100 /var/lib/dpkg/status

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in meld (Ubuntu):
status: New → Confirmed
Revision history for this message
Leon (lehjr) wrote :

tried with commit f5363fedb216180a1dc054bac4e4155a657737b9 (displays as version 3.19.1) and it works, but you may get GTK theme warning spam.

2018-06-13 12:54:18,715 WARNING Gtk:
(meld:9398): Gtk-WARNING **: 12:54:18.715: Theme parsing error: gtk.css:68:35: The style property GtkButton:child-displacement-x is deprecated and shouldn't be used anymore. It will be removed in a future version
2018-06-13 12:54:18,715 WARNING Gtk:
(meld:9398): Gtk-WARNING **: 12:54:18.715: Theme parsing error: gtk.css:69:35: The style property GtkButton:child-displacement-y is deprecated and shouldn't be used anymore. It will be removed in a future version
2018-06-13 12:54:18,715 WARNING Gtk:
(meld:9398): Gtk-WARNING **: 12:54:18.715: Theme parsing error: gtk.css:73:46: The style property GtkScrolledWindow:scrollbars-within-bevel is deprecated and shouldn't be used anymore. It will be removed in a future version

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package meld - 3.18.2-1

---------------
meld (3.18.2-1) unstable; urgency=medium

  * New upstream release (Closes: #901593) (LP: #1768369)
   - Fix incorrect state handling during tab close (Kai Willadsen)
   - Fix commit action on a folder not working in git (Kai Willadsen)
   - The Find bar now hides when pressing Escape (Vladimir Panteleev)
   - Translation and help fixes (Piotr Drąg)
   - Handle subprocess termination better in file comparisons (Kai Willadsen)
   - Fix committing selected files only in Mercurial (Kai Willadsen)
   - Fix Bazaar version control backend (Kai Willadsen)
  * Refresh patches

 -- Balint Reczey <email address hidden> Tue, 19 Jun 2018 23:30:39 +0200

Changed in meld (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Alexis Wilke (alexis-m2osw) wrote :

For those interested in 18.04, the file to replace is:

/usr/lib/python3/dist-packages/meld/filediff.py

and you can replace it with the version:

https://gitlab.gnome.org/GNOME/meld/-/blob/3.18.2/meld/filediff.py

Then saving when closing the tab works as expected.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.