Ubuntu
lmms package

Trusty LMMS version is based off wrong branch

Bug #1335542 reported by Israel Dahl
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
lmms (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Fix Released
Undecided
Unassigned

Bug Description

This current version has some serious issue since it was based off of the Master branch rather than the Stable branch.
The problems relate to unstable plugins, and features that were not ready for production.
Since Tursty is an LTS, only stable mature software should be in the repos.

These problems effect users in unpredictable ways that can lead to loss of user data which could be a potential security risk.

please fix this

[Impact]
Users of the Trusty version currently have half implemented features, and some that are broken. The Stable branch fixes those problems and protects the users from unexplained data loss. The Stable branch is the proper implementation of key features (like the Mixer), rather than the current unstable version

[Test Case]
Open LMMS look at the mixer. It is missing all the channels. This is a serious regression. Wattsyn is also an incomplete Synth, with many unpredictable results.

[Regression Potential]
Since there are half finished features in the Trusty version users that have not experienced any serious issues may have song files that wont work with the Stable version. However, backporting the version in Utopic would fix this issue, as it is version 1.0.1, which fixes those issues.

See original description

Related branches

lp:~timo-jyrinki/ubuntu/trusty/lmms/lmms_1.0.0+stable_uploaded
Ubuntu branches: Pending requested
Diff: 23162 lines (+4050/-16630)
110 files modified
.gitattributes (+0/-2)
.gitignore (+0/-5)
.mailmap (+0/-11)
.pc/Fix-broken-command-line-rendering.-Should-always-che.patch/src/tracks/pattern.cpp (+0/-1163)
.pc/applied-patches (+0/-2)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/caps/interface.cc (+0/-145)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_autopan.c (+0/-361)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_chorusflanger.c (+0/-595)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_deesser.c (+0/-491)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_doubler.c (+0/-737)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_dynamics_m.c (+0/-666)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_dynamics_st.c (+0/-877)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_echo.c (+0/-629)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_eq.c (+0/-777)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_eqbw.c (+0/-967)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_limiter.c (+0/-443)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_pinknoise.c (+0/-345)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_pitch.c (+0/-556)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_reflector.c (+0/-500)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_reverb.c (+0/-835)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_rotspeak.c (+0/-768)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_sigmoid.c (+0/-338)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_tremolo.c (+0/-343)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_tubewarmth.c (+0/-491)
.pc/fix-crash-on-close.patch/plugins/LadspaEffect/tap/tap_vibrato.c (+0/-445)
.svnignore (+0/-6)
.travis.yml (+0/-6)
README.md (+0/-37)
data/presets/Watsyn/Epic_lead.xpf (+0/-48)
data/presets/Watsyn/Phase_bass.xpf (+0/-21)
data/themes/default/style.css (+2/-38)
debian/changelog (+14/-0)
doc/Doxyfile (+2311/-0)
include/AudioPort.h (+2/-9)
include/AutomatableModel.h (+9/-0)
include/AutomationPattern.h (+0/-1)
include/ComboBoxModel.h (+21/-21)
include/FxLine.h (+0/-66)
include/FxMixer.h (+39/-89)
include/FxMixerView.h (+22/-54)
include/JournallingObject.h (+99/-10)
include/MixerWorkerThread.h (+0/-118)
include/NotePlayHandle.h (+26/-21)
include/PlayHandle.h (+1/-14)
include/ProjectJournal.h (+12/-18)
include/SendButtonIndicator.h (+0/-32)
include/ThreadableJob.h (+0/-84)
include/TrackContainerView.h (+3/-0)
include/mmp.h (+113/-0)
include/note.h (+14/-1)
include/track.h (+16/-0)
plugins/CMakeLists.txt (+0/-1)
plugins/LadspaEffect/calf/CMakeLists.txt (+2/-2)
plugins/LadspaEffect/calf/src/calf/buffer.h (+1/-1)
plugins/LadspaEffect/calf/src/calf/fixed_point.h (+4/-4)
plugins/LadspaEffect/caps/interface.cc (+2/-2)
plugins/LadspaEffect/tap/tap_autopan.c (+4/-4)
plugins/LadspaEffect/tap/tap_chorusflanger.c (+4/-4)
plugins/LadspaEffect/tap/tap_deesser.c (+4/-4)
plugins/LadspaEffect/tap/tap_doubler.c (+4/-4)
plugins/LadspaEffect/tap/tap_dynamics_m.c (+4/-4)
plugins/LadspaEffect/tap/tap_dynamics_st.c (+4/-4)
plugins/LadspaEffect/tap/tap_echo.c (+4/-4)
plugins/LadspaEffect/tap/tap_eq.c (+2/-2)
plugins/LadspaEffect/tap/tap_eqbw.c (+2/-2)
plugins/LadspaEffect/tap/tap_limiter.c (+4/-4)
plugins/LadspaEffect/tap/tap_pinknoise.c (+4/-4)
plugins/LadspaEffect/tap/tap_pitch.c (+4/-4)
plugins/LadspaEffect/tap/tap_reflector.c (+4/-4)
plugins/LadspaEffect/tap/tap_reverb.c (+4/-4)
plugins/LadspaEffect/tap/tap_rotspeak.c (+4/-4)
plugins/LadspaEffect/tap/tap_sigmoid.c (+4/-4)
plugins/LadspaEffect/tap/tap_tremolo.c (+4/-4)
plugins/LadspaEffect/tap/tap_tubewarmth.c (+4/-4)
plugins/LadspaEffect/tap/tap_vibrato.c (+4/-4)
plugins/flp_import/FlpImport.cpp (+8/-16)
plugins/lb302/lb302.cpp (+1/-1)
plugins/vst_base/VstPlugin.h (+0/-1)
plugins/watsyn/CMakeLists.txt (+0/-3)
plugins/watsyn/Watsyn.cpp (+0/-1242)
plugins/watsyn/Watsyn.h (+0/-351)
plugins/zynaddsubfx/zynaddsubfx.rc (+26/-0)
src/core/AutomatableModel.cpp (+49/-3)
src/core/ComboBoxModel.cpp (+9/-10)
src/core/FxMixer.cpp (+126/-497)
src/core/InstrumentFunctions.cpp (+76/-39)
src/core/JournallingObject.cpp (+115/-18)
src/core/Mixer.cpp (+235/-12)
src/core/MixerWorkerThread.cpp (+0/-165)
src/core/NotePlayHandle.cpp (+37/-15)
src/core/ProjectJournal.cpp (+55/-52)
src/core/TrackContainer.cpp (+1/-9)
src/core/audio/AudioPort.cpp (+1/-12)
src/core/note.cpp (+49/-5)
src/core/song.cpp (+0/-5)
src/core/timeline.cpp (+0/-4)
src/core/track.cpp (+172/-6)
src/gui/FxMixerView.cpp (+207/-323)
src/gui/MainWindow.cpp (+2/-2)
src/gui/PianoRoll.cpp (+4/-26)
src/gui/TrackContainerView.cpp (+69/-2)
src/gui/widgets/FxLine.cpp (+0/-163)
src/gui/widgets/LcdSpinBox.cpp (+2/-8)
src/gui/widgets/SendButtonIndicator.cpp (+0/-53)
src/gui/widgets/graph.cpp (+1/-5)
src/gui/widgets/knob.cpp (+3/-15)
src/tracks/InstrumentTrack.cpp (+16/-14)
src/tracks/pattern.cpp (+1/-1)
tests/README (+0/-5)
tests/emptyproject.mmp (+0/-279)
lp:ubuntu/trusty-proposed/lmms
Israel Dahl (israeldahl)
information type: Private Security → Public
Israel Dahl (israeldahl)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in lmms (Ubuntu):
status: New → Confirmed
Timo Jyrinki (timo-jyrinki)
Changed in lmms (Ubuntu Trusty):
status: New → Confirmed
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Israel, or anyone else affected,

Accepted lmms into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lmms/1.0.0+stable-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in lmms (Ubuntu):
status: Confirmed → Fix Released
Changed in lmms (Ubuntu Trusty):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Israel Dahl (israeldahl) wrote :

I just tested it! Thank you so much, this fixes the issue!
The mixer looks normal, there are no unstable plugins.
As a side note, I have tested this branch in a PPA previously, and generally have been recommending Ubuntu users to use that PPA.
This will be a huge improvement! Thanks again for your help in fixing this issue!

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

As per previous comment, adding the 'verification-done' tag.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Sebastien Bacher (seb128) wrote :

seems like that got uploaded, unsubscribing sponsors

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lmms - 1.0.0+stable-0ubuntu1

---------------
lmms (1.0.0+stable-0ubuntu1) trusty; urgency=medium

  [ Israel Dahl ]
  * Stable release instead of erronous master snapshot (LP: #1335542)
  * Backport two patches from stable branch:
    - fix-crash-on-close.patch
    - Fix-broken-command-line-rendering.-Should-always-che.patch

  [ Timo Jyrinki ]
  * Exact matching of the upstream tarball - auxiliary files and apply
    patches only during the build.
 -- Israel Dahl <email address hidden> Sun, 29 Jun 2014 00:38:41 -0500

Changed in lmms (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for lmms has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.