bzr verify-signature fails when acceptable_keys is defined

Reproduced.

It seems that setting 'acceptable_keys' in bazaar.conf is not supported. At least the simple test I'm adding confirms this.

So the workaround is to not set it in bazaar.conf but use the command-line option :-/

Seems to be to do with the following in set_acceptable_keys():

        try:
            if isinstance(acceptable_keys_config, unicode):
                acceptable_keys_config = str(acceptable_keys_config)
        except UnicodeEncodeError:
            # gpg Context.keylist(pattern) does not like unicode
            raise errors.BzrCommandError(
                gettext('Only ASCII permitted in option names'))

The acceptable_keys config is read in as a list, and that bit of code in try doesn't seem to be running to convert it to a string.

In addition, given the way it's implemented, 'acceptable_keys' can be specified in any of branch.conf, locations.conf and bazaar.conf. Same bug and same workaround,

I have a fix in progress.

That fix hasn't made it into to trusty yet, I'm setting a milestone for trusty-updates.

This bug was fixed in the package bzr - 2.6.0+bzr6595-1ubuntu1

---------------
bzr (2.6.0+bzr6595-1ubuntu1) utopic; urgency=low

  * Merge from Debian unstable. Remaining changes:
    - Drop non-main build dependencies on python-{meliae,lzma,medusa}

bzr (2.6.0+bzr6595-1) unstable; urgency=medium

  [ Jelmer Vernooij ]
  * Re-add myself to uploaders.
  * Don't pass blob to file.writelines(), but rather to file.write().
    Closes: #722091

  [ Dimitri John Ledkov ]
  * New upstream snapshot:
    - verify-signature crashes on non ascii characters (LP: #1123460)
    - verify-signature crashes when acceptable_keys is defined (LP:
    #1249732)
 -- Dimitri John Ledkov <email address hidden> Fri, 02 May 2014 14:18:01 +0100

Hello Haw, or anyone else affected,

Accepted bzr into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/bzr/2.6.0+bzr6593-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hi,

I've upgraded to the latest in trusty-proposed and have verified that this is indeed fixed.

hloeung@ragnar:~/Downloads$ apt-cache policy bzr
bzr:
  Installed: 2.6.0+bzr6593-1ubuntu1.1
  Candidate: 2.6.0+bzr6593-1ubuntu1.1
  Version table:
 *** 2.6.0+bzr6593-1ubuntu1.1 0
        100 /var/lib/dpkg/status
     2.6.0+bzr6593-1ubuntu1 0
        500 http://archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages

hloeung@ragnar:~/Downloads$ apt-cache policy python-bzrlib
python-bzrlib:
  Installed: 2.6.0+bzr6593-1ubuntu1.1
  Candidate: 2.6.0+bzr6593-1ubuntu1.1
  Version table:
 *** 2.6.0+bzr6593-1ubuntu1.1 0
        100 /var/lib/dpkg/status
     2.6.0+bzr6593-1ubuntu1 0
        500 http://archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages

hloeung@ragnar:~/test$ bzr verify-signatures
1 commits with valid signatures
0 commits with key now expired
0 commits with unknown keys
0 commits not valid
1 commit not signed

This bug was fixed in the package bzr - 2.6.0+bzr6593-1ubuntu1.1

---------------
bzr (2.6.0+bzr6593-1ubuntu1.1) trusty; urgency=medium

  * Fix verify-signature command crashing:
    - on non ascii characters (LP: #1123460)
    - when acceptable_keys configuration option is specified (LP: #1249732)
 -- Dimitri John Ledkov <email address hidden> Fri, 09 May 2014 03:48:24 +0100

The verification of the Stable Release Update for bzr has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.