Ubuntu
friends package

[FFe] replace gwibber-service with Friends

Bug #1156979 reported by Ken VanDine
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
libunity
Fix Released
Undecided
Unassigned
friends (Ubuntu)
Fix Released
Medium
Unassigned
gwibber (Ubuntu)
Fix Released
Medium
Unassigned
libfriends (Ubuntu)
Fix Released
Medium
Unassigned
libunity (Ubuntu)
Fix Released
Undecided
Unassigned
qml-friends (Ubuntu)
Fix Released
Medium
Unassigned
unity-lens-friends (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

During the Quantal cycle, in an effort to port gwibber-service from python2 to python3 we determined it would be better to just rewrite it to make it more robust and testable.

That has been rewritten under the "friends" package, it is very well tested and we should utilize that for raring. The old codebase brings with it lots of baggage, from bugs to code that is hard to test. The new codebase has an extensive test suite.

Related branches

lp:~super-friends/friends/raring
PS Jenkins bot (community): Approve (continuous-integration)
Ken VanDine: Approve
Diff: 3182 lines (+1267/-632)
34 files modified
debian/changelog (+18/-0)
debian/friends-dispatcher.install (+3/-0)
debian/rules (+4/-1)
friends/main.py (+9/-8)
friends/protocols/facebook.py (+47/-20)
friends/protocols/flickr.py (+5/-2)
friends/protocols/foursquare.py (+6/-1)
friends/protocols/twitter.py (+7/-3)
friends/service/dispatcher.py (+58/-8)
friends/tests/data/facebook-full.dat (+366/-1)
friends/tests/data/flickr-full.dat (+13/-1)
friends/tests/mocks.py (+50/-2)
friends/tests/test_account.py (+3/-62)
friends/tests/test_cache.py (+0/-4)
friends/tests/test_dispatcher.py (+75/-10)
friends/tests/test_facebook.py (+153/-72)
friends/tests/test_flickr.py (+59/-76)
friends/tests/test_foursquare.py (+7/-15)
friends/tests/test_identica.py (+2/-10)
friends/tests/test_mock_dispatcher.py (+0/-2)
friends/tests/test_model.py (+11/-2)
friends/tests/test_notify.py (+1/-14)
friends/tests/test_protocols.py (+154/-79)
friends/tests/test_shortener.py (+0/-2)
friends/tests/test_twitter.py (+52/-32)
friends/utils/account.py (+3/-23)
friends/utils/authentication.py (+6/-1)
friends/utils/base.py (+97/-143)
friends/utils/model.py (+9/-20)
service/configure.ac (+1/-0)
service/src/Makefile.am (+3/-2)
service/src/service.vala (+43/-15)
setup.py (+1/-0)
tools/debug_live.py (+1/-1)
lp:ubuntu/raring-proposed/friends
lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu.raring
lp:~mterry/libunity/lens-friends
PS Jenkins bot (community): Approve (continuous-integration)
Didier Roche-Tolomelli: Approve
Diff: 10 lines (+1/-0)
1 file modified
data/client-scopes.json (+1/-0)
lp:friends-app
lp:ubuntu/raring-proposed/gwibber
Ken VanDine (ken-vandine)
Changed in friends (Ubuntu):
importance: Undecided → Medium
Changed in gwibber (Ubuntu):
importance: Undecided → Medium
Changed in libfriends (Ubuntu):
importance: Undecided → Medium
Changed in qml-friends (Ubuntu):
importance: Undecided → Medium
Changed in unity-lens-friends (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in friends (Ubuntu):
status: New → Confirmed
Changed in gwibber (Ubuntu):
status: New → Confirmed
Changed in libfriends (Ubuntu):
status: New → Confirmed
Changed in qml-friends (Ubuntu):
status: New → Confirmed
Changed in unity-lens-friends (Ubuntu):
status: New → Confirmed
Revision history for this message
Iain Lane (laney) wrote :

Why did this miss Feature Freeze?

Can you outline how this would land? Uploading ppa:super-friends/ppa to Ubuntu? Any chances to other packages / seeds?

What if it goes badly - how could we revert?

Is this linked to your other FFes or is it independent?

Revision history for this message
Ken VanDine (ken-vandine) wrote :

It missed because it was lower priority than some other work.

Landing would be uploading friends, libfriends, unity-lens-friends, qml-friends and gwibber. Most of which would depend on MIRs too, which I wanted to get the FFe approved before requesting.

Reverting would mean changing the desktop seed back from friends to gwibber-service and tweaking the gwibber version number and uploading what is currently in the 3.6 branch.

This does depend on the FFe in bug 1156941 as well as bug 1157191, both of which are very low risk.

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 1156979] Re: [FFe] replace gwibber-service with Friends

Since the new Unity stack is sabdfl'ed into raring, you might as well do this
too then.

Iain Lane (laney)
Changed in unity-lens-friends (Ubuntu):
status: Confirmed → Triaged
Changed in qml-friends (Ubuntu):
status: Confirmed → Triaged
Changed in libfriends (Ubuntu):
status: Confirmed → Triaged
Changed in gwibber (Ubuntu):
status: Confirmed → Triaged
Changed in friends (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package friends - 0.1.3daily13.03.20-0ubuntu1

---------------
friends (0.1.3daily13.03.20-0ubuntu1) raring; urgency=low

  [ Robert Bruce Park ]
  * Keep the Dispatcher alive for 30s beyond the return of the final
    method invocation.
  * Stop deduplicating messages across protocols, simplifying model
    schema (LP: #1156941)
  * Add schema columns for latitude, longitude, and location name.
  * Fix 'likes' column from gdouble to guint64.
  * Add geotagging support from foursquare, facebook, flickr.
  * Implement since= for Facebook, reducing bandwidth usage.
  * Automatically prepend the required @mention to Twitter
    replies (LP: #1156829)
  * Automatically linkify URLs that get published to the model.
  * Fix the publishing of Facebook Stories (LP: #1155785)

  [ Ken VanDine ]
  * [FFe] replace gwibber-service with Friends (LP: #1156979)
  * friends-dispatcher crashed with friends.errors.AuthorizationError in
    _login_cb():
    GDBus.Error:com.google.code.AccountsSSO.SingleSignOn.Error.UserInter
    action: userActionFinished error: 10 (account: 1) (LP: #1135038)

  [ Robert Bruce Park <email address hidden>, Ken VanDine ]
  * [FFe] replace gwibber-service with Friends (LP: #1156979)
  * friends-dispatcher crashed with friends.errors.AuthorizationError in
    _login_cb():
    GDBus.Error:com.google.code.AccountsSSO.SingleSignOn.Error.UserInter
    action: userActionFinished error: 10 (account: 1) (LP: #1135038)

  [ Robert Bruce Park ]
  * friends-dispatcher crashed with friends.errors.AuthorizationError in
    _login_cb():
    GDBus.Error:com.google.code.AccountsSSO.SingleSignOn.Error.UserInter
    action: userActionFinished error: 10 (account: 1) (LP: #1135038)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 164
 -- Ubuntu daily release <email address hidden> Wed, 20 Mar 2013 14:30:42 +0000

Changed in friends (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in libunity (Ubuntu):
status: New → Confirmed
Michael Terry (mterry)
affects: unity (Ubuntu) → libunity (Ubuntu)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libunity - 6.90.2daily13.04.05-0ubuntu1

---------------
libunity (6.90.2daily13.04.05-0ubuntu1) raring; urgency=low

  [ Michael Terry ]
  * [FFe] replace gwibber-service with Friends (LP: #1156979)

  [ Didier Roche ]
  * Unity/Libunity unit tests broken by latest glib (LP: #1159677)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 215
 -- Ubuntu daily release <email address hidden> Fri, 05 Apr 2013 04:02:08 +0000

Changed in libunity (Ubuntu):
status: New → Fix Released
Ken VanDine (ken-vandine)
Changed in gwibber (Ubuntu):
status: Triaged → Fix Released
Ken VanDine (ken-vandine)
Changed in libfriends (Ubuntu):
status: Triaged → Fix Released
Changed in qml-friends (Ubuntu):
status: Triaged → Fix Released
Changed in unity-lens-friends (Ubuntu):
status: Triaged → Fix Released
Marco Trevisan (Treviño) (3v1n0)
Changed in libunity:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.