Merge lp:~vila/bzr/1606203-long-auth into lp:bzr/2.7
Proposed by
Vincent Ladeuil
Status: | Merged |
---|---|
Approved by: | Richard Wilbur |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6617 |
Proposed branch: | lp:~vila/bzr/1606203-long-auth |
Merge into: | lp:bzr/2.7 |
Diff against target: |
41 lines (+12/-1) 2 files modified
bzrlib/tests/test_http.py (+10/-0) bzrlib/transport/http/_urllib2_wrappers.py (+2/-1) |
To merge this branch: | bzr merge lp:~vila/bzr/1606203-long-auth |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Richard Wilbur | Approve | ||
Colin Watson (community) | Approve | ||
Review via email: mp+305328@code.launchpad.net |
Commit message
Fix lp:1606203 caused by using a user/pass combination for http auth longer than ~57 chars. (Vincent Ladeuil)
Description of the change
This fixes bug #1606203 caused by using a user/pass combination for http auth longer than ~57 chars.
To post a comment you must log in.
Vincent, What did the problem turn out to actually involve? Was it credentials "longer than ~57 chars" as the bug says or "creating a header value with an embedded '\n'" as a comment in the patch says? Or was it a combination of the two?
If it was the embedded '\n', how did that get in there?