Comment 15 for bug 287158

* Emilio Pozuelo Monfort <email address hidden> [2009-01-27 22:41:18 CET]:
> Not really. We want a Stable Release Update for a crasher, not a
> backport. Task opened, will try to look into this soonish, but if you
> can provide a diffstat and a diff of network_worker.cpp that would be
> nice.
>
> Gerfried, do you think it's reasonably safe to put 1.4.7 into Intrepid,
> or we rather cherry-pick the fix for this?

 I haven't done a direct diff, but usually wesnoth has strict guidelines
for their stable updates: There won't be any feature changes at all
because a stable release has to be compatible with every other patch
update to it. So, most of the times, the only changes are to the
translation files and bugfixes for crashes in campaigns or in gameplay
that don't expose a different behavior that would result in an OutOfSync
situation for multiplayer games (see LP #256345 for a story in this).

* Pauli <email address hidden> [2009-01-28 17:07:36 CET]:
> Fix for this crash is just a few lines change:
> http://svn.gna.org/viewcvs/wesnoth?rev=29514&dir_pagestart=100&view=rev

 Thanks for digging it up. :)

> I don't know much what has changed in 1.4.x.

 There's always the upstream changelog in the root source directory. :)

> But I think for wesnoth it would be reasonable to always upgrade to
> the latest stable version. Code wise it there is only bug fixes but
> all new graphics are ported to stable branch which adds huge amount
> changes to the stable branch.

 New graphics aren't that common but yeah, they happen. A stable release
isn't expected to look completely different than one before, and it
shouldn't.

 For convenience, the upstream changelog for 1.4.6 and 1.4.7:

#v+
Version 1.4.7:
 * campaigns:
   * Descent into Darkness
     * fixed bats crashing through the ice in 'Beginning of Revenge' (bug
         #12685)
   * Heir to the Throne:
     * Added an idle animation for L2 Princess.
 * graphics:
   * new or updated unit frames: Gryphon Rider, Gryphon Master
 * language and i18n:
   * updated translations: Danish, Finnish, Hungarian, Italian
 * miscellaneous and bug fixes:
   * replace a #elif without condition with #else (debian patch #505957)
   * fixed campaign replays (bug #12005)
   * start-of-scenario saves are properly marked as such

Version 1.4.6:
 * language and i18n:
   * updated translations: Czech, Danish, Finnish, French, Galician, German,
     Hungarian, Italian, Polish, Slovak, Turkish, Valencian
 * graphics
   * fixed the parts of the undead flags which were not TC'd
#v-

 I am not trying to convince you to push those in, especially since I
reworked a bit on the packaging end, too, especially in the 1.4.6-1
upload, even though that would close a LP bug:

#v+
  * New stable upstream release, bugfixes and translation updates:
    - Fixes assertion with End Turn (closes: #498154)
  * Lower wesnoth-music from Recommends to Suggests in wesnoth-data (LP:
  * #281791)
  * Rename wesnoth to wesnoth-core and wesnoth-all to wesnoth. Document
  * the
    switch in the NEWS file (closes: #500935)
  * Allow to hand over arguments to wesnoth-nolog.
  * Quote campaign names in package descriptions.
#v-

 So save bet is to just pick the bugfix, even though I guess that some
might disagree with it because technically it's "just" an upstream
stable release update with pretty tight rules in that respect - to some
degree possibly compareable to the postgresql updates within their 8.3
branches and so on.

 Hope that deeper insight helps a bit. :)
Rhonda