Comment 11 for bug 290874

On Dec 01, Chris Coulson wrote:
> Hang on, I'm wrong! I shouldn't have just skimmed through your post
> before replying ;)

I did hang on :-).

> Ok, so what you're saying is that the stop action failed during the
> upgrade because the daemon had failed to start earlier for some other
> reason. Missing the "--oknodo" option from start-stop-daemon would cause
> this, and you should probably open another bug report for that as the
> stop action should always exit gracefully if the daemon is not running
> (that issue is separate from this bug).

Quite right. The remark "/etc/init.d/opencryptoki stop does not stop
 pkcsslotd" is correct, but only since pkcsslotd didn't run in the first
place, somehow dying after the '/etc/init.d/opencryptoki start' at startup.
And (only) because of the missing "--oknodo" in the 'previous(!)'
/etc/init.d/opencryptoki this lets the upgrade go wrong!

> Thanks for spotting that.

You're welcome.
But: should I really open a separate bug report because of the then(!)
missing "--oknodo"? It is included in the actual version of the startup-
script, so it has already been spottet and fixed by someone, probably even
you. It used to be wrong, but isn't any longer. The problem 'just' is, how
to get rid of that bad version for people, like me, with that script
   a n d where the daemon didn't stay around, as the error then prevents
the upgrade. Otherwise, i.e. with a working daemon, the upgrade most likely
succeeds.

> Other than that, can you verify that the Intrepid fix for this original
> bug works, by running the test case above?

Which test case do you mean, exactly?
I can tell that with the new /etc/init.d/opencryptoki, a stop doesn't lead
to an error, even when the pkcsslotd doesn't run, but prints
"Stopping PKCS#11 slot daemon: pkcsslotd." as it would, when actually
terminating the pkcsslotd. Better yet, starting the machine or giving a
"/etc/init.d/opencryptoki start" actually makes and keeps pkcsslotd running
after the upgrade now - at least for me.

Is that, what you wanted to know?

For me to test if an upgrade would succeed from the 'bad' version, I would
have to re-install that. But I doubt that anything would change, it would
still go wrong, as the "stop" would produce the error in the startup-script
again.
But when you tell me, I'll try to restore that/an old version and see if
the upgrade works.

Best regards,
 Ruediger