Comment 3 for bug 293705

Revision history for this message
Bryce Harrington (bryce) wrote :

Hi Andrew, thanks for the debdiff.

I've a question though...

This patch appears to be doing two things. First, it's altering the priority on some debug messages - this part I think is perfectly fine.

The other part is affecting the message printing logic:

+--- nfs-utils-1.1.2.orig/utils/gssd/err_util.c
++++ nfs-utils-1.1.2/utils/gssd/err_util.c
+@@ -49,6 +49,10 @@
+ {
+ va_list args;
+
++ /* Decrease verbosity so we don't log so much */
++ if ((priority - verbosity) > 1)
++ return;
++
+ /* Don't bother formatting a message we're never going to print! */
+ if (priority > verbosity)
+ return;

So this is changing the logic so it avoids printing messages unless the 'priority' is more than 'verbosity+1'. This part I think should not be included. I think it's unnecessary anyway, and just doubles up on your other fix.

Would you mind re-rolling the debdiff with this piece omitted? (Or explain why it's needed if I'm missing something.)