Comment 9 for bug 291265

Revision history for this message
Thierry Carrez (ttx) wrote : Re: Buffer overflow in check_ntp_peer - Nagios can't check time servers in Intrepid

SRU report

Bug impact: Make Nagios ntp_check and ntp_check_peer plugins unusable under Intrepid. This is a regression, as this didn't trigger any error on previous releases.

Jaunty bugfix: fixed released in 1.4.12-4ubuntu2

Minimal patch: see below.

TEST CASE:
$ sudo apt-get install nagios-plugins-basic
With an affected version:
$ /usr/lib/nagios/plugins/check_ntp -H spork.qfe3.net -j 1
$ /usr/lib/nagios/plugins/check_ntp_peer -H spork.qfe3.net
both return a *** buffer overflow detected *** error stack
With a fixed version:
$ /usr/lib/nagios/plugins/check_ntp -H spork.qfe3.net -j 1
NTP OK: Décalage -0,006611943245 secs, jitter=0,000000|offset=-0,006612s;60,000000;120,000000; jitter=0,000000s;1,000000;10000,000000;0,000000
$ /usr/lib/nagios/plugins/check_ntp_peer -H spork.qfe3.net
NTP OK: Décalage -0,002 secs|offset=-0,002000s;60,000000;120,000000;

Regression potential:
The patch only affects those two plugins, and they are completely unusable without the fix.