Comment 3 for bug 118538

Revision history for this message
Kees Cook (kees) wrote :

This patch looks like a good start, however, I recommend some changes:
1) Move PID= definition higher, otherwise ARGS will not resolve it
2) use $() syntax instead of ``
3) drop the "else" section, otherwise "start" won't actually start when it removes a PID file
4) report that it is removing a "stale pid" file in the "start" section

Are there other services that do this that you can use for examples? Do the LSB tools (like start-stop-daemon) provide a way to deal with stale pid files already?