Comment 2 for bug 403286

Revision history for this message
StefanPotyra (sistpoty) wrote :

well, upstart descriptions would be a nice thing to have imo, but first we should get the package building/working again, which doesn't need an FFe being of bugfix nature.

Looking at the patch I've got the following comments:
1) the "function" keyword is a bashism, however functions are POSIX (and work with dash), so simplest way would be to just remove the function keyword
2) bash is Essential: Yes, so it won't add any "weight" to mini-httpd (despite that it loads slower and hence adds to boot time). This also means that it doesn't need to be in Depends. (however fixing 1 means to not need bash at all).
3) why do you rename putline as well? I might be wrong, but I don't recall that having been added to POSIX and a quick grep over /usr/include doesn't result in any matches.
4) Personally I'm in favor of trying to keep the patches down to a minimum (we'll otherwise have to redo them for the next merge), so I'd personally avoid bumping standards-version, debhelper version or adding the README about patched package (heh, finally I guess the last point is something every Ubuntu Developer knows by heart anyways *g*).

As 1) is fixed with 1.19-9.1, can you put the fix for getline on top of 1.19-9.1? Then I'd be happy to sponsor the upload.
Thanks,
    Stefan.