Comment 16 for bug 290885

Revision history for this message
Martin Pitt (pitti) wrote :

initramfs-tools:
 - patch changes previous changelog, and misses bug number
 - add_mountroot_fail_hook(): Changes behaviour of function. Please keep original function and add a add_mountroot_fail_hook_d() or so.
 - panic(): Why the chvt 1? Boot messages are usually on VT8, and this changes behaviour of an existing function.
 - panic(): Removes calling failure hooks without adding a call to the new try_failure_hooks(). Looks fishy and changes existing behaviour.
 - try_failure_hooks(): Unlike the code removed from panic(), this doesn't check if /tmp/mountroot-fail-hooks.d/ actually exists. Thus the script isn't "set -e" safe any more. Are any scripts in initramfs-tools relying on that and using set -e?
 - try_failure_hooks(): Why stop usplash? Shouldn't code just use usplash_write to output text? (This is just a nitpick, and I'm okay with doing it that way)