Comment 11 for bug 605551

Revision history for this message
Patrick Pfeifer (patrick2000) wrote :

Well, i would have really liked to test some more kernels but i'm hopelessly distracted by learning make-kpkg, git, fiddling with make-kpkg --append-to-version, wondering why somehow there is still a "+" added when i compile a patched vanilla 2.6.35 which causes make-dpkg to fail.

(It's because the tree is not in a clean state, there is no annotated (! - "git tag -a") git tag for the non-existant commit and therefore scripts/setlocalversion spits out the "+".)

Anyway ... by now I figured out (1% of) how to use make-kpkg as well as git and managed to "git clone --reference linus git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git".

$ cd linux-next
$ git describe
next-20100803
$ git diff v2.6.35 -- fs/ext4/super.c | grep FREEZE
- vfs_check_frozen(sb, SB_FREEZE_WRITE);
+ vfs_check_frozen(sb, SB_FREEZE_TRANS);
- vfs_check_frozen(sb, SB_FREEZE_WRITE);
+ vfs_check_frozen(sb, SB_FREEZE_TRANS);

At the end of the day .... this (imho) means 2.6.25 as well as 2.6.32.17 are non-functional with respect to live ext4 lvm snapshots but there is a good chance that future 2.6.36 and 2.6.32.18 will be working again.....

cheers

PS:
for the reference, i did "git clone --reference linus git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.32.y.git" as well and
$ cd linux-2.6.32.y
$ git describe
v2.6.32.17
$ git diff v2.6.32.16 -- fs/ext4/super.c | grep FREEZE
+ vfs_check_frozen(sb, SB_FREEZE_WRITE);
+ vfs_check_frozen(sb, SB_FREEZE_WRITE);
... this means v2.6.32.16 should be ok as well

PPS:
$ cd linus (git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git)
$ git diff v2.6.34 v2.6.35-rc1 -- fs/ext4/super.c | grep FREEZE
+ vfs_check_frozen(sb, SB_FREEZE_WRITE);
+ vfs_check_frozen(sb, SB_FREEZE_WRITE);
it looks like the change spoiling the current ubuntu 2.6.32-24-generic kernel came from change published by linus to an -rc tree only (despite it now having diffused to released 2.6.35 and 2.6.32.17 as well, sadly) ... why was that backported to the lucid kernel so early ?