Comment 18 for bug 2039577

There are two different places in the code where the status is checked, one for the main "sharing" window and one for the small "remote login" window.

The small "remote login" window does the check in cc-remote-login.c by doing all the dbus calls asynchronously with callbacks. This code patch has been addressed by the patch in comment #12.

The main "sharing" window check is done in is_remote_desktop_enabled() in cc-sharing-panel.c by calling cc_is_service_active() in cc-systemd-service.c which does all the dbus calls synchronously. I don't believe that check has been addressed by the patch in comment #12.

I wonder if it's worth having all that code duplicated, and being done asynchronously...it would certainly be easier if we could just have a single synchronous function for both checks, but I wonder if that would have an impact on the widget in the dialog.

In any case, the main "sharing" window code needs to be fixed.