Comment 26 for bug 239952

Revision history for this message
In , Mh+mozilla (mh+mozilla) wrote :

(In reply to comment #6)
> getFromTypeAndExtention('someType', 'someExtension') guarantees a return value
> that has type 'someType'. It probably shouldn't return any extensions other
> than 'someExtension' and the known extensions for 'someType'.

But what is supposed to happen when 'someType' is something that doesn't exist ?

> We seriously need a regression suite for this code; it's pretty fragile, and UI
> consumers depend on the details to get behavior right in a number of corner
> cases, including some security bugs... Ideally we could find someone to go
> through all the old bugs on this and write tests.

I'm trying to write an exhaustive test, though I can only write tests for the unix port. I think a third of the tests I'm currently writing could be made to work on the other ports, but the rest is going to be tricky. This is also why I'd like to be able to do some testing on Windows at least. I must say it would be useful to have xpcshell shipped in tinderbox builds and the test suite been made easily runnable with these builds (i.e. without having really built or configured the build)