Comment 59 for bug 359658

Revision history for this message
Oded Arbel (oded-geek) wrote :

I'm sorry, but I didn't encounter this problem again on my system.

My personal opinion as a developer is that changing bad code for good code is a good idea, and even if the original problem is not reproduceable and even if the patch is not being tested, that fix still makes sense and should go in - preventing SIGSEGV should be no. 1 priority of developers.

Here's the GNOME official documentation of g_str_equal() (the call being replaced by the patch):
---8<---
Note that this function is primarily meant as a hash table comparison function. For a general-purpose, NULL-safe string comparison function, see g_strcmp0().
---8<---

Which as I read it means: don't ever use g_str_equal() as a general string comparison method. IMHO no testing feedback should be required to apply this patch, because it makes sense the original code is bad.