OK, my patch changes what was expected to be 32 bits of randomness to 31 bits of randomness.
Its probably not that big of a deal, but upstream should probably do:
- key = hex(BN.rand(16 * 8,top=0))[2:34]
+ key = hex(BN.rand(17 * 8,top=0))[3:35]
that will get the same 32 bits of randomness, but will still have the 32 bits of random number that were intended.
OK, my patch changes what was expected to be 32 bits of randomness to 31 bits of randomness.
Its probably not that big of a deal, but upstream should probably do:
- key = hex(BN.rand(16 * 8,top=0))[2:34]
+ key = hex(BN.rand(17 * 8,top=0))[3:35]
that will get the same 32 bits of randomness, but will still have the 32 bits of random number that were intended.